Re: [PATCH v2 0/4] sched: HQoS Library cleanup

[Thomas Monjalon <thomas@monjalon.net>]

18/02/2022 11:58, Dumitrescu, Cristian:
> 
> > -----Original Message-----
> > From: Ajmera, Megha <megha.ajmera@intel.com>
> > Sent: Friday, February 18, 2022 9:37 AM
> > To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> > Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
> > thomas@monjalon.net; david.marchand@redhat.com
> > Subject: [PATCH v2 0/4] sched: HQoS Library cleanup
> > 
> > v2:
> > * Rebased with latest main branch code resolved conflicts.
> > 
> > v1:
> > This patchset involves the cleanup of HQoS Library:
> > 
> > * Removed unused HQoS #defines from rte_config.
> >   RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS,
> > RTE_SCHED_SUBPORT_TC_OV, RTE_SCHED_VECTOR
> > 
> > * RTE_SCHED_COLLECT_STATS flag is removed from the code.
> >   Stats collection is now always enabled.
> > 
> > * RTE_SCHED_SUBPORT_TC_OV flag is removed.
> >   TC subscription for best effort queues is always enabled in HQoS library.
> > 
> > * RTE_SCHED_VECTOR flag is removed from HQoS library as the code under
> > this
> >   flag is no longer useful.
> > 
> > 
> > Megha Ajmera (4):
> >   sched: Cleanup qos scheduler defines from rte_config
> >   sched: Always enable stats in HQoS library.
> >   sched: Always enable best effort TC oversubscription in HQoS library.
> >   sched: Removed code defined under VECTOR Defines.
> > 
> >  config/rte_config.h                        |   8 +-
> >  doc/guides/sample_app_ug/qos_scheduler.rst |   3 +-
> >  lib/sched/rte_sched.c                      | 156 +--------------------
> >  3 files changed, 5 insertions(+), 162 deletions(-)
> > 
> > --
> > 2.25.1
> 
> Do people feel the need to have a cover letter for this patchset? IMO it does not add any useful info, so my vote is to discard the cover letter.

Yes cover letter is needed.
It is good to have a summary,
and it helps to have a clean threading in emails.
The cover letter should be a reply to the cover letter of the first version.