From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB9E2A0032; Fri, 18 Feb 2022 12:49:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB44C40150; Fri, 18 Feb 2022 12:49:54 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 4DF3740141 for <dev@dpdk.org>; Fri, 18 Feb 2022 12:49:53 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BF8803201F94; Fri, 18 Feb 2022 06:49:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 18 Feb 2022 06:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=j1aAfCmimb7HP+ xrzQbfcgFgsGJIYCqF5942m8bjhOI=; b=MS46OJFs84NCAPk++G7NIiWnX8W1/j d5URvgDxaI1dRfOMBJi78L4MH9QcamIjnqJnrJX/j/XK+R+So+/kGJnLzEJwCVmA 1kH5VH6xdDl0foMpfwq2XWl8gZ/Pjj1q1tSmC1lWX90VpsyCUggN9ps5j1WkF4f2 djicnN5h+Tqu3EoDguBqkfnfe9xMv49LN8Ej7aLHChrxMYr3cqBuu3T7FXoKkkM9 OSsvvIcqNv8aohFUp72ayndO+hTSqKE1wQe6/3JT9Z+h6apOzpQURg3Wpks38p7l Tv2X+8MNp90ohj372OLaMx84/iUkdmDSAaeUkg1oWaKLCD2z0cyff31Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=j1aAfCmimb7HP+xrzQbfcgFgsGJIYCqF5942m8bjhOI=; b=SbMj4WUX EH6L0IMmGpw6d6T8MW34A+NIYPWxAfkSgMZYU/fdKi4CqMJ4/wrXThBA8d56+XLZ BrhMygHB7be3gwP9qmM1GwvrUQ/tZM4x9TW2qT1yWeuD1DL9t+JiACKDNhkIiXJe upiKdBGIMOqVkAvYl5WSjczG9Wj6nGmnAXtnLyktEMhW6l5NatTggxPjGl4MkkPn vUEMe2MTr+UEcwKsi6wt1Ma9G1tlU/nftnYJZVAIuCoegKhASyWh57sMCKcdMc14 2Fsi4+cYzykBmj7GREtsVsAVS5FU0+I/NCeOtsuhjEi9M+QIdBNHGw8cfSDPpz8H Gl1N6bExiXg77Q== X-ME-Sender: <xms:3ocPYuqoWFQgAYTm922o8EO9aDV09MWegsa-HQhDMfZttkwtNsRtqw> <xme:3ocPYspDMH0U8TKYaUeSuzJosfkyQ7c-8EvcYkVdhRsTuzWp0VWWW7FWQUEsoOpAW sUGCFE9fJDdt-R12Q> X-ME-Received: <xmr:3ocPYjOxDEwy5Kj7UBAj7f0MwOwyCFhYKDvR6G_UzTRfjsJJv47L_7wDzgezeJtPK4uRyQOV9liZ1V84pl2NhIj5YQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkedtgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:34cPYt6wgqLQ6xaFwEM6pFTm6T5b6GvDZVncYRjCQHTBcnkqtydc6A> <xmx:34cPYt6GeGlatKK36iVPIS7I_sG11YmzF4a-xE8S-F_sKZOnCFHfJw> <xmx:34cPYth8C4s9n8RkpNmPfYZGchytn3CfgT2qNpCVGY4-I5dao70cPw> <xmx:34cPYnml5Scb51Fygwr7Heex7OHisg3H8ioe1jYAUggx3EJ_sCWR6A> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Feb 2022 06:49:50 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "Ajmera, Megha" <megha.ajmera@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Singh, Jasvinder" <jasvinder.singh@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> Subject: Re: [PATCH v2 0/4] sched: HQoS Library cleanup Date: Fri, 18 Feb 2022 12:49:48 +0100 Message-ID: <4572010.neEnAmRlxL@thomas> In-Reply-To: <DM8PR11MB56701E1F1C1CC515EF0AB887EB379@DM8PR11MB5670.namprd11.prod.outlook.com> References: <20220218093650.2549927-1-megha.ajmera@intel.com> <DM8PR11MB56701E1F1C1CC515EF0AB887EB379@DM8PR11MB5670.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 18/02/2022 11:58, Dumitrescu, Cristian: > > > -----Original Message----- > > From: Ajmera, Megha <megha.ajmera@intel.com> > > Sent: Friday, February 18, 2022 9:37 AM > > To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; > > Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; > > thomas@monjalon.net; david.marchand@redhat.com > > Subject: [PATCH v2 0/4] sched: HQoS Library cleanup > > > > v2: > > * Rebased with latest main branch code resolved conflicts. > > > > v1: > > This patchset involves the cleanup of HQoS Library: > > > > * Removed unused HQoS #defines from rte_config. > > RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS, > > RTE_SCHED_SUBPORT_TC_OV, RTE_SCHED_VECTOR > > > > * RTE_SCHED_COLLECT_STATS flag is removed from the code. > > Stats collection is now always enabled. > > > > * RTE_SCHED_SUBPORT_TC_OV flag is removed. > > TC subscription for best effort queues is always enabled in HQoS library. > > > > * RTE_SCHED_VECTOR flag is removed from HQoS library as the code under > > this > > flag is no longer useful. > > > > > > Megha Ajmera (4): > > sched: Cleanup qos scheduler defines from rte_config > > sched: Always enable stats in HQoS library. > > sched: Always enable best effort TC oversubscription in HQoS library. > > sched: Removed code defined under VECTOR Defines. > > > > config/rte_config.h | 8 +- > > doc/guides/sample_app_ug/qos_scheduler.rst | 3 +- > > lib/sched/rte_sched.c | 156 +-------------------- > > 3 files changed, 5 insertions(+), 162 deletions(-) > > > > -- > > 2.25.1 > > Do people feel the need to have a cover letter for this patchset? IMO it does not add any useful info, so my vote is to discard the cover letter. Yes cover letter is needed. It is good to have a summary, and it helps to have a clean threading in emails. The cover letter should be a reply to the cover letter of the first version.