From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4F27237B0 for ; Wed, 30 May 2018 12:18:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AF33E21C5D; Wed, 30 May 2018 06:18:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 May 2018 06:18:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=9leFTB4NR5xRys7gUkWie3BxQw u720vUL+PY6IPCceI=; b=USXvmFH39AhJTJOA9twsTlrgH8ezLj93fiEpGWMtLl xKuo79WEXFZYcGcuKGqpqHquldBdNQi8foWfJ1jvmJ77rb3uNkUB2yPAnT9a90nc NUUPJciDR3hSMrvZCGdlvPUX9yCPwO/L2cOObNFuGDx528O5gT39PAW1I57AHkpU Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=9leFTB 4NR5xRys7gUkWie3BxQwu720vUL+PY6IPCceI=; b=LLt3f/fgt59Qd6FtaxUDWD Mq1xiXmRpjwZmKQq/eNjI6efyZ8D6jqgFzZU8L3+Lwql8VVNoMrWpLKicv0T2a4q /tZx3wo/X5RcO5SGt6JYhXydY6IAQjctdxGfnlriF6oCWsJhdspKSf9bquf7x30a a/6nbzigiKj+HhXnw6spjN8B95D1BE9BqA9ASqg8KEqV6tDXmcXm3vzjlVRNUYdR g0R/jWpzlMzSdsk3KHiSsjENpCtBzw62vWDuJ31GvFuxwblA0dMizbJZQIudfsrW CvDl1DCXYjz45WtAUTa14K82t0Atqj/SBc+iB+75Ne7YyAdCIpOrd4vzWz5R1Qjg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED8E7E40A3; Wed, 30 May 2018 06:18:15 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: Bruce Richardson , "dev@dpdk.org" Date: Wed, 30 May 2018 12:18:14 +0200 Message-ID: <4579229.sggoYGe59P@xps> In-Reply-To: References: <3248809.BvU3dfXijd@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 1/2] mk: fix cross build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 10:18:17 -0000 30/05/2018 11:41, Gavin Hu: > From: Thomas Monjalon > > 30/05/2018 04:45, Gavin Hu: > > > From: Bruce Richardson > > > > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote: > > > > > 28/05/2018 15:24, Bruce Richardson: > > > > > > Would a simpler solution for this not be to put "-Wno-implicit- > > > > fallthrough" > > > > > > for pmdinfogen? GCC will not give a warning for an unrecognised "- > > Wno" > > > > > > flag when compiling, unless there are other errors. This means > > > > > > we can just use the flag without bothering with version checks. > > > > > > > > > > No, it does not work. > > > > > I have this error with clang 5.0.1: > > > > > error: unknown warning option '-Wno-format-truncation' > > > > > > > > > Yes, you still need to check for GCC to use the flag, just not for a > > > > specific version of GCC. > > > > > > > > /Bruce > > > [Gavin Hu] Hi Thomas, '-Wno-format-truncation' is applied to gcc only, not > > to clang. > > > Gcc, icc and clang have their own WERROR_FLAGS, they should not mix up > > with each other. > > > > Now I understand what we missed from the beginning: I am testing with > > meson. > > This flag is added unconditionnaly in config/meson.build. > > [Gavin Hu] Hi Thomas and Bruce, then do you have more comments on the v5 patch? > Any comments are welcome, if no, can you act the patches for merging? Of course we have comments! I keep telling you that compilation is not working. Try meson compilation: devtools/test-meson-builds.sh