From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D355A04DB; Thu, 15 Oct 2020 09:31:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C75C1DCC9; Thu, 15 Oct 2020 09:31:51 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id CE6B21C238 for ; Thu, 15 Oct 2020 09:31:48 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 4C7219EB; Thu, 15 Oct 2020 03:31:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 15 Oct 2020 03:31:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= IFUVdpXCOZgkzZSnMC7K+PTljDZOM4/pp5TlsFhwwf4=; b=GMP2s70f3jkdFe69 EnPQUWDOBctvVXs1PzvDfp8RxcH0mx+rRJQ42SHXv32dqPoV+hRxZ5C54YGK4l4u r/u7ry2Eu0EZoAcQ9Tb5Yr93ms8L959MAMAne/Z6EKZgnSQLq32zPmM4mnbe7IJc nPdCCbljsxZe/Yyt3qIZ5FDynU8PGm08cEODFacqJSVlwak8QmzGnNTxIwMt+Nna yFBVKjNQFPrz5pQixD8zmFsHXmHD5Bqtw1cO2LjNMWw++bXvGnlsjhxqRNBNR9jU rRYDPxYEc/14QkgTHbM5LZXLtDxKf9ZoNhUXRraDuP84Wa6GZYFKHsGA1ZD3wbJG 8Ndl8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IFUVdpXCOZgkzZSnMC7K+PTljDZOM4/pp5TlsFhww f4=; b=kedf6RPHYJX8nlfmiz/9qfyxEqcrz7qXXWs7+dkZGn1xa3/K1dEllRUMj hoJax3ki9o1w/JpF36rKJzGT1DfYTYb9s/OUX5QuJ6ZD2pLKEI4RZ0TZQTV81ywM 0zZFmBefYDZfeIhWsEB4eHzdCDvaAdtgoSQeZatMCdPklUPtUSetTe2tn0QsrpdD PyqsI5CMOF9y3uCjJ/5DxR8/u6BnnHqfMiXMlXA/kAcma+JUaAWgR5dpUtISoevh DJsmoSbHuzHE9ek/QMYYV7xx1FjsvBv8/32A4glLxGV8CYG6/ml7qrdfNzvIg2L/ I+ykyJeOd97SE3iWGNBWuzfWj+noA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedvgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B9A483064610; Thu, 15 Oct 2020 03:31:43 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: Ori Kam , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "bernard.iremonger@intel.com" , "beilei.xing@intel.com" , "wenzhuo.lu@intel.com" , "dev@dpdk.org" Date: Thu, 15 Oct 2020 09:31:42 +0200 Message-ID: <45793960.IEASBUnxTT@thomas> In-Reply-To: References: <1602147098-9768-1-git-send-email-bingz@nvidia.com> <3492876.G95Fza0IFT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/10/2020 04:56, Bing Zhao: > From: Thomas Monjalon > > 08/10/2020 14:05, Bing Zhao: > > > +int > > > +rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port) { > > > + struct rte_eth_dev *dev; > > > + int ret; > > > + > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(tx_port, -EINVAL); > > > > It should be -ENODEV > > Got it, changed. BTW, I checked the ethdev and it seems some functions are using "EINVAL" and some are using "ENODEV". So should all of these functions use "ENODEV"? Yes there is a patch pending to return ENODEV everywhere: https://patches.dpdk.org/patch/80568/