From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id E24B5E6D for ; Fri, 23 Sep 2016 16:12:37 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id l132so34214163wmf.0 for ; Fri, 23 Sep 2016 07:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=7bVyUz1m3lLZMUMzaL5NprdzzDoE/GeDrRBqq4dUbro=; b=b5z4Ep1c1FTm4zGRACH4IMAkneZKB+Wwc9YJYgE/wOyy7VcarkJOfg7nA+FD91vWaO fxL79Jy6EFiI9o8vEZbESHp81J2f9OTrqmAzh7/bH21QJu6VGckt14aYOt1e4uqpNETQ +0hAXrMfLZs/lxl+dN8B7/k33qPXD+3XmOygYwwDP4Q/evRLrla4CPC6om3XZqHyXz3t 8dcSW3MY53dJBGrb2l0iloqmL2QenC8gN7nlJVgA2Qf14LsORzrMlw1amBejnGMgNxji nhnPlApXVsW5z09eXdwoM4V7GCBgbbcauZSFqEG2EtfmLsz5xu+dehNpLeWRTKI88ITj wXxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=7bVyUz1m3lLZMUMzaL5NprdzzDoE/GeDrRBqq4dUbro=; b=IT7oLIBptXNCU0LvFw77SEkkrc9HymgJDfsZHmuF5jDuhk8G4Omt1bSn4TTzYthooh QhUk47ZVwmQGCLgA0fLi88eabcbDPeMnVG6QVyGA/NTABqnSgpd11DrWlvoScEFHJ4Fb a+qmC4RwoWLvrIdcZCY8/wBOIyGYeJhuDObw5NBQ6nsON+/VEWGJsqTNIlLjTEcuaqf0 57J/temlUdbvinNvmDr+pnAeuKQu1pu0zQeQYPGMFWiikLrXznx970n/4rv+nC87dJC7 +w3boljVA6sSYoXjdtWdtLeIzeKEdEHr5UzzjTcP+VbUruMFg5y+lcP1Rg4Dwaak1fRB 11nQ== X-Gm-Message-State: AE9vXwMGW76Z2mbBKZV6MtPZ+4HqOo8fAOsPR/SR1LB+xe1Wr+rt8CgPFsAYFUu9CdUgAjNk X-Received: by 10.195.17.226 with SMTP id gh2mr8045352wjd.15.1474639957717; Fri, 23 Sep 2016 07:12:37 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id w138sm4059180wmd.1.2016.09.23.07.12.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Sep 2016 07:12:36 -0700 (PDT) From: Thomas Monjalon To: "Kerlin, MarcinX" Cc: "Pattan, Reshma" , dev@dpdk.org, "De Lara Guarch, Pablo" Date: Fri, 23 Sep 2016 16:12:34 +0200 Message-ID: <4580114.oiHn6CQCKM@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <68D830D942438745AD09BAFA99E33E812AA347@IRSMSX102.ger.corp.intel.com> References: <1472806710-25866-2-git-send-email-marcinx.kerlin@intel.com> <3AEA2BF9852C6F48A459DA490692831F010A59C3@IRSMSX109.ger.corp.intel.com> <68D830D942438745AD09BAFA99E33E812AA347@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite device data in mp app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 14:12:38 -0000 2016-09-22 14:11, Kerlin, MarcinX: > Hi Reshma, > > From: Pattan, Reshma > > > > Hi Marcin, > > > > > /** > > > * @internal > > > + * Returns a shared device data slot specified by the unique identifier name. > > > + * > > > + * @param name > > > + * The pointer to the Unique identifier name for each shared > > > +Ethernet device > > > + * between multiple processes. > > > + * @return > > > + * - The pointer to the device data slot, on success. NULL on error > > > + */ > > > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char > > > +*name); > > > > This should be static function in source file rather than public function. > > And name can be rte_eth_dev_get_dev_by_name() something like that? > > 1) Yes should be, this function is not using outside lib now, thanks > 2) My proposition is rte_eth_dev_get_dev_data_by_name(), because it is related with device data structure.. Do you have any objections Thomas? No objection on the name. But the whole patch looks strange. > I am waiting for still some objections and then prepare v3 Please could you better state the problem you want to solve in the messages of each v3 patch? I'll try to understand and review the v3. Thanks