DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, "Rong, Leyi" <leyi.rong@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	"Kadam, Pallavi" <pallavi.kadam@intel.com>,
	dev@dpdk.org, Ali Alnubani <alialnu@nvidia.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Tal Shnaiderman <talshn@nvidia.com>, Odi Assli <odia@nvidia.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Menon, Ranjit" <ranjit.menon@intel.com>,
	Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e
Date: Thu, 28 Jan 2021 22:24:48 +0100
Message-ID: <4580320.ODmCHreTiB@thomas> (raw)
In-Reply-To: <20210128233522.0d803796@sovereign>

28/01/2021 21:35, Dmitry Kozlyuk:
> On Tue, 26 Jan 2021 16:51:19 +0000, Ferruh Yigit wrote:
> > On 1/26/2021 4:48 PM, Thomas Monjalon wrote:
> > > 26/01/2021 17:39, Ferruh Yigit:  
> > >> On 1/26/2021 4:22 PM, Thomas Monjalon wrote:  
> > >>> 26/01/2021 17:17, Rong, Leyi:  
> > >>>>>> On 1/20/2021 11:21 PM, Ferruh Yigit wrote:
> > >>>>>>
> > >>>>>> And for the mingw, I have same result with Ali, I can reproduce with (Fedora  
> > >>>>> MinGW 9.2.1-6.fc32).  
> > >>>>>>
> > >>>>>> But different from the CI, I am getting the error [1] for all following files:
> > >>>>>> rte_random.c
> > >>>>>> i40e_rxtx_vec_sse.c
> > >>>>>> i40e_rxtx_vec_avx512.c
> > >>>>>> i40e_rxtx_vec_avx2.c
> > >>>>>> rte_ethdev.c  
> > >>> [...]  
> > >>>> Send patch https://patchwork.dpdk.org/patch/87349/ to disable avx512 on windows as the workaround.
> > >>>> Pallavi also tested with this patch, and passed the mingw and clang build. Will try to see if has better way to fix.  
> > >>>
> > >>> Ferruh mentioned errors with other files outside of i40e.
> > >>>  
> > >>
> > >> The patch globally disables the avx512 for windows cross build, not just for
> > >> i40e, so I confirm it fixes the build errors in my environment.
> > >>
> > >> But disabling avx512 like this is not best option.  
> > > 
> > > Some may argue that AVX512 is not the best option ;)
> > >   
> > 
> > flame war mode activated.
> 
> I found the following fix working:
> 
> --- a/drivers/net/i40e/meson.build
> +++ b/drivers/net/i40e/meson.build
> @@ -60,6 +60,9 @@ if arch_subdir == 'x86'
>  		if cc.has_argument('-march=skylake-avx512')
>  			avx512_args += '-march=skylake-avx512'
>  		endif
> +		if is_windows and cc.get_id() == 'gcc'
> +			avx512_args += '-fno-asynchronous-unwind-tables'
> +		endif
>  		i40e_avx512_lib = static_library('i40e_avx512_lib',
>  				'i40e_rxtx_vec_avx512.c',
>  				dependencies: [static_rte_ethdev,
> 
> It's admittedly from StackOverflow, but after reading about
> -fno-asynchronous-unwind-tables I see no harm disabling it, at least for just
> one file.

Thanks, it will require some tests and approvals.
For now, I take the patch proposing a simple disabling of AVX512 with MinGW.



      reply	other threads:[~2021-01-28 21:24 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15  2:19 [dpdk-dev] [PATCH " Leyi Rong
2020-12-15  2:19 ` [dpdk-dev] [PATCH 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2020-12-15  2:19 ` [dpdk-dev] [PATCH 2/3] net/i40e: add AVX512 vector path Leyi Rong
2020-12-15  2:19 ` [dpdk-dev] [PATCH 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-07  7:44 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on i40e Leyi Rong
2021-01-07  7:44   ` [dpdk-dev] [PATCH v2 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2021-01-13  6:12     ` Lu, Wenzhuo
2021-01-13 13:40     ` Ferruh Yigit
2021-01-07  7:44   ` [dpdk-dev] [PATCH v2 2/3] net/i40e: add AVX512 vector path Leyi Rong
2021-01-13  6:13     ` Lu, Wenzhuo
2021-01-07  7:44   ` [dpdk-dev] [PATCH v2 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-13  6:12     ` Lu, Wenzhuo
2021-01-13  9:53   ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on i40e Zhang, Qi Z
2021-01-14  6:39 ` [dpdk-dev] [PATCH v3 " Leyi Rong
2021-01-14  6:39   ` [dpdk-dev] [PATCH v3 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2021-01-15 13:36     ` Ferruh Yigit
2021-01-14  6:39   ` [dpdk-dev] [PATCH v3 2/3] net/i40e: add AVX512 vector path Leyi Rong
2021-01-14  6:39   ` [dpdk-dev] [PATCH v3 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-14  7:37   ` [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e Zhang, Qi Z
2021-01-17 11:26     ` Odi Assli
2021-01-18 13:58       ` Rong, Leyi
2021-01-18 14:24         ` Ferruh Yigit
2021-01-18 14:53           ` Odi Assli
2021-01-18 16:36             ` Ferruh Yigit
2021-01-19 13:46               ` Ali Alnubani
2021-01-20  6:25                 ` Tal Shnaiderman
2021-01-20  8:36                   ` David Marchand
2021-01-20  9:18                     ` Ferruh Yigit
2021-01-20  9:23                     ` Thomas Monjalon
2021-01-20  9:53                       ` David Marchand
2021-01-20 10:05                         ` Ali Alnubani
2021-01-20 17:51                           ` Ferruh Yigit
2021-01-20 18:04                             ` Ferruh Yigit
2021-01-21  5:01                             ` Kadam, Pallavi
2021-01-25 14:35                               ` David Marchand
2021-01-26 16:17                                 ` Rong, Leyi
2021-01-26 16:22                                   ` Thomas Monjalon
2021-01-26 16:39                                     ` Ferruh Yigit
2021-01-26 16:48                                       ` Thomas Monjalon
2021-01-26 16:51                                         ` Ferruh Yigit
2021-01-28 20:35                                           ` Dmitry Kozlyuk
2021-01-28 21:24                                             ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4580320.ODmCHreTiB@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@nvidia.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=ferruh.yigit@intel.com \
    --cc=leyi.rong@intel.com \
    --cc=odia@nvidia.com \
    --cc=pallavi.kadam@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=rasland@nvidia.com \
    --cc=talshn@nvidia.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git