From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E11AA0A0E; Mon, 10 May 2021 17:55:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C105540140; Mon, 10 May 2021 17:55:28 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 0BD764003E; Mon, 10 May 2021 17:55:27 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A72A25C0176; Mon, 10 May 2021 11:55:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 10 May 2021 11:55:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= RsnNXkKrr0nLQ96AF2BGrNpoRn5XgrTbJ6PZ/Rw4Dao=; b=HDsWoQWkP9X4xMqm FzyRX/WFGC4u1hl14rzEeKxr2stgOser44SFXxAtSM/US19eye9I4XW5hl8swUa4 nH3IfNf1uYkZ2GvBdi9h29bxNMsM16USkGDmk5guwAuRtDjRMrLudsqf73kfFOSI PCVE0u9Yj3NYDGGW9bFq4imhrxUKnBcPe1VPeadKZfQavwgzL1He35w+JeXozv3s TFQqT7DW7vLePoiZc0MG9EbZJAjtYlGbLehZiR97FCtGlznQt2XrF+IZwnS3gaE8 ZvhPiFDygsO6sqBZos+LBz/iQ4jCq/Q2FRZdrEw663IajGCLwFuhXQQ+gh0wVszD yy1bqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RsnNXkKrr0nLQ96AF2BGrNpoRn5XgrTbJ6PZ/Rw4D ao=; b=A8BOA4ASIBt4cOo610DyLCdhJ0mBBeFNtETSOP5p6aDWG1OFxgGNUX4CX c2v5ppjttIZdPaM9tzSTsjwTFL/YERL/lhGpfDMH911dClgEVI02DGaA+6AErihk FOJ8sMNlggpV1ag49GM4fs1n/FrMvv585mzDGiKG5/603cytnjKzRKnd7jkv/8lX ItD9PmztRmtXrv1K2QNsri69Bl8SgJo2zfgQjGQYhlo9VcStksbh6BzJmvlbK3Lo NLfd3rrXNT5QaPF7CbDKDzM82VHW6ScXDsLnoKAsBqnVejgmhDacqNDcPAugoxT8 3MY5Eaj9dktAu37nDN9sQR2+3mB8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegkedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 May 2021 11:55:23 -0400 (EDT) From: Thomas Monjalon To: Lance Richardson , "Burakov, Anatoly" Cc: Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, stable@dpdk.org Date: Mon, 10 May 2021 17:55:21 +0200 Message-ID: <4580427.4aQfPY00Ab@thomas> In-Reply-To: <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com> References: <20210507181025.84012-1-lance.richardson@broadcom.com> <2003089.4ItjxMFgZf@thomas> <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2021 17:31, Burakov, Anatoly: > On 10-May-21 1:42 PM, Thomas Monjalon wrote: > > +Cc Anatoly > > > > 08/05/2021 16:27, Lance Richardson: > >> For 32-bit targets, size_t is normally a 32-bit type and > >> does not have sufficient range to represent 64-bit offsets > >> that can are needed when mapping PCI addresses. Use uint64_t > >> instead. > >> > >> Found when attempting to run 32-bit Linux dpdk-testpmd > >> using VFIO driver: > >> > >> EAL: pci_map_resource(): cannot map resource(63, 0xc0010000, \ > >> 0x200000, 0x20000000000): Invalid argument ((nil)) > >> > >> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers") > >> Cc: stable@dpdk.org > >> Signed-off-by: Lance Richardson > >> --- > > LGTM, although the Fixes: tag is probably wrong because IIRC previous > versions did have the same issue. What should be the right Fixes tag Anatoly?