* [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity
@ 2019-02-14 13:27 David Marchand
2019-02-14 16:44 ` Burakov, Anatoly
2019-02-19 20:38 ` [dpdk-dev] [PATCH v2] " David Marchand
0 siblings, 2 replies; 9+ messages in thread
From: David Marchand @ 2019-02-14 13:27 UTC (permalink / raw)
To: dev
pthread_getaffinity_np returns a >0 value when failing.
This is mainly for the sake of correctness.
The only case where it could fail is when passing an incorrect cpuset
size wrt to the kernel.
Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/common/eal_common_options.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 6c96f45..1f45f82 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
unsigned int lcore_id;
unsigned int removed = 0;
rte_cpuset_t affinity_set;
- pthread_t tid = pthread_self();
- if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
- &affinity_set) < 0)
+ if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
+ &affinity_set))
CPU_ZERO(&affinity_set);
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity
2019-02-14 13:27 [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity David Marchand
@ 2019-02-14 16:44 ` Burakov, Anatoly
2019-02-14 17:41 ` David Marchand
2019-02-19 20:38 ` [dpdk-dev] [PATCH v2] " David Marchand
1 sibling, 1 reply; 9+ messages in thread
From: Burakov, Anatoly @ 2019-02-14 16:44 UTC (permalink / raw)
To: David Marchand, dev
On 14-Feb-19 1:27 PM, David Marchand wrote:
> pthread_getaffinity_np returns a >0 value when failing.
>
> This is mainly for the sake of correctness.
> The only case where it could fail is when passing an incorrect cpuset
> size wrt to the kernel.
>
> Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_eal/common/eal_common_options.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 6c96f45..1f45f82 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
> unsigned int lcore_id;
> unsigned int removed = 0;
> rte_cpuset_t affinity_set;
> - pthread_t tid = pthread_self();
>
> - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
> - &affinity_set) < 0)
> + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
> + &affinity_set))
> CPU_ZERO(&affinity_set);
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
>
CC: stable?
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity
2019-02-14 16:44 ` Burakov, Anatoly
@ 2019-02-14 17:41 ` David Marchand
2019-02-19 11:40 ` Burakov, Anatoly
0 siblings, 1 reply; 9+ messages in thread
From: David Marchand @ 2019-02-14 17:41 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: dev
On Thu, Feb 14, 2019 at 5:44 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:
> On 14-Feb-19 1:27 PM, David Marchand wrote:
> > pthread_getaffinity_np returns a >0 value when failing.
> >
> > This is mainly for the sake of correctness.
> > The only case where it could fail is when passing an incorrect cpuset
> > size wrt to the kernel.
> >
> > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > lib/librte_eal/common/eal_common_options.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> > index 6c96f45..1f45f82 100644
> > --- a/lib/librte_eal/common/eal_common_options.c
> > +++ b/lib/librte_eal/common/eal_common_options.c
> > @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
> > unsigned int lcore_id;
> > unsigned int removed = 0;
> > rte_cpuset_t affinity_set;
> > - pthread_t tid = pthread_self();
> >
> > - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
> > - &affinity_set) < 0)
> > + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
> > + &affinity_set))
> > CPU_ZERO(&affinity_set);
> >
> > for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> >
> CC: stable?
>
Not really sure about CCing stable for this.
I did not get errors with pthread_getaffinity_np so far.
Afaiu, it would need the kernel and libc to have different cpuset sizes.
I did not investigate in which situations it could happen.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity
2019-02-14 17:41 ` David Marchand
@ 2019-02-19 11:40 ` Burakov, Anatoly
2019-02-19 11:55 ` David Marchand
0 siblings, 1 reply; 9+ messages in thread
From: Burakov, Anatoly @ 2019-02-19 11:40 UTC (permalink / raw)
To: David Marchand; +Cc: dev
On 14-Feb-19 5:41 PM, David Marchand wrote:
>
>
> On Thu, Feb 14, 2019 at 5:44 PM Burakov, Anatoly
> <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
>
> On 14-Feb-19 1:27 PM, David Marchand wrote:
> > pthread_getaffinity_np returns a >0 value when failing.
> >
> > This is mainly for the sake of correctness.
> > The only case where it could fail is when passing an incorrect cpuset
> > size wrt to the kernel.
> >
> > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> > Signed-off-by: David Marchand <david.marchand@redhat.com
> <mailto:david.marchand@redhat.com>>
> > ---
> > lib/librte_eal/common/eal_common_options.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> > index 6c96f45..1f45f82 100644
> > --- a/lib/librte_eal/common/eal_common_options.c
> > +++ b/lib/librte_eal/common/eal_common_options.c
> > @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
> > unsigned int lcore_id;
> > unsigned int removed = 0;
> > rte_cpuset_t affinity_set;
> > - pthread_t tid = pthread_self();
> >
> > - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
> > - &affinity_set) < 0)
> > + if (pthread_getaffinity_np(pthread_self(),
> sizeof(rte_cpuset_t),
> > + &affinity_set))
> > CPU_ZERO(&affinity_set);
> >
> > for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> >
> CC: stable?
>
>
> Not really sure about CCing stable for this.
>
> I did not get errors with pthread_getaffinity_np so far.
> Afaiu, it would need the kernel and libc to have different cpuset sizes.
> I did not investigate in which situations it could happen.
>
You're incorrectly handling error condition - that's a bug regardless of
how likely it is to occur :)
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity
2019-02-19 11:40 ` Burakov, Anatoly
@ 2019-02-19 11:55 ` David Marchand
0 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2019-02-19 11:55 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: dev
On Tue, Feb 19, 2019 at 12:40 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:
> On 14-Feb-19 5:41 PM, David Marchand wrote:
> > On Thu, Feb 14, 2019 at 5:44 PM Burakov, Anatoly
> > <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
> > CC: stable?
> >
> > Not really sure about CCing stable for this.
> >
> > I did not get errors with pthread_getaffinity_np so far.
> > Afaiu, it would need the kernel and libc to have different cpuset sizes.
> > I did not investigate in which situations it could happen.
> >
>
> You're incorrectly handling error condition - that's a bug regardless of
> how likely it is to occur :)
>
Ok will resend with Cc:
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] eal: fix check when retrieving current cpu affinity
2019-02-14 13:27 [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity David Marchand
2019-02-14 16:44 ` Burakov, Anatoly
@ 2019-02-19 20:38 ` David Marchand
2019-02-20 16:02 ` Burakov, Anatoly
2019-02-21 18:58 ` [dpdk-dev] " Rami Rosen
1 sibling, 2 replies; 9+ messages in thread
From: David Marchand @ 2019-02-19 20:38 UTC (permalink / raw)
To: dev; +Cc: anatoly.burakov, stable
pthread_getaffinity_np returns a >0 value when failing.
This is mainly for the sake of correctness.
The only case where it could fail is when passing an incorrect cpuset
size wrt to the kernel.
Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changelog since v1:
- added missing Cc: stable@dpdk.org
---
lib/librte_eal/common/eal_common_options.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 6c96f45..1f45f82 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
unsigned int lcore_id;
unsigned int removed = 0;
rte_cpuset_t affinity_set;
- pthread_t tid = pthread_self();
- if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
- &affinity_set) < 0)
+ if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
+ &affinity_set))
CPU_ZERO(&affinity_set);
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal: fix check when retrieving current cpu affinity
2019-02-19 20:38 ` [dpdk-dev] [PATCH v2] " David Marchand
@ 2019-02-20 16:02 ` Burakov, Anatoly
2019-03-07 15:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-02-21 18:58 ` [dpdk-dev] " Rami Rosen
1 sibling, 1 reply; 9+ messages in thread
From: Burakov, Anatoly @ 2019-02-20 16:02 UTC (permalink / raw)
To: David Marchand, dev; +Cc: stable
On 19-Feb-19 8:38 PM, David Marchand wrote:
> pthread_getaffinity_np returns a >0 value when failing.
>
> This is mainly for the sake of correctness.
> The only case where it could fail is when passing an incorrect cpuset
> size wrt to the kernel.
>
> Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> Cc: stable@dpdk.org
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: fix check when retrieving current cpu affinity
2019-02-20 16:02 ` Burakov, Anatoly
@ 2019-03-07 15:36 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2019-03-07 15:36 UTC (permalink / raw)
To: David Marchand; +Cc: stable, Burakov, Anatoly, dev
20/02/2019 17:02, Burakov, Anatoly:
> On 19-Feb-19 8:38 PM, David Marchand wrote:
> > pthread_getaffinity_np returns a >0 value when failing.
> >
> > This is mainly for the sake of correctness.
> > The only case where it could fail is when passing an incorrect cpuset
> > size wrt to the kernel.
> >
> > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> > Cc: stable@dpdk.org
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eal: fix check when retrieving current cpu affinity
2019-02-19 20:38 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-02-20 16:02 ` Burakov, Anatoly
@ 2019-02-21 18:58 ` Rami Rosen
1 sibling, 0 replies; 9+ messages in thread
From: Rami Rosen @ 2019-02-21 18:58 UTC (permalink / raw)
To: David Marchand; +Cc: dev, anatoly.burakov, stable
Reviewed-by: Rami Rosen <ramirose@gmail.com>
בתאריך יום ג׳, 19 בפבר׳ 2019, 22:38, מאת David Marchand <
david.marchand@redhat.com>:
> pthread_getaffinity_np returns a >0 value when failing.
>
> This is mainly for the sake of correctness.
> The only case where it could fail is when passing an incorrect cpuset
> size wrt to the kernel.
>
> Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> Cc: stable@dpdk.org
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v1:
> - added missing Cc: stable@dpdk.org
>
> ---
> lib/librte_eal/common/eal_common_options.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> index 6c96f45..1f45f82 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
> unsigned int lcore_id;
> unsigned int removed = 0;
> rte_cpuset_t affinity_set;
> - pthread_t tid = pthread_self();
>
> - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
> - &affinity_set) < 0)
> + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
> + &affinity_set))
> CPU_ZERO(&affinity_set);
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-03-07 15:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 13:27 [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity David Marchand
2019-02-14 16:44 ` Burakov, Anatoly
2019-02-14 17:41 ` David Marchand
2019-02-19 11:40 ` Burakov, Anatoly
2019-02-19 11:55 ` David Marchand
2019-02-19 20:38 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-02-20 16:02 ` Burakov, Anatoly
2019-03-07 15:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-02-21 18:58 ` [dpdk-dev] " Rami Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).