From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id B8C143772 for ; Wed, 22 Jul 2015 10:28:10 +0200 (CEST) Received: by wicmv11 with SMTP id mv11so70852244wic.0 for ; Wed, 22 Jul 2015 01:28:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=56TpeUVx2f3RzDcmFWsrrwSgCqlvKiOyEaaReBAHWnk=; b=gxduvgPKjOZIcQG44PytWhQZbXL1d7Plizqq1Bz3NAxFEuO9CtyEzNrQVIJumxvpDV 26o2Vc71rplmzXXUkRnoASnoeRVvRYW2YROcguwtxlSetd8rwIdhlsfviRlQfhABgWpc RYF/FMwVPVE46h5U5qZMTX7S0lk9dCAQbEX7Yr3SVEnLaee8K28+jDz+Xu+elo7e3gif K/IdiQV1qoXSfhkS7CU7bvGfucZ4cmt0ijlxWkvaNm+msgqfQZ5gEnvPBr3vhZWblgyQ LqzsjuD24s343P8UzxCPMXg100G5FagRjOklycPVUY278E6oQTp3GfigpKNi2+lNko9u YoQQ== X-Gm-Message-State: ALoCoQlMqxLbzvWgze1Uo+cVgdh4LpGh+i6HFeNgguZ/iuAmYdznAIxeDtjQF5bRtZ6SY1Dbr6az X-Received: by 10.180.77.68 with SMTP id q4mr4005645wiw.22.1437553690546; Wed, 22 Jul 2015 01:28:10 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id m10sm2137075wib.17.2015.07.22.01.28.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jul 2015 01:28:09 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Date: Wed, 22 Jul 2015 10:26:58 +0200 Message-ID: <4582360.pG3T7yarLt@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1437474797-19778-1-git-send-email-sergio.gonzalez.monroy@intel.com> References: <1437473890-17279-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1437474797-19778-1-git-send-email-sergio.gonzalez.monroy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] malloc: fix combined lib build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 08:28:11 -0000 > Malloc was moved to the EAL and dummy malloc library was left > to not break apps that had a librte_malloc.so dependency. > Note that the dummy library will be removed in the next release. > > When building a combined library, all objects are copied to the same > directory before creating the library itself. > > There are a few issues: > - CONFIG_RTE_LIBRTE_MALLOC is not a valid option anymore resulting > in wrong syntax and a compilation failure. Fix it by replacing it > with CONFIG_RTE_LIBRTE_EAL. > - As we kept a dummy library, there are now two objects with the > same name. This means that the proper rte_malloc.o object in eal gets > overwritten by an empty rte_malloc.o object from the dummy malloc lib. > Fix it by changing the name of rte_malloc.o object in the dummy > library. > - Update the copyright year. > > Fixes: 2f9d47013e4dbb738 ("mem: move librte_malloc to eal/common") > > Reported-by: Alin Rauta > Signed-off-by: Sergio Gonzalez Monroy Applied, thanks