From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B76891B150 for ; Wed, 5 Dec 2018 08:28:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 32AEB21AA2; Wed, 5 Dec 2018 02:28:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Dec 2018 02:28:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=g+kJVX5KR0abg2jMdS7fT2/dEy1KW22Hkci2/kGQMN4=; b=b33+YlkPCb8A szCigi8J415cnTRWa/9Ts0YubfzkJYOwIan8Ig1xwlnlUHN5a4yL2Ok/vDoq01VI MyjPDyGb2Y1ygvWnMhzHeg77u20dJ7CkqLyzp+sua2abE7cRAUDwjSHWV+U5KzIS r7lhjA8kh20KUNfgAmY3bNtUiISsMvY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=g+kJVX5KR0abg2jMdS7fT2/dEy1KW22Hkci2/kGQM N4=; b=djX3crfnSuYfHdZ0Q8LdT+JplvWy0BEX+d0aDJgVt1IssDjVvroCDO5dd ONdpLE21q1/fC8DLPOyE8gjkbhcfl9b59exKWMGI3J1R8AWjvhc5lVS9e17HD5yi L9XTDCOhWsEUi+/TznBliagtVK7Jz3omMhmU3ft3KiP2r50sOEtZghJD02dA0vvq QY7QIZNRgXTOE2lo1BZXEEEitRh1RSDxrLs8QU03Ts+Olr99fULE5nKu61uwMvQx uTXjooDJiZLtQk9RuLewVXp3zITITcVFJah8jgCjFlwxEMzpfONc0W++H82pN8O0 NU/sF+ApOZVoUcPH3kOoFteFxr9CQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (unknown [50.226.235.34]) by mail.messagingengine.com (Postfix) with ESMTPA id 3887E103B3; Wed, 5 Dec 2018 02:28:36 -0500 (EST) From: Thomas Monjalon To: "Lu, Wenzhuo" Cc: dev@dpdk.org Date: Wed, 05 Dec 2018 08:28:34 +0100 Message-ID: <4582980.XP1efssEEA@xps> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093FE11281@shsmsx102.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <2482097.kNToWcbbbU@xps> <6A0DE07E22DDAD4C9103DF62FEBC09093FE11281@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 07:28:38 -0000 05/12/2018 07:39, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 23/11/2018 07:56, Wenzhuo Lu: > > > net/ice: add base code > > > > This first patch is really too big. > > Please could you try to split it logically? > > This is base code which is not developed by us. We're not so familiar with it. It's the first time to release the code, I know it's too big, to us too. But anyway we'll maintain it. > To save the effort, we always don't split the base code when releasing it at the first time. Is that OK? It's not the best start. How a very new driver can start with so many code and not being fully understood by those who will maintain it? It's really better to start small and grow. It would ease both testing and understanding.