DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Wan Junjie <wanjunjie@bytedance.com>, Chenbo Xia <chenbo.xia@intel.com>
Cc: dev@dpdk.org, Peng He <hepeng.0320@bytedance.com>,
	Zhihong Wang <wangzhihong.wzh@bytedance.com>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled
Date: Wed, 3 Feb 2021 17:49:20 +0100	[thread overview]
Message-ID: <45869c99-fb00-c843-ba66-ddf5e1832bea@redhat.com> (raw)
In-Reply-To: <20210202083845.79726-1-wanjunjie@bytedance.com>

Hi,

On 2/2/21 9:38 AM, Wan Junjie wrote:
> If vhost device's IOMMU feature is disabled, iotlb mempool allocation
> is unnecessary.
> 
> Reported-by: Peng He <hepeng.0320@bytedance.com>
> Signed-off-by: Wan Junjie <wanjunjie@bytedance.com>

Welcome to the community, looking forward for more contributions!

> Reviewed-by: Zhihong Wang <wangzhihong.wzh@bytedance.com>

And welcome back Zhihong! :)

> ---
>  lib/librte_vhost/vhost.c      | 4 ++--
>  lib/librte_vhost/vhost_user.c | 6 +++++-
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 

The patch looks good to me, however this is more an optimization than a
fix. As we are late in the release cycle, I will postpone it to next
release.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2021-02-03 16:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 16:39 [dpdk-dev] [PATCH] " Wan Junjie
2021-02-01  7:41 ` Xia, Chenbo
2021-02-02  8:38 ` [dpdk-dev] [PATCH v2] " Wan Junjie
2021-02-03  2:26   ` Xia, Chenbo
2021-02-03 16:49   ` Maxime Coquelin [this message]
2021-02-02  8:14 Wan Junjie
2021-04-07  7:10 ` Xia, Chenbo
2021-05-13  8:39   ` David Marchand
2021-05-13 10:24     ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45869c99-fb00-c843-ba66-ddf5e1832bea@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=hepeng.0320@bytedance.com \
    --cc=wangzhihong.wzh@bytedance.com \
    --cc=wanjunjie@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).