From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6409AA0A0E; Wed, 3 Feb 2021 17:49:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BD79240530; Wed, 3 Feb 2021 17:49:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 82AE3240506 for ; Wed, 3 Feb 2021 17:49:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612370968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cHwGWTWiJn/PJO8Hqu30mlYrzPY3YN6ZOxpWXdYBR2w=; b=hNC7G3W+B0/dAhBhOdUHoTQP68S16yM6TT4nm2CWdKXSWpzjACqpCjlQE5OZ3q2WORt2y3 9RFgubMjcnfRFOApdL6O+KUqG59ODGoTEVcHYi3Wxv27mgD10PxJnGkN5DZE5yCM9Ihhr/ evgYGdDBbtU+PvfWnqscOqhdUVsVBas= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-560-8ip2LuogP0OoKPJEpR2vTQ-1; Wed, 03 Feb 2021 11:49:25 -0500 X-MC-Unique: 8ip2LuogP0OoKPJEpR2vTQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E712A192CC42; Wed, 3 Feb 2021 16:49:22 +0000 (UTC) Received: from [10.36.110.4] (unknown [10.36.110.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C550477BE9; Wed, 3 Feb 2021 16:49:21 +0000 (UTC) To: Wan Junjie , Chenbo Xia Cc: dev@dpdk.org, Peng He , Zhihong Wang References: <20210129163909.35970-1-wanjunjie@bytedance.com> <20210202083845.79726-1-wanjunjie@bytedance.com> From: Maxime Coquelin Message-ID: <45869c99-fb00-c843-ba66-ddf5e1832bea@redhat.com> Date: Wed, 3 Feb 2021 17:49:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210202083845.79726-1-wanjunjie@bytedance.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 2/2/21 9:38 AM, Wan Junjie wrote: > If vhost device's IOMMU feature is disabled, iotlb mempool allocation > is unnecessary. > > Reported-by: Peng He > Signed-off-by: Wan Junjie Welcome to the community, looking forward for more contributions! > Reviewed-by: Zhihong Wang And welcome back Zhihong! :) > --- > lib/librte_vhost/vhost.c | 4 ++-- > lib/librte_vhost/vhost_user.c | 6 +++++- > 2 files changed, 7 insertions(+), 3 deletions(-) > The patch looks good to me, however this is more an optimization than a fix. As we are late in the release cycle, I will postpone it to next release. Reviewed-by: Maxime Coquelin Thanks, Maxime