From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1606E1B2C9; Tue, 13 Feb 2018 17:15:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C08BF20A4B; Tue, 13 Feb 2018 11:15:52 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 13 Feb 2018 11:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=YqR2LhmnlcjPJmyGhSTzuSD3GZ QZbs6Zr/0lPNNrPOY=; b=oVvZv+5Qa9yIoAb+TBKmwgC+DAZm10TEky8kyX13bR lTvbYXMTZedO6XOwMTOb6BJzfyqS+0TRh4kZMhpSkWOrgLAwGMRLME5yjioyCaMU yloBlo5Y6JStv/P4a9sy1QUH7XuCtdyg7HD0V7M/xE5VZVGlGm6YneHxPUKWTQko Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YqR2Lh mnlcjPJmyGhSTzuSD3GZQZbs6Zr/0lPNNrPOY=; b=TIlBz54w+izrkM40mAcLzB jbIKISuQbBGKcVB767D7masMggERMvONaeSlY0ioZ8G5P4NuUBKIrFDsv9aaDsb0 aK7uKcEe0GtqVs0jVAtLX4qDemkIiq9/YL1NEC76n9my5gqRvLAzXJ07ZIrCCzj0 aUIh8MrGXXlreJ21RPxr3WUHQBA3WfHd4RpaLcUxYV2bISFDSiwM26QyVzc3WduP NnBb+9Avs/BEO/pdW73vZSHyU85sIKE7gSZBr+ShCEDL/5i1iZC2M0ibraHOu4Wy F5Qf97BEIW89qGymCmmQKPsrTnOroaW9trSWNHVXbJzay5AJDxRZMv6wNBLhyGUg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 70AAA24466; Tue, 13 Feb 2018 11:15:52 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: stable@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet , dev@dpdk.org Date: Tue, 13 Feb 2018 17:15:42 +0100 Message-ID: <4588096.I6AEN4BJAm@xps> In-Reply-To: <20180212184211.nmjzwqmbf3i6z7eq@bidouze.vm.6wind.com> References: <1518370054-12578-1-git-send-email-matan@mellanox.com> <20180212184211.nmjzwqmbf3i6z7eq@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix reconfiguration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 16:15:53 -0000 12/02/2018 19:42, Ga=EBtan Rivet: > Hi Matan, >=20 > On Sun, Feb 11, 2018 at 05:27:34PM +0000, Matan Azrad wrote: > > Fail-safe PMD manages the states of its sub-devices gradually: > > DEV_UNDEFINED, DEV_PARSED, DEV_PROBED, DEV_ACTIVE, DEV_STARTED. > >=20 > > When the sub-device arguments successfully was parsed, the state is > > raised from DEV_UNDEFINED to DEV_PARSED. > > When the sub-device successfully was probed, the state is raised from > > DEV_PARSED to DEV_PROBED. > > When the sub-device successfully was configured by > > rte_eth_dev_configure(), the state is raised from DEV_PROBED to > > DEV_ACTIVE. > > When the sub-device successfully was started by rte_eth_dev_start(), the > > state is raised from DEV_ACTIVE to DEV_STARTED. > >=20 > > When the sub-device successfully was stopped by rte_eth_dev_stop(), the > > state is degraded from DEV_STARTED to DEV_ACTIVE. > > When the sub-device successfully was closed by rte_eth_dev_close(), the > > state is degraded from DEV_ACTIVE to DEV_PROBED. > > When the sub-device successfully was removed by > > rte_eal_hotplug_remove(), the state is degraded from DEV_PROBED to > > DEV_UNDEFINED. > >=20 > > Fail-safe dev_configure() operation calls to its sub-devices > > dev_configure() operation, but only for sub-devices which are in > > DEV_PROBED state, means that sub-devices which are in DEV_ACTIVE state > > because the application triggered dev_stop() operation cannot be > > reconfigured again by dev_configure() operation which is really > > problematic when application wants to reconfigure its ports. > > Actually, the application may get success report when some of the > > sub-devices are not in the wanted configuration. > >=20 > > The current behavior of fail-safe dev_configure() is correct only for > > the first time dev_configure() is triggered by the application or for > > sub-device synchronization in plug-in event, but it ignores the option > > for reconfiguration from application side. > >=20 > > Allow calling to sub-devices dev_configure() operations also in > > DEV_ACTIVE state when the call was triggered by the application. > >=20 > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Matan Azrad >=20 > The commit log is too verbose, but otherwise the issue is real and the > fix correct. >=20 > Acked-by: Gaetan Rivet Applied, thanks