From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 380112BAF for ; Sat, 1 Jul 2017 17:58:11 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2017 08:58:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,293,1496127600"; d="scan'208";a="103497612" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.233]) ([10.252.15.233]) by orsmga004.jf.intel.com with ESMTP; 01 Jul 2017 08:58:09 -0700 To: Yongseok Koh Cc: Adrien Mazarguil , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= , "dev@dpdk.org" References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com> <7672F9BE-1782-4F1A-B4B7-F28C82C34FD5@mellanox.com> From: Ferruh Yigit Message-ID: <45a80418-acd5-42d7-4319-365bed329fa9@intel.com> Date: Sat, 1 Jul 2017 16:58:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <7672F9BE-1782-4F1A-B4B7-F28C82C34FD5@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx: update C compliance standard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2017 15:58:12 -0000 On 6/30/2017 7:25 PM, Yongseok Koh wrote: > > Hi, > > > > Thanks, > Yongseok > >> On Jun 30, 2017, at 11:14 AM, Yongseok Koh wrote: >> >> >>> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit wrote: >>> >>> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote: >>>> This commit addresses a compilation issue against Glibc >= 2.25, which >>>> implements assert() through a nonstandard ({ }) construct. Such constructs >>>> can normally not be used without __extension__ keyword when -pedantic is >>>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode. >>>> >>>> While assert.h checks for the compiler ability to support GNU extensions, >>>> Clang, unlike GCC, does not allow the above syntax when combining >>>> -std=gnu99 with -pedantic. >>>> >>>> Work around missing keyword by moving these PMDs to a stricter compliance >>>> standard without GNU extensions but properly checked by Glibc. Doing so is >>>> supported on the DPDK side since includes have been cleaned up. >>>> >>>> Signed-off-by: Adrien Mazarguil >>> >>> Applied to dpdk-next-net/master, thanks. >> This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet! > Specifically, the following errors happen. It might be better to later make the > change for mlx5 with further cleanup. I don't see build errors. Patch is requested to fix mlx DEBUG builds [1]. Can you please give more details how to reproduce build error? [1] http://dpdk.org/ml/archives/dev/2017-June/067866.html