From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7A34A0C43; Thu, 9 Sep 2021 19:02:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 763F640041; Thu, 9 Sep 2021 19:02:46 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 04FC84003E for ; Thu, 9 Sep 2021 19:02:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="220878684" X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="220878684" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 10:02:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="539730667" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 09 Sep 2021 10:02:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 10:02:40 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 10:02:40 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 10:02:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 9 Sep 2021 10:02:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxqdZGAmT3MDwEdQWcxLwJasygb0XtEbFkAKFaEWl/2exfPMA8MUeWsFDHE5MTRQaenD9aSoWhnYlNoeaT604JSnjlPCS8XxICGcE2PgV1avf8qRdUMVqf7vXxq0G+sAPW6mvMkrSu6WTaR8meVU4kQkvvnSamoG6PhCeGjBjl3ax6tvoC/btC5nViWoXonu3dqkpnAv9yjQKLpFz+Nb1ugiOS1nYdjzBDR0SgLq7r5VKF5fnfgxIVD9rjLNPDaG4j2gbG0Ep3eVCewdnGIoRq3Q7SnKPlzitgdRuDuiaG8bY3ztcxAKsnf00LmSVC/6GXjvMV3GHReiwtN6qAFU9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yQBIDVfnZca4i4knV6k7ztHBb3nWNVeyafkZLrtshXQ=; b=ABqO3yb8muCFUcMEqREsk7mUBjnVp6297SuhVBGn8Q5g5Uc6/HVleObgTIN7pp9vIKyzoiFwsb7Q7BN6uqifqpzBnP/drCAHXHmkjDLEH38fS3dOKrwGLAghucp4qo5z38WLTmTP+CJciLh9wYNeo2HAayV1thmwGxNXmS80fYOfRIms3Vwxzev3mAXbvvmjuLE3lb254d7y5zL8C10oGhYK/z3fVz9bvjgxji+6XvbJvm+Glg2W2VycplUD81ol7MvTvm3Eq3HxU4F2CQGiekhopqedP9NT5ZBnG1SsmPpuQzm796vDXz7luWG5wpAqN2o2LEDERZHAmYrrm0yONQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yQBIDVfnZca4i4knV6k7ztHBb3nWNVeyafkZLrtshXQ=; b=TPZVvWiG6GgwXAxbMF5SbupguVglXKf2g6i4hXDjmQ3kVHIds06DthOqQb1SMA3LXjhU82LwDpAYDz6XJCOvzr66rzFAZ2gRWWtiLLFR/Znq7DnPURHLxDsSKlgrGy7D69t46C8NwSaYnL3DTknkY0t4AlQIFhAAwmnBiKbFz0I= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep 2021 17:02:38 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Thu, 9 Sep 2021 17:02:38 +0000 To: Thomas Monjalon , CC: Andrew Rybchenko References: <20210830104232.598703-1-thomas@monjalon.net> From: Ferruh Yigit X-User: ferruhy Message-ID: <45c1e73c-bb60-c5a4-c4f0-7971b4066c03@intel.com> Date: Thu, 9 Sep 2021 18:02:33 +0100 In-Reply-To: <20210830104232.598703-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR03CA0084.eurprd03.prod.outlook.com (2603:10a6:10:72::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR03CA0084.eurprd03.prod.outlook.com (2603:10a6:10:72::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 17:02:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3cb52305-ec90-496a-eb09-08d973b3a0d1 X-MS-TrafficTypeDiagnostic: PH0PR11MB4824: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:741; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fs4q/BWuFYwQWjR4EHXILyCzTjx7FvoFM/rX8YN4DJlQI7118hNGKJNDeCff6s0GADrjQiHkeMdvz0IDl5OVb5PAoFomsCCXuSDos/f1qlzxloviZzdMOBL7gYcU8kV8AS2UzC5wBKsFDwW+EHl+gn1JaGGUhNM8lPtzr66MOEOO6TsMypzrAmlLyK6IXQCe1DRh67Yi8C096Wg1tlshT5yaP+kqcCg3W5BJypNXkCxhSR3BBWmuaSnGoqc+hRlcaBJ+HGX20hYANu3AhdczPUkztv8sBA8dU09Ccr84twa00wvOBHXBopEa3IzknQ268oHWLXredNwJD7fZibzDaESMu3uUAa8S9ghqHuvLiUoxEMAuj6K10dYNvZ1K5r1gFswBRb+qvsMJgXjy2RTBdKw38HWPFBZGnlOh6zSrtmta9zuhexfkJlLyDntV+GrofZzzR+5OhZ5S/raUX0/yLnyc6MIjblNu2DzYtbMlNYickpLbp9maHvI4FVttsFFjUYp0sN6tl29EGAHBXiIJ87bikpkAXDoD4qS3vj+lDSD9Fs0n1MWFiGNWXw6OIrRJu/GPDqSnS1vQ5k6nhPIJ8Nkfr1FfKBoX1y4RMygp1sUiXbxh6YFhnDPnXoubH0mwUsxN2+OC0hLfvmqrW2Gp+Hy9tn/elPgqpFzTFbYe0J5kyo6eBQaPx0uVJ/KTdh95XV+tnbb3en9NWrcB2u1P5w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(8676002)(478600001)(86362001)(38100700002)(31696002)(2616005)(5660300002)(4326008)(316002)(44832011)(16576012)(36756003)(8936002)(6486002)(6666004)(66556008)(26005)(2906002)(31686004)(66476007)(66946007)(186003)(956004)(53546011)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RllnNlBTRTdCVHZDWmdZRFhkZ0lqWmcvWUJYNFJYc2RtUXNGQlVkU2J0bWdp?= =?utf-8?B?blVwWDkzNjF0WjBFcmlyQjA5SWNQWEs2QWhNU3NFMUErTExuaDZoNU5YWWVI?= =?utf-8?B?SEVaeHJLZitWbkJ0eVdISFlBQlhkc0kxQTJ6aFhiR3RjQlF4QThLMHZ1RnRm?= =?utf-8?B?dnlJUHE4eFJ1YnpnODlQdEtydkY1REhSamQvVTNMSHh5QS9ndnppSVNVRnpQ?= =?utf-8?B?UmJISVlmbFpFeE04anNBT3hOWkx3ckY1NVRtOXhiaEFBcVlBaUJnZEJMTDdH?= =?utf-8?B?Sk0wUEJJQzVvaWpSSlJFMnhmbkdZWWZqRFBaZ2IzdFdXYzJGdDNsaFVVaWdi?= =?utf-8?B?SWpxYXFrOXZ2aEExdDA3Z0VOdmRoNVdsMmIwbjFGVjl1ZWNrWkkvNUtWTVQz?= =?utf-8?B?Y21BelFnTDl6VW9mbFliSEpjb3RTdjFENVlXcXFEM0JBb3VqWmRxK3JHZDAr?= =?utf-8?B?bUJHVDhsaDVXNXQvdTNmQ3g2dmRKUnBkTmc1b00zc0xSUURMd2x1T2syL3dF?= =?utf-8?B?cjB2M3hVQTJyem83S2ZCNzhXemhmN25majVJcU1aS0ZHN0ttVWs1SnpKTGpj?= =?utf-8?B?YjFnRXBvNEVoZnRSSVRvT3VYMktwU205cEtEbVE3VTVPQ1hmamthSkdBTXJ5?= =?utf-8?B?NjlqMUMvL0g2bW5HbDNlRlNSYmx0ME5hZ0dSYXZlaUhhaTJ2RkRiT3R3TlR6?= =?utf-8?B?bmVFY201UnVsTGZZS3pJOW4wbGdmUkdtVE0zcXcySHZNQWc3ZmpWZWkyUDcz?= =?utf-8?B?UDRVU2x0VzBGY2ZMUWZBbFA5RkcwOFB6ZG1jcFVRY2cwTGplenJydXk1Ymxr?= =?utf-8?B?V2pEbVYrRm5EczZJVTg3RUh0WEhFRVp1eUlpTGlndXRGMmp0NzhwWXZQY29R?= =?utf-8?B?TDBBbllEaHJHRTZqYktJVnI2R0dUcEtFdUIwbTdVcTI1aWJNZWpiRW45N0JT?= =?utf-8?B?NktWMVFRYWxmcEVJK0I1b3pqR25NSmJuRXdGN1FKSE1lOHpxa091dVNJYktW?= =?utf-8?B?OW5HV0RadUtuUnN4aGxKTTA1TWpUWWR6ZkgxUE5oU1FQQTZlK2xLYmptZXlj?= =?utf-8?B?V0lMNnp0emh0OUE1YmZNNnNJVm9PNFg0U0R4V2VXY3oyUGJFZUFidjhLTlhu?= =?utf-8?B?NXpOL2J6U3V5eVBPeTBmemFkeHIraENEeVQ1SVhTSy9XbjBER2xMTlBFdENv?= =?utf-8?B?d2R2ekFTWXdDQXBITmh3TlFMNmVQaFlqbjR6MjVRVjExRnlYbTJCa0tITHR5?= =?utf-8?B?VHNFRkc5R2haTUtWc0JJemN1S01ibHBzSndPcWVPSEZxWGRjQWlxTEJIRGFX?= =?utf-8?B?SkZzKysxaDVyc1M3MHRNS3pMMGJQbUkzUmsrREoxb2NNVG84aFJpd0ZCTU1S?= =?utf-8?B?U0ZKbFRDNWFIVm1pdUgxRW5aR3R0Q0dmZkQzL2Qwb3JWWEJZaTdBUGkyTW9X?= =?utf-8?B?TXJCTzNaWXlzZ2JkMlRSSXh1NW9kK3hoQ2xLdEMvdTc3UHl2RlBCWFRtUzNz?= =?utf-8?B?RndTRGlDMHFyWGJMNEVPcmR0S0pVdWNTUXdqUTlaWnlleTZEUFZxbDJLWjlM?= =?utf-8?B?aXBqUS9lUFhRR3ljRE1EMjUwTmNEbXYxVGpOeVZUemdGdk9HZG1CbFRvWVFl?= =?utf-8?B?NGxxS0FTUHJtOUw5aGxjR1ZEd0x3Z2NiRXF6dHhNbkZaOGQxUGVEc2dXZ1Rv?= =?utf-8?B?b0lsSDJYUFpEREVXUzJrZFVlcjdLNnlYcHhlSEQ3SVNNVjBENUllcjJxVkc1?= =?utf-8?Q?SesOvDSYm9iIIrIlNZn6ZX1une+Ly8gdwW5pvOY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3cb52305-ec90-496a-eb09-08d973b3a0d1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 17:02:38.5312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qi5hJHI86zNRDD/KSC3Rjy3NbEj857CMquooZTTEtoT58Wk6aPh8h+s3t7+32Gaypyk2hAhuDwOmbKz0cZSxcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4824 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/30/2021 11:42 AM, Thomas Monjalon wrote: > A lot of flags are parts of a group but are documented alone. > The Doxygen syntax @{ and @} for grouping is used > to make flags appear together and have a common description. > > Some Rx/Tx offload flags and RSS definitions are not grouped > because they need to be all properly documented first. > > Signed-off-by: Thomas Monjalon > --- > lib/ethdev/rte_ethdev.h | 71 ++++++++++++++++++++++++++++------------- > 1 file changed, 48 insertions(+), 23 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index d2b27c351f..0924c9fc68 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -276,7 +276,7 @@ struct rte_eth_stats { > /**< Total number of queue packets received that are dropped. */ > }; > > -/** > +/**@{@name Link speed capabilities > * Device supported speeds bitmap flags > */ > #define ETH_LINK_SPEED_AUTONEG (0 << 0) /**< Autonegotiate (all speeds) */ > @@ -296,8 +296,9 @@ struct rte_eth_stats { > #define ETH_LINK_SPEED_56G (1 << 13) /**< 56 Gbps */ > #define ETH_LINK_SPEED_100G (1 << 14) /**< 100 Gbps */ > #define ETH_LINK_SPEED_200G (1 << 15) /**< 200 Gbps */ > +/**@}*/ +1 to use Doxygen grouping, and changes looks good to me.