DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH 1/1] examples/vm_power_manager: fix resource leak
@ 2020-07-29  8:37 Rory Sexton
  2020-09-18  8:13 ` David Hunt
  0 siblings, 1 reply; 2+ messages in thread
From: Rory Sexton @ 2020-07-29  8:37 UTC (permalink / raw)
  To: dev, david.hunt; +Cc: marko.kovacevic

Fix memory leak where variable oob_enable can go out of scope leaking
the storage it points to.

Coverity issue: 337674
Fixes: 95f648ff9ee ("examples/vm_power: make branch ratio threshold per core")

Signed-off-by: Rory Sexton <rory.sexton@intel.com>
---
 examples/vm_power_manager/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
index 77797b1e1..0242cca1a 100644
--- a/examples/vm_power_manager/main.c
+++ b/examples/vm_power_manager/main.c
@@ -209,6 +209,7 @@ parse_args(int argc, char **argv)
 			}
 			if (branch_ratio <= 0.0 || branch_ratio > 100.0) {
 				printf("invalid branch ratio specified\n");
+				free(oob_enable);
 				return -1;
 			}
 			for (i = 0; i < ci->core_count; i++) {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] examples/vm_power_manager: fix resource leak
  2020-07-29  8:37 [dpdk-dev] [PATCH 1/1] examples/vm_power_manager: fix resource leak Rory Sexton
@ 2020-09-18  8:13 ` David Hunt
  0 siblings, 0 replies; 2+ messages in thread
From: David Hunt @ 2020-09-18  8:13 UTC (permalink / raw)
  To: Rory Sexton, dev; +Cc: marko.kovacevic

Hi Rory,

On 29/7/2020 9:37 AM, Rory Sexton wrote:
> Fix memory leak where variable oob_enable can go out of scope leaking
> the storage it points to.
>
> Coverity issue: 337674
> Fixes: 95f648ff9ee ("examples/vm_power: make branch ratio threshold per core")
>
> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> ---
>   examples/vm_power_manager/main.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
> index 77797b1e1..0242cca1a 100644
> --- a/examples/vm_power_manager/main.c
> +++ b/examples/vm_power_manager/main.c
> @@ -209,6 +209,7 @@ parse_args(int argc, char **argv)
>   			}
>   			if (branch_ratio <= 0.0 || branch_ratio > 100.0) {
>   				printf("invalid branch ratio specified\n");
> +				free(oob_enable);
>   				return -1;
>   			}
>   			for (i = 0; i < ci->core_count; i++) {


Acked-by: David Hunt <david.hunt@intel.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29  8:37 [dpdk-dev] [PATCH 1/1] examples/vm_power_manager: fix resource leak Rory Sexton
2020-09-18  8:13 ` David Hunt

DPDK patches and discussions

Archives are clonable:
	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox