From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69A844416A; Thu, 6 Jun 2024 16:37:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 544BC40E96; Thu, 6 Jun 2024 16:37:26 +0200 (CEST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mails.dpdk.org (Postfix) with ESMTP id AD246402E7 for ; Thu, 6 Jun 2024 16:37:23 +0200 (CEST) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-57a20c600a7so1073575a12.3 for ; Thu, 06 Jun 2024 07:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1717684643; x=1718289443; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NCguB6FhM8b9S8VqJjKfJYeGRM6v+uvwV41MLKONMCw=; b=CGQes5ebMTuvFrjbsrSqX/1XPpqY34iyzAslHcODYI11K+8kj23/Yw4BI+pvexo7WV V4TCa+Xt4p3U2yVe+JWIa7KKe/XIlmarkNBDPfsazDyNjUae+73a1EauZI5WAmj7pIhD U9wjMnhHyUSjJHGygjYZlGGWriP22oPgw4SOdtDiNYoxJLVXlgATAevpH9nS8xKWDR4e beMRW9P0T32ITEJrPGAO4c3cIkp8JnHW/+aPIb6b8I0En6xdutSrAgRhPVEO9Jfe/ACS VBqNZlG2fPZt3BAOiBMHtwzG2eEpCYBARSJEHnNKYhqylCOgQJXF7xzy5pfLgijNkdFa a7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717684643; x=1718289443; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NCguB6FhM8b9S8VqJjKfJYeGRM6v+uvwV41MLKONMCw=; b=dSWGaCdzuJHHvAXENQI4z4gW9axIAyI/mB0f/AoyXtRGWhZ9Pl/BBS0sbe4Sg6lWzk 2DbZm0k6QkMRO9llvd0QjOyOWeacJLe3DISsrbLLdHzVVXssqkTqB39CxekntRgfTMbv NqtPhqq56xcWsHMINlvetSqZMh0XCV6+xFGR8Cp6ZWQL8K7rg/5jJl34ehz6wRlcpfI0 3cJCfei3FfSHa5PlAT7U6dwlqCSRNrrt8rHaHkslZVLfwGq5M+n/TkO30fTCg5E8kxAU o3xQ8eEjTtgrpV+sAlKdshixJ5BWRegL7ONrTKDW99nmAEiGoPDXetIbCYFT+PyvdbIO S85A== X-Forwarded-Encrypted: i=1; AJvYcCVvkeOwwHUEruWbZWTmP5AX2thE26NHsDShznelcqAh9KwB541PXxZj0MFdrH0MR40nW64ON9/jVxbu3JA= X-Gm-Message-State: AOJu0YytfR6GZX51IQ+KVaWo13IqTJF3Fnhe+Pq+Q8pSOugF3D1Oayyt RmLR67v1k2g2/kNmgnt4e9zHBW7v1bINc0qXyiatj/qB4ssIM8CRJCq6RktcW/D1hlonFr55S+N CEf4= X-Google-Smtp-Source: AGHT+IGJEltXQcXJqVjxo7aNbhDQhutUAZK44ZfOFyv+6Ir20svFzwCiLsa/lkVsNlZoQYJQZ8aVcA== X-Received: by 2002:a17:907:7390:b0:a68:4804:1eab with SMTP id a640c23a62f3a-a699fdfe6demr330967566b.69.1717684643360; Thu, 06 Jun 2024 07:37:23 -0700 (PDT) Received: from [192.168.1.113] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c80708edcsm106117766b.148.2024.06.06.07.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 07:37:22 -0700 (PDT) Message-ID: <45d2608a-862d-4e36-be8e-30a84ef70f70@pantheon.tech> Date: Thu, 6 Jun 2024 16:37:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/8] dts: add testpmd shell params To: Luca Vizzarro , dev@dpdk.org Cc: Jeremy Spewock , Paul Szczepanek References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240530152505.389167-1-luca.vizzarro@arm.com> <20240530152505.389167-6-luca.vizzarro@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240530152505.389167-6-luca.vizzarro@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Apparently I was replying to v2 so fixing that from now on. On 30. 5. 2024 17:25, Luca Vizzarro wrote: > Implement all the testpmd shell parameters into a data structure. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Just one minor correction, otherwise: Reviewed-by: Juraj Linkeš > +@dataclass(slots=True, kw_only=True) > +class TestPmdParams(EalParams): > + """The testpmd shell parameters. > + > + Attributes: > + interactive_mode: Runs testpmd in interactive mode. "Run testpmd" to unify with the rest of the attributes.