From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoob.joseph@caviumnetworks.com>,
Declan Doherty <declan.doherty@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
dev@dpdk.org, Akash Saxena <akash.saxena@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/test-crypto-perf: fix double allocation of memory
Date: Tue, 25 Sep 2018 20:01:34 +0530 [thread overview]
Message-ID: <45ea4083-1f42-d95a-d2e0-5df4db279bb5@nxp.com> (raw)
In-Reply-To: <1536561658-3830-1-git-send-email-anoob.joseph@caviumnetworks.com>
On 9/10/2018 12:10 PM, Anoob Joseph wrote:
> The field, 'cipher_iv.data' is allocated twice when cipher is not null.
> Ideally the allocation should depend only on the field
> 'cperf_options.cipher_iv_sz'. This will make sure this code path gets
> valid for ciphers which doesn't require IV.
>
> Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session")
>
> Signed-off-by: Akash Saxena <akash.saxena@caviumnetworks.com>
> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> ---
> v1:
> * Fixed typo
>
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
next prev parent reply other threads:[~2018-09-25 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 6:14 [dpdk-dev] [PATCH] " Anoob Joseph
2018-09-10 6:40 ` [dpdk-dev] [PATCH v1] " Anoob Joseph
2018-09-25 14:31 ` Akhil Goyal [this message]
2018-09-26 12:26 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ea4083-1f42-d95a-d2e0-5df4db279bb5@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=akash.saxena@caviumnetworks.com \
--cc=anoob.joseph@caviumnetworks.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@caviumnetworks.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).