From: Thomas Monjalon <thomas@monjalon.net>
To: Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for multiport device
Date: Mon, 13 May 2019 16:30:04 +0200 [thread overview]
Message-ID: <4603169.RcIqrC0etK@xps> (raw)
In-Reply-To: <AM0PR0502MB3795E92C864FA90E594B9AE9C30E0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
12/05/2019 19:17, Shahaf Shuler:
> Sunday, May 12, 2019 3:15 PM, Shahaf Shuler:
> > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for
> > multiport device
> >
> > Sunday, May 12, 2019 11:32 AM, Viacheslav Ovsiienko:
> > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler
> > > for multiport device
> > >
> > > IBV_EVENT_DEVICE_FATAL event is generated by the driver once for the
> > > entire multiport Infiniband device, not for each existing ports.
> > > The port index is zero and it causes dropping the device removal
> > > event. We should invoke the removal event processing routine for each
> > > port we have installed handler for.
> > >
> > > Fixes: 028b2a28c3cb ("net/mlx5: update event handler for multiport IB
> > > devices")
> > >
> > > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> >
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> >
> > Thomas, Ferruh,
> > This one is a critical fix for mlx5. w/o it will break the support for failsafe at
> > azure.
> >
> > Can you consider to integrate it?
>
> Applied it also to next-net-mlx, thanks.
Pulled in master
next prev parent reply other threads:[~2019-05-13 14:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 14:36 [dpdk-dev] [PATCH] " Viacheslav Ovsiienko
2019-05-10 14:36 ` Viacheslav Ovsiienko
2019-05-10 21:24 ` Yongseok Koh
2019-05-10 21:24 ` Yongseok Koh
2019-05-12 8:32 ` [dpdk-dev] [PATCH v2] " Viacheslav Ovsiienko
2019-05-12 8:32 ` Viacheslav Ovsiienko
2019-05-12 12:15 ` Shahaf Shuler
2019-05-12 12:15 ` Shahaf Shuler
2019-05-12 17:17 ` Shahaf Shuler
2019-05-12 17:17 ` Shahaf Shuler
2019-05-13 14:30 ` Thomas Monjalon [this message]
2019-05-13 14:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4603169.RcIqrC0etK@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).