* [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration
@ 2019-05-16 7:28 Xiaolong Ye
2019-05-16 7:28 ` Xiaolong Ye
2019-05-16 7:58 ` Olivier Matz
0 siblings, 2 replies; 5+ messages in thread
From: Xiaolong Ye @ 2019-05-16 7:28 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, Xiaolong Ye
As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
size in related data types"), forward declaration for rte_memzone is no
longer needed.
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
lib/librte_ring/rte_ring.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index e265e9479..e5a175cb3 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -61,8 +61,6 @@ enum rte_ring_queue_behavior {
#define RTE_RING_NAMESIZE (RTE_MEMZONE_NAMESIZE - \
sizeof(RTE_RING_MZ_PREFIX) + 1)
-struct rte_memzone; /* forward declaration, so as not to require memzone.h */
-
/* structure to hold a pair of head/tail values and other metadata */
struct rte_ring_headtail {
volatile uint32_t head; /**< Prod/consumer head. */
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration
2019-05-16 7:28 [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration Xiaolong Ye
@ 2019-05-16 7:28 ` Xiaolong Ye
2019-05-16 7:58 ` Olivier Matz
1 sibling, 0 replies; 5+ messages in thread
From: Xiaolong Ye @ 2019-05-16 7:28 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, Xiaolong Ye
As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
size in related data types"), forward declaration for rte_memzone is no
longer needed.
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
lib/librte_ring/rte_ring.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index e265e9479..e5a175cb3 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -61,8 +61,6 @@ enum rte_ring_queue_behavior {
#define RTE_RING_NAMESIZE (RTE_MEMZONE_NAMESIZE - \
sizeof(RTE_RING_MZ_PREFIX) + 1)
-struct rte_memzone; /* forward declaration, so as not to require memzone.h */
-
/* structure to hold a pair of head/tail values and other metadata */
struct rte_ring_headtail {
volatile uint32_t head; /**< Prod/consumer head. */
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration
2019-05-16 7:28 [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration Xiaolong Ye
2019-05-16 7:28 ` Xiaolong Ye
@ 2019-05-16 7:58 ` Olivier Matz
2019-05-16 7:58 ` Olivier Matz
2019-06-04 11:10 ` Thomas Monjalon
1 sibling, 2 replies; 5+ messages in thread
From: Olivier Matz @ 2019-05-16 7:58 UTC (permalink / raw)
To: Xiaolong Ye; +Cc: dev
On Thu, May 16, 2019 at 03:28:56PM +0800, Xiaolong Ye wrote:
> As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
> size in related data types"), forward declaration for rte_memzone is no
> longer needed.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration
2019-05-16 7:58 ` Olivier Matz
@ 2019-05-16 7:58 ` Olivier Matz
2019-06-04 11:10 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Olivier Matz @ 2019-05-16 7:58 UTC (permalink / raw)
To: Xiaolong Ye; +Cc: dev
On Thu, May 16, 2019 at 03:28:56PM +0800, Xiaolong Ye wrote:
> As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
> size in related data types"), forward declaration for rte_memzone is no
> longer needed.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration
2019-05-16 7:58 ` Olivier Matz
2019-05-16 7:58 ` Olivier Matz
@ 2019-06-04 11:10 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-06-04 11:10 UTC (permalink / raw)
To: Xiaolong Ye; +Cc: dev, Olivier Matz
16/05/2019 09:58, Olivier Matz:
> On Thu, May 16, 2019 at 03:28:56PM +0800, Xiaolong Ye wrote:
> > As memzone.h is introduced by commit 38c9817ee1d8 ("mempool: adjust name
> > size in related data types"), forward declaration for rte_memzone is no
> > longer needed.
> >
> > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-04 11:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 7:28 [dpdk-dev] [PATCH] ring: remove unnecessary forward declaration Xiaolong Ye
2019-05-16 7:28 ` Xiaolong Ye
2019-05-16 7:58 ` Olivier Matz
2019-05-16 7:58 ` Olivier Matz
2019-06-04 11:10 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).