From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 9343668C1 for ; Wed, 9 Apr 2014 18:38:21 +0200 (CEST) Received: by mail-wi0-f177.google.com with SMTP id cc10so3561469wib.4 for ; Wed, 09 Apr 2014 09:39:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=AjuTSVA/xPCvC8xIMm0ZU2TXt4bOZzgmLYj2WyCI49A=; b=YA61KiPeFNb+ACVDJzM+xet5jT+99Sl0UOEE5Wn0eDglLgdX5YoBmx9zGn7xB06UVX kg+lXgUwM5NqlhrJqVFN65d4L3G7jZewyVkaAP9zHPhNDefW0wI4DJwdyTX9S+2p8MP7 K/sem3WN1Q8IkcgwVN5QiA51SbNU8IJ8q32Xu1+zHl2lIKTPT8hua313KzNzd0aAvN/4 hHn2Cj0Lm8XiLL6gp1DOudpikE4DOjn98f/nEaQ9lgascwFw2+LoLi8aBn6yJkyyt5HC NgfjG967NDVesQixzybJgljiIZ20SyFpBRBGNkKLH0nNKnvZ+ZxW6mdC8OXwnCqlBtO5 vhpA== X-Gm-Message-State: ALoCoQmjRgpvEWEdoNIXtcwm0ehSmYjfDn2/iIZWpKiyLJWoFai6nE2eWYFm5dgdWhMYuIzhJ2Cr X-Received: by 10.180.37.178 with SMTP id z18mr38369623wij.46.1397061598559; Wed, 09 Apr 2014 09:39:58 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id pm5sm2414453wjc.11.2014.04.09.09.39.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Apr 2014 09:39:57 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" , Didier Pallard Date: Wed, 09 Apr 2014 18:39:56 +0200 Message-ID: <4611478.9TdyNLhD18@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.7-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB9772580EF95738@IRSMSX105.ger.corp.intel.com> References: <530DC788.8020706@6wind.com> <1396963798-13123-2-git-send-email-didier.pallard@6wind.com> <2601191342CEEE43887BDE71AB9772580EF95738@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/2] igb: release software locked semaphores on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2014 16:38:21 -0000 > It may happen that DPDK application gets killed while having acquired locks > on the ethernet hardware, causing these locks to be never released. On next > restart of the application, DPDK skip those ports because it can not > acquire the lock, this may cause some ports (or even complete board if SMBI > is locked) to be inaccessible from DPDK application until reboot of the > hardware. > > This patch release locks that are supposed to be locked due to an improper > exit of the application. > > Signed-off-by: Didier Pallard > Acked-by: Konstantin Ananyev Applied for version 1.6.0r2. So the decision is to try not modify base driver. But the fix should appear in the base driver one day and we must be careful when rebasing on an updated one. In this case, the fix can be done on both side without being harmful. Thanks for fixing this random failure. -- Thomas