From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 270CD69C8 for ; Mon, 30 Nov 2015 17:21:40 +0100 (CET) Received: by wmec201 with SMTP id c201so145761154wme.1 for ; Mon, 30 Nov 2015 08:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Zc6y3xSi71Mmdnnb/7eRmznyQfyzzRa4w65ziyseTCo=; b=bXe5IBfhJb+edJeBWb0mWiidCwyHrDhtljf1BjWV6QBeavBl6luuR41CYVe3GzCfZL /FATBoMQoXxZNq9uFc9Dutt/0w7mw5J0i0n/p9dJwxpB26G0OT+9WelrkjxEAd6gnAIz z31tJ2C51iO8uZD6ABBPbGpaD67GBavyJuRYchYPvD4w2ixe/0tbkqvagWcjlnzerg9R +3jboo7i64DFvoGinKkRCz0Lq2MUsda4PTdpEr3xYDGWctnaWoJxuk7Ctds5LX8b5YGa ITE2qNV6ynTbEvttlNovRpxR0GStglV3r6ZLoxduLJKOA+sZIv6Rkw/PHbfyifOHYF3Z XFqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Zc6y3xSi71Mmdnnb/7eRmznyQfyzzRa4w65ziyseTCo=; b=BQnhxD9dX2T6IkTnE2AaUOT/CQVeiQE5URUZYgE7QE4s5LqmVtktkjE3gV81IxgoyT 8m3SDfllM3WB+2A1stEQzBLQtei2RWNaw9rB6ESTZZIHmHVFtQyN2aKdNxNE6BFQ1X1t T2n5m+v9La3zlmn1zJspsjOMyFSqgm0X8am6L83WL9FsH3XkbXssjDJKLXNMeItHOo9W 3M33abqGjT5gpy5Fsg9Ijy1QzxPsEV9wE4K7dsynO14DxsYhA1f6fL9HN+zoMbHR8oNE pKl0RWnqXT664uvRyhTkFFoGcTZLeGZGlJ5LnCb6v0WGgZ33XIyOnt/Se2fBjuaEzgKY HHjA== X-Gm-Message-State: ALoCoQlWj4oqPoqykZ+NVZUacfMU93AGx5MGDygiUksApUp4i295r2ufOpLp2pBv2ADXicMRX1YK X-Received: by 10.194.240.67 with SMTP id vy3mr73995640wjc.168.1448900499952; Mon, 30 Nov 2015 08:21:39 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id a186sm21945086wmh.4.2015.11.30.08.21.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 Nov 2015 08:21:39 -0800 (PST) From: Thomas Monjalon To: Mario Carrillo Date: Mon, 30 Nov 2015 17:20:31 +0100 Message-ID: <4614982.E3BTLgVdAm@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1447175260-26162-7-git-send-email-mario.alfredo.c.arevalo@intel.com> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1447175260-26162-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1447175260-26162-7-git-send-email-mario.alfredo.c.arevalo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, jos.c.venegas.munoz@intel.com Subject: Re: [dpdk-dev] [PATCH v6 06/10] mk: Add rule for installing sdk files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 16:21:40 -0000 Hi, 2015-11-10 11:07, Mario Carrillo: > Add hierarchy-file support to the DPDK makefiles, scripts, > examples, tools, config files and headers, > when invoking "make install-sdk" makefiles, scripts, > examples, tools, config files will be installed in: The tools are part of the runtime, not the sdk. > $(DESTDIR)/$(SDK_DIR) > and headers will be installed in: > $(DESTDIR)/$(INCLUDE_DIR) > where SDK_DIR=$(RTE_PREFIX)/share/dpdk, > INCLUDE_DIR=$(RTE_PREFIX)/include/dpdk > RTE_PREFIX=/usr/local by default, you can override RTE_PREFIX, SDK_DIR > and INCLUDE_DIR vars. > This hierarchy is based on: > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html It would be better to follow the GNU standard to name the variables: https://www.gnu.org/prep/standards/html_node/Directory-Variables.html https://www.gnu.org/prep/standards/html_node/DESTDIR.html prefix ?= /usr/local exec_prefix ?= $(prefix) bindir ?= $(exec_prefix)/bin sbindir ?= $(exec_prefix)/sbin libdir ?= $(exec_prefix)/lib includedir ?= $(prefix)/include/dpdk datarootdir ?= $(prefix)/share docdir ?= $(datarootdir)/doc/dpdk datadir ?= $(datarootdir)/dpdk I would add: kerneldir ?= $(exec_prefix)/kmod sdkdir ?= $(datadir)