DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	ferruh.yigit@intel.com, dev@dpdk.org, stable@dpdk.org,
	stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix link status query
Date: Tue, 10 Apr 2018 10:29:18 +0200	[thread overview]
Message-ID: <4616956.1DYh5m3MiB@xps> (raw)
In-Reply-To: <20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com>

10/04/2018 10:20, Nélio Laranjeiro:
> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
> > When application works with LSC interrupts the ethdev layer skips
> > the PMD callback and update according to the link status exists on
> > device data. It is because it assumes the link status on the device data
> > is the correct one since any link change is processed by the application.
> > 
> > As multiple PMDs install the link status interrupt handler only on port
> > start and uninstall it on port stop, the link status may be incorrect in
> > case the query is called after port stop or before port start.
> 
> It seems also logical to not process interrupts from stopped device,
> for them accessing to the link status should always end by calling the
> devop function.
> 
> This patch is the result of discussion on thread [1].
> 
> > Fixing the query implementation to use the PMD callback for such cases.
> > 
> > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
> > Cc: stable@dpdk.org
> > Cc: stephen@networkplumber.org
> > Cc: nelio.laranjeiro@6wind.com
> 
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

Looks OK

Acked-by: Thomas Monjalon <thomas@monjalon.net>

  reply	other threads:[~2018-04-10  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10  6:16 Shahaf Shuler
2018-04-10  8:20 ` Nélio Laranjeiro
2018-04-10  8:29   ` Thomas Monjalon [this message]
2018-04-10 18:34     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4616956.1DYh5m3MiB@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).