DPDK patches and discussions
 help / color / mirror / Atom feed
From: HePeng <xnhp0320@icloud.com>
To: maxime.coquelin@redhat.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] Missing an increment on  vq->log_cache_nb_elem ?
Date: Thu, 14 Jun 2018 20:44:51 +0800	[thread overview]
Message-ID: <462941BC-FB45-46BD-8FB2-3455887D6BAB@icloud.com> (raw)

Hi, 


In the latest dpdk master branch, in the function *vhost_log_cache_page*:


static __rte_always_inline void
vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq,
			uint64_t page)
{
	uint32_t bit_nr = page % (sizeof(unsigned long) << 3);
	uint32_t offset = page / (sizeof(unsigned long) << 3);
	int i;

	for (i = 0; i < vq->log_cache_nb_elem; i++) {
		struct log_cache_entry *elem = vq->log_cache + i;

		if (elem->offset == offset) {
			elem->val |= (1UL << bit_nr);
			return;
		}
	}

	if (unlikely(i >= VHOST_LOG_CACHE_NR)) {
		/*
		 * No more room for a new log cache entry,
		 * so write the dirty log map directly.
		 */
		rte_smp_wmb();
		vhost_log_page((uint8_t *)(uintptr_t)dev->log_base, page);

		return;
	}

	vq->log_cache[i].offset = offset;
	vq->log_cache[i].val = (1UL << bit_nr);
}

Did it just miss an increment on vq->log_cache_nb_elem ?

             reply	other threads:[~2018-06-14 12:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 12:44 HePeng [this message]
     [not found] ` <CGME20180615123208eucas1p1e5d258f95e9621a31c2fcfbf1f494476@eucas1p1.samsung.com>
2018-06-15 12:32   ` Ilya Maximets
2018-06-15 13:24     ` Maxime Coquelin
2018-06-15 13:28       ` HePeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462941BC-FB45-46BD-8FB2-3455887D6BAB@icloud.com \
    --to=xnhp0320@icloud.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).