From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id A9A0F569A
 for <dev@dpdk.org>; Thu,  9 Jul 2015 04:05:25 +0200 (CEST)
Received: by widjy10 with SMTP id jy10so232033700wid.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 19:05:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=JW+FzoE5D8uHn9dodNS/OFI/K6cVBY80nVbUTMc3ZUY=;
 b=jKwMb7qpl3k6lm8QVUV0Y4DW+iZNYL79h7kdSuaNlTdrt9M7CPWhVm+BzHCykMclna
 nli70/3DJpNkPDCF24xgVqu8E6phXdIyPR03abl0Y6Ywr4juW4oVl36KZkWUWyg2HZcA
 GlcZSXzgt+BvLR2aiNHn+WUShsUYd6FlHgOPyD6c4dSvqSKXpauVoLhQ6Sm4qWaL2s/A
 XXikj/vBhOcgqjAP0ifhLGl0meUp1buLAnTItzoHtvpLtygfgA54zGHl95zjC/QDo74r
 fODR+pbDeH3XKuqfkIl87auSF1beFbWUz2LCJiOPlSoiTvQTVK07I+x8zyirn6eTmKLd
 gXzQ==
X-Gm-Message-State: ALoCoQkuIneZ5GvZVVKFq0xyzptu1gYqsm+SHfnI916N+0S6BUKR3exGIjZgVL0s3O0/IqEAfBTv
X-Received: by 10.180.77.233 with SMTP id v9mr79870816wiw.87.1436407524526;
 Wed, 08 Jul 2015 19:05:24 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id fa8sm5640304wib.14.2015.07.08.19.05.23
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Jul 2015 19:05:23 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Date: Thu, 09 Jul 2015 04:04:18 +0200
Message-ID: <46336707.Mc8mLjdgqb@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1436259634-7077-3-git-send-email-david.marchand@6wind.com>
References: <1436259634-7077-1-git-send-email-david.marchand@6wind.com>
 <1436259634-7077-3-git-send-email-david.marchand@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/6] eal/linux: remove useless casts
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 02:05:25 -0000

David, there is a 32-bit failure. See below

2015-07-07 11:00, David Marchand:
> Rather than cast the huge pages number returned by get_num_hugepages,=
 rework
> this function so that it returns 0 when something goes wrong.
> And no need for casts in log.

> --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +=09=09=09=09=09RTE_LOG(INFO, EAL, "%lu hugepages of size %lu reserve=
d, "
> +=09=09=09=09=09=09"but no mounted hugetlbfs found for that size\n",
> +=09=09=09=09=09=09num_pages, hpi->hugepage_sz);

error: format =E2=80=98%lu=E2=80=99 expects argument of type =E2=80=98l=
ong unsigned int=E2=80=99, but argument 5 has type =E2=80=98uint64_t {a=
ka long long unsigned int}=E2=80=99