From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9EE9DA09E4;
Thu, 21 Jan 2021 09:38:15 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1B0C6140EE7;
Thu, 21 Jan 2021 09:38:15 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [216.205.24.124])
by mails.dpdk.org (Postfix) with ESMTP id 02DA9140EDD
for <dev@dpdk.org>; Thu, 21 Jan 2021 09:38:13 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1611218293;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=TVbHabNedz4y1iQ9V8hAznSYMg+1VjEPXmjF0pj3K5M=;
b=QvSRoYAxSFyD4IZeKGjyFvoDByXQ+t+GzCnCR/+Yp+x4cLrL7AWGI9xGsm94/hWEgvGjTG
HZTCVjvoS03yyZ5dcwsIpwfTHEPnJe8D1cWR+iR1cSJ3qxQ7w7MX5FXK4qf/SpKE1aBv3l
i0xsglLW5tu4RRGbDB93ciodnyzoPx8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-191-Q05OhcmWN3uVl096R7uSXQ-1; Thu, 21 Jan 2021 03:38:11 -0500
X-MC-Unique: Q05OhcmWN3uVl096R7uSXQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
[10.5.11.15])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78AAD8030A1;
Thu, 21 Jan 2021 08:38:10 +0000 (UTC)
Received: from [10.36.110.29] (unknown [10.36.110.29])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DFF96362B;
Thu, 21 Jan 2021 08:38:04 +0000 (UTC)
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: david.marchand@redhat.com, stable@dpdk.org,
Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,
=?UTF-8?Q?Adri=c3=a1n_Moreno?= <amorenoz@redhat.com>,
Fan Zhang <roy.fan.zhang@intel.com>, Jay Zhou <jianjay.zhou@huawei.com>
References: <20210114110606.21142-1-bruce.richardson@intel.com>
<20210115111052.16437-1-bruce.richardson@intel.com>
<20210115111052.16437-9-bruce.richardson@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <4633794a-e2c5-74c0-bf11-6ae939dc7ee9@redhat.com>
Date: Thu, 21 Jan 2021 09:38:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210115111052.16437-9-bruce.richardson@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 08/19] vhost: fix missing header includes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 1/15/21 12:10 PM, Bruce Richardson wrote:
> The vhost header files were missing definitions from headers to allow
> them to be compiled up individually.
>
> Fixes: d7280c9fffcb ("vhost: support selective datapath")
> Fixes: a49f758d1170 ("vhost: split vDPA header file")
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_vhost/rte_vdpa.h | 2 ++
> lib/librte_vhost/rte_vdpa_dev.h | 1 +
> lib/librte_vhost/rte_vhost_crypto.h | 7 +++++++
> 3 files changed, 10 insertions(+)
>
> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
> index f074ec0c4a..1437f400bf 100644
> --- a/lib/librte_vhost/rte_vdpa.h
> +++ b/lib/librte_vhost/rte_vdpa.h
> @@ -11,6 +11,8 @@
> * Device specific vhost lib
> */
>
> +#include <stdint.h>
> +
> /** Maximum name length for statistics counters */
> #define RTE_VDPA_STATS_NAME_SIZE 64
>
> diff --git a/lib/librte_vhost/rte_vdpa_dev.h b/lib/librte_vhost/rte_vdpa_dev.h
> index a60183f780..bfada387b0 100644
> --- a/lib/librte_vhost/rte_vdpa_dev.h
> +++ b/lib/librte_vhost/rte_vdpa_dev.h
> @@ -8,6 +8,7 @@
> #include <stdbool.h>
>
> #include "rte_vhost.h"
> +#include "rte_vdpa.h"
>
> #define RTE_VHOST_QUEUE_ALL UINT16_MAX
>
> diff --git a/lib/librte_vhost/rte_vhost_crypto.h b/lib/librte_vhost/rte_vhost_crypto.h
> index c809c46a21..2a27a35892 100644
> --- a/lib/librte_vhost/rte_vhost_crypto.h
> +++ b/lib/librte_vhost/rte_vhost_crypto.h
> @@ -5,6 +5,13 @@
> #ifndef _VHOST_CRYPTO_H_
> #define _VHOST_CRYPTO_H_
>
> +#include <stdint.h>
> +#include <rte_compat.h>
> +
> +/* pre-declare structs to avoid including full headers */
> +struct rte_mempool;
> +struct rte_crypto_op;
> +
> #define VHOST_CRYPTO_MBUF_POOL_SIZE (8192)
> #define VHOST_CRYPTO_MAX_BURST_SIZE (64)
> #define VHOST_CRYPTO_MAX_DATA_SIZE (4096)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime