From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E834DA0598; Sat, 18 Apr 2020 15:22:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CEFF01DB3F; Sat, 18 Apr 2020 15:22:57 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 27B081DAF4 for <dev@dpdk.org>; Sat, 18 Apr 2020 15:22:56 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id DB920451; Sat, 18 Apr 2020 09:22:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 18 Apr 2020 09:22:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DmtldJm9URhGQTOAuiChj4NK5/C26F1AesSXWbVVIZI=; b=ZZp2NOE0QGhv FBOVeDd6rnuYwJ+tTgqrOiW62gHyV2gsuiXifowzZ0Sz/nCuqVFqws4fOyncjSAu QsMYsSiwWPTBCSIj+EMvGUPs0az5Gx6xCX5W7SHgoQ4htmgkyI9bRPff3QJVNmq3 5/e0OJA1x8dauGz7SRFf1OMwKDjfrMc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=DmtldJm9URhGQTOAuiChj4NK5/C26F1AesSXWbVVI ZI=; b=3MYy4XO9Y+zAESbJVMJck8pMH8qe6opxga9pVJjQqEmkajZQ0tSkD59ZJ wj/zPN0ILCUp1MN9pe+T4twj1Zh1pVG8+ZY7/rDQptBEPJ9Myb6kT9nSNUYgKaAI 6ni6dWG6l9PPsy0N00ZTOhBIdrWfqfzaeGsIs4gXl+oNagqlJClcnvxz9iKJ+dGw w83dzOUBskVolh/AD0HX3BQ9HCWjgxUTGRGI2qmo9TkzQooyOogak0hpO3ZeErg6 J1n0kYQLmD4vKoZ/ktRG7+EaESNlACql2xM3k6n1n6nUUe+/r5oS1BYHUGJsTggd v/i0PW4zFybhf5WX/jmNI7CT2Q5aA== X-ME-Sender: <xms:Lf-aXlFlYUjbw1onaC5ejJpSpBZbKPLlBUS2vyLuiGhWyQMkSkJrSA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeelgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:Lf-aXuneT5hb9fm1HzxsUVLcDQh7GmjcnOyyXjXh--QeUxI9rqvuvg> <xmx:Lf-aXiIsvuqLiLzaHu3N9YbvItv-VfMiaiIj1ALZ5my3ocW-pqdGYg> <xmx:Lf-aXvZf9giNJCrvWru5dRVYxvJhvxngiaAnuYbgJDRaYYpZgjOs1g> <xmx:Lv-aXrXovmkEN4csLleN4dfeAXMEqEkC1ig5cyJ76yzu6OtsSuYMiA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 06A1A306005F; Sat, 18 Apr 2020 09:22:52 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jerin Jacob <jerinjacobk@gmail.com> Cc: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>, Nikhil Rao <nikhil.rao@intel.com>, Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> Date: Sat, 18 Apr 2020 15:22:51 +0200 Message-ID: <4652369.uBEoKPz9u1@thomas> In-Reply-To: <CALBAE1MgjfmnDjTKmTUhTRx0tV2+yQytDr_Ad417wJ5uWQLiZA@mail.gmail.com> References: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> <4136788.dT8XKq9c71@thomas> <CALBAE1MgjfmnDjTKmTUhTRx0tV2+yQytDr_Ad417wJ5uWQLiZA@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 04/17] eventdev: replace library debug flag with global one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 18/04/2020 12:05, Jerin Jacob: > On Sat, Apr 18, 2020 at 3:23 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > 18/04/2020 11:41, Jerin Jacob Kollanukkaran: > > > From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> > > > > Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_EVENTDEV_DEBUG. > > > > The old define is completely removed from source code and config. > > > > > > > > > May I know the rational for this change? > > > > You know the rationale, it was discussed several times in Technical Board: > > If I already know the rationale, Why should I ask in ml? I meant you knew but you probably did not connect previous discussions with this patch. That's why I explain below, no problem. > > we are limiting the number of compilation options, and meson config does > > not propose them. > > > > > Other subsystem like ethdev still have CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n. > > > > No, look at the other patches in the series. > > > > > If we decide to make RTE_DEBUG then please submit the patch for all subsystem > > > across the DPDK. > > > > Yes, this is what Lukasz did. > > I missed the series. I just thought it is a single email due to email > filters. My bad.