[dpdk-dev] [PATCH 0/3] update doc for hns3

[dpdk-dev] [PATCH 0/3] update doc for hns3

[Lijun Ou]

Here series add some updates for hns3 rst and TM feature
note for hns3 as well as FEC feature notes.

Lijun Ou (2):
  doc: update release notes for hns3
  doc: fix hns3 rst

Min Hu (Connor) (1):
  doc: add FEC in NIC features

 doc/guides/nics/features.rst           | 14 ++++++++++++++
 doc/guides/nics/features/default.ini   |  1 +
 doc/guides/nics/hns3.rst               |  2 +-
 doc/guides/rel_notes/release_21_02.rst |  4 ++++
 4 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

[Lijun Ou]

From: "Min Hu (Connor)" <humin29@huawei.com>

Document FEC in NIC features, add information about FEC and add
implementation related support.

Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/nics/features.rst         | 14 ++++++++++++++
 doc/guides/nics/features/default.ini |  1 +
 2 files changed, 15 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index cf82e9d..ded5c16 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information.
 * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
 * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``.
 
+.. _nic_features_fec:
+
+FEC
+---
+
+Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode.
+It adds error correction information to data packets at the transmit end, and uses the error correction
+information to correct the bit errors generated during data packet transmission at the receive end. This
+improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.
+
+* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``.
+* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
+* **[related]    API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
+
 .. _nic_features_other:
 
 Other dev ops not represented by a Feature
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index ee786d3..562a681 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -65,6 +65,7 @@ Module EEPROM dump   =
 Registers dump       =
 LED                  =
 Multiprocess aware   =
+FEC                  =
 BSD nic_uio          =
 Linux UIO            =
 Linux VFIO           =
-- 
2.7.4

[dpdk-dev] [PATCH 2/3] doc: update release notes for hns3

[Lijun Ou]

Add TM(Traffic Management) feature with hns3 in release notes.

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/rel_notes/release_21_02.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index ae36b6a..e51277d 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -82,6 +82,10 @@ New Features
 
   * Added support for 64B completion queue entries
 
+* **Updated hns3 driver.**
+  * Added support for traffic management
+    Support for configuring port's peak rate and TC's peak rate with PF
+
 * **Updated Intel ice driver.**
 
   * Added Double VLAN support for DCF switch QinQ filtering.
-- 
2.7.4

[dpdk-dev] [PATCH 3/3] doc: fix hns3 rst

[Lijun Ou]

Here fixes the Kunpeng introduction address link with hns3.rst

Fixes: 565829db8b8f ("net/hns3: add build and doc infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/nics/hns3.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 8db8867..84bd7a3 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -41,7 +41,7 @@ Features of the HNS3 PMD are:
 Prerequisites
 -------------
 - Get the information about Kunpeng920 chip using
-  `<http://www.hisilicon.com/en/Products/ProductList/Kunpeng>`_.
+  `<https://www.hisilicon.com/en/products/Kunpeng>`_.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

[Ferruh Yigit]

On 1/20/2021 1:43 PM, Lijun Ou wrote:
> From: "Min Hu (Connor)" <humin29@huawei.com>
> 
> Document FEC in NIC features, add information about FEC and add
> implementation related support.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>   doc/guides/nics/features.rst         | 14 ++++++++++++++
>   doc/guides/nics/features/default.ini |  1 +
>   2 files changed, 15 insertions(+)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index cf82e9d..ded5c16 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information.
>   * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
>   * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``.
>   
> +.. _nic_features_fec:
> +
> +FEC
> +---
> +
> +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode.
> +It adds error correction information to data packets at the transmit end, and uses the error correction
> +information to correct the bit errors generated during data packet transmission at the receive end. This
> +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.
> +
> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``.
> +* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
> +* **[related]    API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
> +

Feature doc looks good, thanks for adding this.

Can you add another patch in this series to update .ini files for hns3 & cxgbe 
to advertise FEC feature?

>   .. _nic_features_other:
>   
>   Other dev ops not represented by a Feature
> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
> index ee786d3..562a681 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -65,6 +65,7 @@ Module EEPROM dump   =
>   Registers dump       =
>   LED                  =
>   Multiprocess aware   =
> +FEC                  =
>   BSD nic_uio          =
>   Linux UIO            =
>   Linux VFIO           =
> 

"Linux UIO" etc renamed in this release, can you rebase on top of latest repo 
please?

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

[Ferruh Yigit]

On 1/28/2021 12:20 AM, Ferruh Yigit wrote:
> On 1/20/2021 1:43 PM, Lijun Ou wrote:
>> From: "Min Hu (Connor)" <humin29@huawei.com>
>>
>> Document FEC in NIC features, add information about FEC and add
>> implementation related support.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>>   doc/guides/nics/features.rst         | 14 ++++++++++++++
>>   doc/guides/nics/features/default.ini |  1 +
>>   2 files changed, 15 insertions(+)
>>
>> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
>> index cf82e9d..ded5c16 100644
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information.
>>   * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
>>   * **[related] API**: ``rte_eth_rx_burst_mode_get()``, 
>> ``rte_eth_tx_burst_mode_get()``.
>> +.. _nic_features_fec:
>> +
>> +FEC
>> +---
>> +
>> +Supports Forward error correction. Forward error correction (FEC) is a bit 
>> error correction mode.
>> +It adds error correction information to data packets at the transmit end, and 
>> uses the error correction
>> +information to correct the bit errors generated during data packet 
>> transmission at the receive end. This
>> +improves signal quality but also brings a delay to signals. This function can 
>> be enabled or disabled as required.
>> +
>> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, 
>> ``fec_set``.
>> +* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, 
>> ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
>> +* **[related]    API**: ``rte_eth_fec_get_capability()``, 
>> ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
>> +
> 
> Feature doc looks good, thanks for adding this.
> 

cc'ed Andrew too for comment.

> Can you add another patch in this series to update .ini files for hns3 & cxgbe 
> to advertise FEC feature?
> 
>>   .. _nic_features_other:
>>   Other dev ops not represented by a Feature
>> diff --git a/doc/guides/nics/features/default.ini 
>> b/doc/guides/nics/features/default.ini
>> index ee786d3..562a681 100644
>> --- a/doc/guides/nics/features/default.ini
>> +++ b/doc/guides/nics/features/default.ini
>> @@ -65,6 +65,7 @@ Module EEPROM dump   =
>>   Registers dump       =
>>   LED                  =
>>   Multiprocess aware   =
>> +FEC                  =
>>   BSD nic_uio          =
>>   Linux UIO            =
>>   Linux VFIO           =
>>
> 
> "Linux UIO" etc renamed in this release, can you rebase on top of latest repo 
> please?

Re: [dpdk-dev] [PATCH 2/3] doc: update release notes for hns3

[Ferruh Yigit]

On 1/20/2021 1:43 PM, Lijun Ou wrote:
> Add TM(Traffic Management) feature with hns3 in release notes.
> 

Can you please add the commits of the patches introducing the feature mentioned 
in the release notes as fixes tag, for reference?

> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>   doc/guides/rel_notes/release_21_02.rst | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
> index ae36b6a..e51277d 100644
> --- a/doc/guides/rel_notes/release_21_02.rst
> +++ b/doc/guides/rel_notes/release_21_02.rst
> @@ -82,6 +82,10 @@ New Features
>   
>     * Added support for 64B completion queue entries
>   
> +* **Updated hns3 driver.**
> +  * Added support for traffic management
> +    Support for configuring port's peak rate and TC's peak rate with PF
> +

This is giving doc build warning [1], I guess an empty line required after first 
line, also should there be two bullet points?

doc build can be tested as:
meson setup -Denable_docs=true build-doc
ninja -C build-doc

[1]
release_21_02.rst:87: WARNING: Unexpected indentation

>   * **Updated Intel ice driver.**
>   
>     * Added Double VLAN support for DCF switch QinQ filtering.
> 

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

[oulijun]

在 2021/1/28 8:20, Ferruh Yigit 写道:
> On 1/20/2021 1:43 PM, Lijun Ou wrote:
>> From: "Min Hu (Connor)" <humin29@huawei.com>
>>
>> Document FEC in NIC features, add information about FEC and add
>> implementation related support.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>>   doc/guides/nics/features.rst         | 14 ++++++++++++++
>>   doc/guides/nics/features/default.ini |  1 +
>>   2 files changed, 15 insertions(+)
>>
>> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
>> index cf82e9d..ded5c16 100644
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information.
>>   * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, 
>> ``tx_burst_mode_get``.
>>   * **[related] API**: ``rte_eth_rx_burst_mode_get()``, 
>> ``rte_eth_tx_burst_mode_get()``.
>> +.. _nic_features_fec:
>> +
>> +FEC
>> +---
>> +
>> +Supports Forward error correction. Forward error correction (FEC) is 
>> a bit error correction mode.
>> +It adds error correction information to data packets at the transmit 
>> end, and uses the error correction
>> +information to correct the bit errors generated during data packet 
>> transmission at the receive end. This
>> +improves signal quality but also brings a delay to signals. This 
>> function can be enabled or disabled as required.
>> +
>> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, 
>> ``fec_set``.
>> +* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, 
>> ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
>> +* **[related]    API**: ``rte_eth_fec_get_capability()``, 
>> ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
>> +
> 
> Feature doc looks good, thanks for adding this.
> 
> Can you add another patch in this series to update .ini files for hns3 & 
> cxgbe to advertise FEC feature?
> 
ok. I will do it in next version.
>>   .. _nic_features_other:
>>   Other dev ops not represented by a Feature
>> diff --git a/doc/guides/nics/features/default.ini 
>> b/doc/guides/nics/features/default.ini
>> index ee786d3..562a681 100644
>> --- a/doc/guides/nics/features/default.ini
>> +++ b/doc/guides/nics/features/default.ini
>> @@ -65,6 +65,7 @@ Module EEPROM dump   =
>>   Registers dump       =
>>   LED                  =
>>   Multiprocess aware   =
>> +FEC                  =
>>   BSD nic_uio          =
>>   Linux UIO            =
>>   Linux VFIO           =
>>
> 
> "Linux UIO" etc renamed in this release, can you rebase on top of latest 
> repo please?
> .
> 

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

[Thomas Monjalon]

28/01/2021 02:55, oulijun:
> >> +FEC
> >> +---
> >> +
> >> +Supports Forward error correction. Forward error correction (FEC) is 
> >> a bit error correction mode.
> >> +It adds error correction information to data packets at the transmit 
> >> end, and uses the error correction
> >> +information to correct the bit errors generated during data packet 
> >> transmission at the receive end. This
> >> +improves signal quality but also brings a delay to signals. This 
> >> function can be enabled or disabled as required.
> >> +
> >> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, 
> >> ``fec_set``.
> >> +* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, 
> >> ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
> >> +* **[related]    API**: ``rte_eth_fec_get_capability()``, 
> >> ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
> >> +
> > 
> > Feature doc looks good, thanks for adding this.
> > 
> > Can you add another patch in this series to update .ini files for hns3 & 
> > cxgbe to advertise FEC feature?
> > 
> ok. I will do it in next version.

I suppose updating drivers can be done in the same patch.

[dpdk-dev] [PATCH v2 0/5] update doc for hns3

[Lijun Ou]

Here series add some updates for hns3 rst and TM feature
note for hns3 as well as FEC feature notes.

v2:
1. fix a meson build warning for patch[4/5]
2. add a new patch for update hns3.ini and cxgbe.ini
3. add Fixes for all patches.

Lijun Ou (4):
  net/hns3: add FEC feature for hns3.ini
  net/cxgbe: add FEC feature for cxgbe.ini
  doc: update release notes for hns3
  doc: fix hns3 rst

Min Hu (Connor) (1):
  doc: add FEC in NIC features

 doc/guides/nics/features.rst           | 14 ++++++++++++++
 doc/guides/nics/features/cxgbe.ini     |  1 +
 doc/guides/nics/features/default.ini   |  1 +
 doc/guides/nics/features/hns3.ini      |  1 +
 doc/guides/nics/hns3.rst               |  2 +-
 doc/guides/rel_notes/release_21_02.rst |  5 +++++
 6 files changed, 23 insertions(+), 1 deletion(-)

-- 
2.7.4

[dpdk-dev] [PATCH v2 1/5] doc: add FEC in NIC features

[Lijun Ou]

From: "Min Hu (Connor)" <humin29@huawei.com>

Document FEC in NIC features, add information about FEC and add
implementation related support.

Fixes: b7ccfb09da95 ("ethdev: introduce FEC API")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
V1->V2:
- Add Fixes for indicating that the driver is updated synchronously.
---
 doc/guides/nics/features.rst         | 14 ++++++++++++++
 doc/guides/nics/features/default.ini |  1 +
 2 files changed, 15 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 59beb47..fed98bf 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -908,6 +908,20 @@ Supports to get Rx/Tx packet burst mode information.
 * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
 * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``.
 
+.. _nic_features_fec:
+
+FEC
+---
+
+Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode.
+It adds error correction information to data packets at the transmit end, and uses the error correction
+information to correct the bit errors generated during data packet transmission at the receive end. This
+improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.
+
+* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``.
+* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
+* **[related]    API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
+
 .. _nic_features_other:
 
 Other dev ops not represented by a Feature
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 8d89278..f0d89da 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -65,6 +65,7 @@ Module EEPROM dump   =
 Registers dump       =
 LED                  =
 Multiprocess aware   =
+FEC                  =
 FreeBSD              =
 Linux                =
 Windows              =
-- 
2.7.4

[dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

[Lijun Ou]

The hns3 PMD add FEC features implementation in 20.11.
Therefore, need to update the hns3.ini for supporting.

Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/nics/features/hns3.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index a467396..4ea568c 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -39,5 +39,6 @@ Stats per queue      = Y
 FW version           = Y
 Registers dump       = Y
 Multiprocess aware   = Y
+FEC		     = Y
 Linux                = Y
 ARMv8                = Y
-- 
2.7.4

[dpdk-dev] [PATCH v2 3/5] net/cxgbe: add FEC feature for cxgbe.ini

[Lijun Ou]

The cxgbe PMD add FEC features implementation in 20.11.
Therefore, need to update the cxgbe.ini for supporting.

Fixes: 62aafe035896 ("net/cxgbe: support configuring link FEC")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/nics/features/cxgbe.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/cxgbe.ini b/doc/guides/nics/features/cxgbe.ini
index f913215..b33497e 100644
--- a/doc/guides/nics/features/cxgbe.ini
+++ b/doc/guides/nics/features/cxgbe.ini
@@ -28,6 +28,7 @@ Stats per queue      = Y
 EEPROM dump          = Y
 Registers dump       = Y
 Multiprocess aware   = Y
+FEC		     = Y
 FreeBSD              = Y
 Linux                = Y
 x86-32               = Y
-- 
2.7.4

[dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

[Lijun Ou]

Add TM(Traffic Management) feature with hns3 in release notes.
It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PF

Fixes: c09c7847d892 ("net/hns3: support traffic management")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/rel_notes/release_21_02.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index 23dcb37..08b73de 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -82,6 +82,11 @@ New Features
 
   * Added support for 64B completion queue entries
 
+* **Updated hns3 driver.**
+
+  * Added support for traffic management
+    Support for configuring port's peak rate and TC's peak rate with PF
+
 * **Updated Intel ice driver.**
 
   Updated the Intel ice driver with new features and improvements, including:
-- 
2.7.4

[dpdk-dev] [PATCH v2 5/5] doc: fix hns3 rst

[Lijun Ou]

Here fixes the Kunpeng introduction address link with hns3.rst

Fixes: 565829db8b8f ("net/hns3: add build and doc infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/nics/hns3.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 8db8867..84bd7a3 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -41,7 +41,7 @@ Features of the HNS3 PMD are:
 Prerequisites
 -------------
 - Get the information about Kunpeng920 chip using
-  `<http://www.hisilicon.com/en/Products/ProductList/Kunpeng>`_.
+  `<https://www.hisilicon.com/en/products/Kunpeng>`_.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

[Thomas Monjalon]

28/01/2021 13:43, Lijun Ou:
> The hns3 PMD add FEC features implementation in 20.11.
> Therefore, need to update the hns3.ini for supporting.
> 
> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>  doc/guides/nics/features/hns3.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
> index a467396..4ea568c 100644
> --- a/doc/guides/nics/features/hns3.ini
> +++ b/doc/guides/nics/features/hns3.ini
> @@ -39,5 +39,6 @@ Stats per queue      = Y
>  FW version           = Y
>  Registers dump       = Y
>  Multiprocess aware   = Y
> +FEC		     = Y

Please don't use tabs but only spaces in such .ini file.

Can it be squashed with the commit adding the feature in default.ini?

Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

[Ferruh Yigit]

On 1/28/2021 12:43 PM, Lijun Ou wrote:
> Add TM(Traffic Management) feature with hns3 in release notes.
> It includes:
> 1. configure port's peak rate with PF
> 2. configure TC's peak rate with PF
> 
> Fixes: c09c7847d892 ("net/hns3: support traffic management")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>   doc/guides/rel_notes/release_21_02.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
> index 23dcb37..08b73de 100644
> --- a/doc/guides/rel_notes/release_21_02.rst
> +++ b/doc/guides/rel_notes/release_21_02.rst
> @@ -82,6 +82,11 @@ New Features
>   
>     * Added support for 64B completion queue entries
>   
> +* **Updated hns3 driver.**
> +
> +  * Added support for traffic management
> +    Support for configuring port's peak rate and TC's peak rate with PF
> +

Hi Lijun,

Are these two different items, or second sentences is continuation of the first one?

>   * **Updated Intel ice driver.**
>   
>     Updated the Intel ice driver with new features and improvements, including:
> 

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

[oulijun]

在 2021/1/28 22:12, Thomas Monjalon 写道:
> 28/01/2021 13:43, Lijun Ou:
>> The hns3 PMD add FEC features implementation in 20.11.
>> Therefore, need to update the hns3.ini for supporting.
>>
>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>>   doc/guides/nics/features/hns3.ini | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
>> index a467396..4ea568c 100644
>> --- a/doc/guides/nics/features/hns3.ini
>> +++ b/doc/guides/nics/features/hns3.ini
>> @@ -39,5 +39,6 @@ Stats per queue      = Y
>>   FW version           = Y
>>   Registers dump       = Y
>>   Multiprocess aware   = Y
>> +FEC		     = Y
> 
> Please don't use tabs but only spaces in such .ini file.
> 
OK， I will fix it
> Can it be squashed with the commit adding the feature in default.ini?
Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.

> 
> 
> 
> .
> 

Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

[oulijun]

在 2021/1/28 22:46, Ferruh Yigit 写道:
> On 1/28/2021 12:43 PM, Lijun Ou wrote:
>> Add TM(Traffic Management) feature with hns3 in release notes.
>> It includes:
>> 1. configure port's peak rate with PF
>> 2. configure TC's peak rate with PF
>>
>> Fixes: c09c7847d892 ("net/hns3: support traffic management")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>>   doc/guides/rel_notes/release_21_02.rst | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/release_21_02.rst 
>> b/doc/guides/rel_notes/release_21_02.rst
>> index 23dcb37..08b73de 100644
>> --- a/doc/guides/rel_notes/release_21_02.rst
>> +++ b/doc/guides/rel_notes/release_21_02.rst
>> @@ -82,6 +82,11 @@ New Features
>>     * Added support for 64B completion queue entries
>> +* **Updated hns3 driver.**
>> +
>> +  * Added support for traffic management
>> +    Support for configuring port's peak rate and TC's peak rate with PF
>> +
> 
> Hi Lijun,
> 
> Are these two different items, or second sentences is continuation of 
> the first one?
Both the port peak rate and TC peak rate can be configured, or they can 
be configured separately.
> 
>>   * **Updated Intel ice driver.**
>>     Updated the Intel ice driver with new features and improvements, 
>> including:
>>
> 
> .
> 

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

[Ferruh Yigit]

On 1/29/2021 1:13 AM, oulijun wrote:
> 
> 
> 在 2021/1/28 22:12, Thomas Monjalon 写道:
>> 28/01/2021 13:43, Lijun Ou:
>>> The hns3 PMD add FEC features implementation in 20.11.
>>> Therefore, need to update the hns3.ini for supporting.
>>>
>>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>> ---
>>>   doc/guides/nics/features/hns3.ini | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/doc/guides/nics/features/hns3.ini 
>>> b/doc/guides/nics/features/hns3.ini
>>> index a467396..4ea568c 100644
>>> --- a/doc/guides/nics/features/hns3.ini
>>> +++ b/doc/guides/nics/features/hns3.ini
>>> @@ -39,5 +39,6 @@ Stats per queue      = Y
>>>   FW version           = Y
>>>   Registers dump       = Y
>>>   Multiprocess aware   = Y
>>> +FEC             = Y
>>
>> Please don't use tabs but only spaces in such .ini file.
>>
> OK， I will fix it
>> Can it be squashed with the commit adding the feature in default.ini?
> Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
> 

Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.

Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

[Ferruh Yigit]

On 1/29/2021 1:28 AM, oulijun wrote:
> 
> 
> 在 2021/1/28 22:46, Ferruh Yigit 写道:
>> On 1/28/2021 12:43 PM, Lijun Ou wrote:
>>> Add TM(Traffic Management) feature with hns3 in release notes.
>>> It includes:
>>> 1. configure port's peak rate with PF
>>> 2. configure TC's peak rate with PF
>>>
>>> Fixes: c09c7847d892 ("net/hns3: support traffic management")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>> ---
>>>   doc/guides/rel_notes/release_21_02.rst | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/doc/guides/rel_notes/release_21_02.rst 
>>> b/doc/guides/rel_notes/release_21_02.rst
>>> index 23dcb37..08b73de 100644
>>> --- a/doc/guides/rel_notes/release_21_02.rst
>>> +++ b/doc/guides/rel_notes/release_21_02.rst
>>> @@ -82,6 +82,11 @@ New Features
>>>     * Added support for 64B completion queue entries
>>> +* **Updated hns3 driver.**
>>> +
>>> +  * Added support for traffic management
>>> +    Support for configuring port's peak rate and TC's peak rate with PF
>>> +
>>
>> Hi Lijun,
>>
>> Are these two different items, or second sentences is continuation of the 
>> first one?
> Both the port peak rate and TC peak rate can be configured, or they can be 
> configured separately.

I asked from formatting perspective. In the output html these two lines looks 
like a long single line, if the intention is to have them as they are seen in 
the .rst file additional formatting is required.

>>
>>>   * **Updated Intel ice driver.**
>>>     Updated the Intel ice driver with new features and improvements, including:
>>>
>>
>> .
>>

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

[Thomas Monjalon]

29/01/2021 09:46, Ferruh Yigit:
> On 1/29/2021 1:13 AM, oulijun wrote:
> > 在 2021/1/28 22:12, Thomas Monjalon 写道:
> >> 28/01/2021 13:43, Lijun Ou:
> >>> The hns3 PMD add FEC features implementation in 20.11.
> >>> Therefore, need to update the hns3.ini for supporting.
> >>>
> >>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> >>> ---
> >>>   doc/guides/nics/features/hns3.ini | 1 +
> >>>   1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/doc/guides/nics/features/hns3.ini 
> >>> b/doc/guides/nics/features/hns3.ini
> >>> index a467396..4ea568c 100644
> >>> --- a/doc/guides/nics/features/hns3.ini
> >>> +++ b/doc/guides/nics/features/hns3.ini
> >>> @@ -39,5 +39,6 @@ Stats per queue      = Y
> >>>   FW version           = Y
> >>>   Registers dump       = Y
> >>>   Multiprocess aware   = Y
> >>> +FEC             = Y
> >>
> >> Please don't use tabs but only spaces in such .ini file.
> >>
> > OK， I will fix it
> >> Can it be squashed with the commit adding the feature in default.ini?
> > Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
> 
> Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.

Yes please. All three patches have the same intent: add FEC to features doc.

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

[oulijun]

在 2021/1/29 16:46, Ferruh Yigit 写道:
> On 1/29/2021 1:13 AM, oulijun wrote:
>>
>>
>> 在 2021/1/28 22:12, Thomas Monjalon 写道:
>>> 28/01/2021 13:43, Lijun Ou:
>>>> The hns3 PMD add FEC features implementation in 20.11.
>>>> Therefore, need to update the hns3.ini for supporting.
>>>>
>>>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>>> ---
>>>>   doc/guides/nics/features/hns3.ini | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/doc/guides/nics/features/hns3.ini 
>>>> b/doc/guides/nics/features/hns3.ini
>>>> index a467396..4ea568c 100644
>>>> --- a/doc/guides/nics/features/hns3.ini
>>>> +++ b/doc/guides/nics/features/hns3.ini
>>>> @@ -39,5 +39,6 @@ Stats per queue      = Y
>>>>   FW version           = Y
>>>>   Registers dump       = Y
>>>>   Multiprocess aware   = Y
>>>> +FEC             = Y
>>>
>>> Please don't use tabs but only spaces in such .ini file.
>>>
>> OK， I will fix it
>>> Can it be squashed with the commit adding the feature in default.ini?
>> Do you think patch[1/5] is merged into one ? I took ferruh.yigit's 
>> advice.
>>
> 
> Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.
> .
Thanks. I will do it in next version
> 

[dpdk-dev] [PATCH v3 0/3] update doc for hns3

[Lijun Ou]

Here series add some updates for hns3 rst and TM feature
note for hns3 as well as FEC feature notes.

v3:
1. merge patch[2/3] into patch[1] base on v2
2. fix some format errors

v2:
1. fix a meson build warning for patch[4/5]
2. add a new patch for update hns3.ini and cxgbe.ini
3. add Fixes for all patches.

Lijun Ou (2):
  doc: update release notes for hns3
  doc: fix hns3 rst

Min Hu (Connor) (1):
  doc: add FEC in NIC features

 doc/guides/nics/features.rst           | 14 ++++++++++++++
 doc/guides/nics/features/cxgbe.ini     |  1 +
 doc/guides/nics/features/default.ini   |  1 +
 doc/guides/nics/features/hns3.ini      |  1 +
 doc/guides/nics/hns3.rst               |  2 +-
 doc/guides/rel_notes/release_21_02.rst |  4 ++++
 6 files changed, 22 insertions(+), 1 deletion(-)

-- 
2.7.4

[dpdk-dev] [PATCH v3 1/3] doc: add FEC in NIC features

[Lijun Ou]

From: "Min Hu (Connor)" <humin29@huawei.com>

Document FEC in NIC features, add information about FEC and add
implementation related support.

Fixes: b7ccfb09da95 ("ethdev: introduce FEC API")
Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
Fixes: 62aafe035896 ("net/cxgbe: support configuring link FEC")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
V2->V3:
- merge patch 2 and patch 3 into patch 1 according to Thomas Monjalon's
  advice.
- fix format errors in hns3.ini and cxgbe.ini

V1->V2:
- add Fixes for indicating that the driver is updated synchronously.
---
 doc/guides/nics/features.rst         | 14 ++++++++++++++
 doc/guides/nics/features/cxgbe.ini   |  1 +
 doc/guides/nics/features/default.ini |  1 +
 doc/guides/nics/features/hns3.ini    |  1 +
 4 files changed, 17 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 59beb47..fed98bf 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -908,6 +908,20 @@ Supports to get Rx/Tx packet burst mode information.
 * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
 * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``.
 
+.. _nic_features_fec:
+
+FEC
+---
+
+Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode.
+It adds error correction information to data packets at the transmit end, and uses the error correction
+information to correct the bit errors generated during data packet transmission at the receive end. This
+improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.
+
+* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``.
+* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
+* **[related]    API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
+
 .. _nic_features_other:
 
 Other dev ops not represented by a Feature
diff --git a/doc/guides/nics/features/cxgbe.ini b/doc/guides/nics/features/cxgbe.ini
index f913215..fea7d4d 100644
--- a/doc/guides/nics/features/cxgbe.ini
+++ b/doc/guides/nics/features/cxgbe.ini
@@ -28,6 +28,7 @@ Stats per queue      = Y
 EEPROM dump          = Y
 Registers dump       = Y
 Multiprocess aware   = Y
+FEC                  = Y
 FreeBSD              = Y
 Linux                = Y
 x86-32               = Y
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 8d89278..f0d89da 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -65,6 +65,7 @@ Module EEPROM dump   =
 Registers dump       =
 LED                  =
 Multiprocess aware   =
+FEC                  =
 FreeBSD              =
 Linux                =
 Windows              =
diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index a467396..452a7b5 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -39,5 +39,6 @@ Stats per queue      = Y
 FW version           = Y
 Registers dump       = Y
 Multiprocess aware   = Y
+FEC                  = Y
 Linux                = Y
 ARMv8                = Y
-- 
2.7.4

[dpdk-dev] [PATCH v3 2/3] doc: update release notes for hns3

[Lijun Ou]

Add TM(Traffic Management) feature with hns3 in release notes.
It includes:
1. configure port's peak rate with PF
2. configure TC's peak rate with PF

Fixes: c09c7847d892 ("net/hns3: support traffic management")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
V2->V3:
- delete the unnecessary information lines
---
 doc/guides/rel_notes/release_21_02.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index 6662ece..875e292 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -82,6 +82,10 @@ New Features
 
   * Added support for 64B completion queue entries
 
+* **Updated hns3 driver.**
+
+  * Added support for traffic management
+
 * **Updated Intel ice driver.**
 
   Updated the Intel ice driver with new features and improvements, including:
-- 
2.7.4

[dpdk-dev] [PATCH v3 3/3] doc: fix hns3 rst

[Lijun Ou]

Here fixes the Kunpeng introduction address link with hns3.rst

Fixes: 565829db8b8f ("net/hns3: add build and doc infrastructure")
Cc: stable@dpdk.org

Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
 doc/guides/nics/hns3.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 8db8867..84bd7a3 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -41,7 +41,7 @@ Features of the HNS3 PMD are:
 Prerequisites
 -------------
 - Get the information about Kunpeng920 chip using
-  `<http://www.hisilicon.com/en/Products/ProductList/Kunpeng>`_.
+  `<https://www.hisilicon.com/en/products/Kunpeng>`_.
 
 - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH v3 0/3] update doc for hns3

[Ferruh Yigit]

On 1/29/2021 9:22 AM, Lijun Ou wrote:
> Here series add some updates for hns3 rst and TM feature
> note for hns3 as well as FEC feature notes.
> 
> v3:
> 1. merge patch[2/3] into patch[1] base on v2
> 2. fix some format errors
> 
> v2:
> 1. fix a meson build warning for patch[4/5]
> 2. add a new patch for update hns3.ini and cxgbe.ini
> 3. add Fixes for all patches.
> 
> Lijun Ou (2):
>    doc: update release notes for hns3
>    doc: fix hns3 rst
> 
> Min Hu (Connor) (1):
>    doc: add FEC in NIC features
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v3 0/3] update doc for hns3

[Ferruh Yigit]

On 1/29/2021 11:57 AM, Ferruh Yigit wrote:
> On 1/29/2021 9:22 AM, Lijun Ou wrote:
>> Here series add some updates for hns3 rst and TM feature
>> note for hns3 as well as FEC feature notes.
>>
>> v3:
>> 1. merge patch[2/3] into patch[1] base on v2
>> 2. fix some format errors
>>
>> v2:
>> 1. fix a meson build warning for patch[4/5]
>> 2. add a new patch for update hns3.ini and cxgbe.ini
>> 3. add Fixes for all patches.
>>
>> Lijun Ou (2):
>>    doc: update release notes for hns3
>>    doc: fix hns3 rst
>>
>> Min Hu (Connor) (1):
>>    doc: add FEC in NIC features
>>
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/main, thanks.