From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C40D044BE for ; Mon, 1 Oct 2018 12:05:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1336320A9B; Mon, 1 Oct 2018 06:05:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Oct 2018 06:05:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=8uUJWR2V/XuZ4mJImPmv6iVwW7 2wLkUdPIh1eYEYNNk=; b=SB1Ucn5RYogeDuQDS30oEezKIHFdsVuAmPVsnyriD0 Gake5zdBxOPnT/beXaur2TXJMYL1iHbzWlxygPhzAerrxnxou5Bc7m6VSYzs28Vo dPYhl9vMC9/YFGYoyijFXepK8rJ3pW4pCohYhqMsvcUmwo1ubyR6Gy0R4o3QRuXg w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8uUJWR 2V/XuZ4mJImPmv6iVwW72wLkUdPIh1eYEYNNk=; b=I7W7fQ9Jjuy95OvrIoeUps i06jzPFT8F4BugUbItQW15E67YVVpoRQpiREYCSeFwQun46/So8CVFnmGTAhIVR+ NoigUx/+RKN1g+IhbW9MniFIruyZosmVGk4dVFDEqTPYuNMYqUi5d1SQsxpEbhmG XKDoz6Gb6KhFxCH2jlBz0JN9RVn+1XclcfNTuUpeDx88zG4wOII9Mpneah1PpJII nS0cgkIm3vUuIHT2ZSZ8/XGdCCnBvtcoKdMkJbhmWljAj2ChKFYHEBG+Flwek0eT gQkALA7ODsjnI8JVQgR94b/yUjblC/CqVwMUJnON212eDo0VzxQcb44z+AUu4++A == X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9FFE7102A0; Mon, 1 Oct 2018 06:05:03 -0400 (EDT) From: Thomas Monjalon To: "Joseph, Anoob" Cc: dev@dpdk.org, Fiona Trahe , Akhil Goyal , Anoob Joseph , Pablo de Lara , Murthy NSSR , Jerin Jacob , Narayana Prasad , Ankur Dwivedi , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj Date: Mon, 01 Oct 2018 12:05:00 +0200 Message-ID: <46633655.Q4LKdWAF6e@xps> In-Reply-To: References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <21787cc6-1151-53e9-a86b-aa008b421fb1@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 10:05:07 -0000 24/09/2018 13:36, Joseph, Anoob: > Hi Fiona, > > Can you please comment on this? > > We are adding all capabilities of octeontx-crypto PMD as a macro in > otx_cryptodev_capabilites.h file and then we are using it from > otx_cryptodev_ops.c. This is the approach followed by QAT crypto PMD. As > per my understanding, this is to ensure that cryptodev_ops file remains > simple. For other PMDs with fewer number of capabilities, the structure > can be populated in the .c file itself without the size of the file > coming into the picture. > > But this would cause checkpatch to report error. Akhil's suggestion is > to move the entire definition to a header and include it from the .c > file. I believe, the QAT approach was to avoid variable definition in > the header. What do you think would be a better approach here? I think we should avoid adding some code in a .h file. And it is even worst when using macros. I suggest defining the capabilities in a .c file. If you don't want to bloat the main .c file, you can create a function defined in another .c file.