From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 384B99A8E for ; Sun, 17 May 2015 23:34:42 +0200 (CEST) Received: by wicmx19 with SMTP id mx19so75717913wic.0 for ; Sun, 17 May 2015 14:34:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+v7h1bCotCNhw2EwJ5AjedSukhx5fCfjJFW5bCHp160=; b=ETlgR4p6ohP7AzMg+KyMJNeZxw/rOa6RXOtwLnMUIZAq+rmQBD/I1l7J+/e+OU+eJh 1ozzxJPdJbRS4gWJnIYIV6df/s6WF4muSB3EuwrHeK9955oULNFT+D7goiUdh/zaeRxv eA/GGejYadmmWQAQe2h8owRHnNpW4joN4QLtF0T7LimQDyQ0UN/C6KsQlvcFys4lmAsN vCFp/fcGjb4PN8l2yxQrinU6mjCryiO+mIYEoPJA2St0ji06wkWXzsVDwZf0kpN3kC+1 P9DNgFgz0u0ctPlAynwqFG4MoiRq+FEwUZja6hL9Ldwd6D/HkfB675kZrjKXaCwKh8XR ZEiw== X-Gm-Message-State: ALoCoQmGi4+VDLjsyUPVWwEQlxD0uBdL+XjEyF23NtZr8OPBlb83I5Mb43kHhWGIpD9QLa4yz3n3 X-Received: by 10.180.100.101 with SMTP id ex5mr16679414wib.13.1431898482074; Sun, 17 May 2015 14:34:42 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id j1sm9264339wia.22.2015.05.17.14.34.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 14:34:41 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Sun, 17 May 2015 23:33:59 +0200 Message-ID: <4664717.UuZM4z4Hbc@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <1431066895-26813-1-git-send-email-helin.zhang@intel.com> References: <1431066895-26813-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PULL REQUEST] i40e base driver update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 May 2015 21:34:42 -0000 Hi Helin, > Helin Zhang (33): > i40e: copyright update > i40e: disable setting of phy configuration > i40e: adjustment of register definitions and relevant > i40e/base: rename 'err' to 'perrno' > i40e/base: support of building both PF and VF driver together > i40e/base: support of CEE DCBX on recent firmware versions > i40e: replacement of 'i40e_debug_read_register()' > i40e/base: rework of 'i40e_hmc_get_object_va' > i40e/base: update of shadow RAM read/write functions > i40e/base: catch NVM write semaphore timeout and retry > i40e/base: check for AQ timeout in aq_rc decode > i40e/base: fix up NVM update sm error handling > i40e/base: enhancement of polling NVM semaphore > i40e/base: enhancements of NVM checksum calculation > i40e/base: replacement of DEBUGOUT() with i40e_debug() > i40e/base: add fw build info to AQ data > i40e/base: define and use i40e_is_vf() > i40e/base: grab NVM devstarter version not image version > i40e/base: enhancements on adminq init and sending asq command > i40e/base: i40e_aq_get_link_info() should be used directly > i40e/base: add new interfaces for future use > i40e/base: update of get/set LED functions > i40e/base: clean up sparse complaint in i40e_debug_aq > i40e/base: get pf_id from HW rather than PCI function > i40e/base: find partition_id in npar mode, and disable FCOE by default > i40e/base: Reassign incorrect PHY type as a workaround for a FW issue > i40e/base: add AOC phy types to case statement in get_media_type > i40e/base: support for iSCSI capability > i40e/base: set FLAG_RD when sending driver version to FW > i40e/base: future proof some sizeof calls > i40e/base: add more virtual channel operations for future use > i40e/base: rework of structures and macros for future use > i40e/base: modifications for future use There was a build break due log rework in the middle of this series. Don't forget to check series with "git rebase -x make". I adjusted the patches order to fix it. Some titles and commit messages were a bit too vague and didn't describe why changes are done. I tried to improve titles a bit. In general, giving the name of a function in a commit title doesn't give the right level of information. Titles starting with "update" or "enhance" won't be descriptive enough and would probably be split. I'm not completely satisfied with it but most of things are well described so I guess it's enough for a base driver update of a young PMD. Though, it would be nice to have more precise descriptions of why things are done for next updates. Applied, thanks