From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 894C77E7A
 for <dev@dpdk.org>; Fri, 17 Oct 2014 09:20:46 +0200 (CEST)
Received: by mail-wg0-f52.google.com with SMTP id a1so253034wgh.35
 for <dev@dpdk.org>; Fri, 17 Oct 2014 00:28:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=gy0kL3IoRFnKy+QfQ89zklqUJ2Y2fxIUzFBdEKxel0E=;
 b=EMqI/w4tWJ/7CuNc8AnMOjATj91iOCQ4RnqX1EJ2X18zgNEtKUcR5UyWojOu5TTqP5
 9G34TBI4/6xnskPy+Zp6XEFxBzI50EXB9LC64sr5NJE+PEZnFXtEyK3uYRrGhYeBj1GS
 2oRQsacSlDS1wwsUc4csXTqXwcx4iQWglxImC+7m+wKQCKhxDNhu9QQfoB19q+7oNxvo
 Nh5N4metNc4zIxZidTMTKkVbvwvwyDzj+XSQFYpuSjQ/pA9fMlNgpXjnmaj4KqGqzs3D
 nwWCmpSPrL6VTx2koWxdmyHhAMK5Opi4I7UrUR/0G1mIQjDuVenwuo/YgRAHAqjrU8n/
 M7DA==
X-Gm-Message-State: ALoCoQmB8HvpiT6RdOV5/+3zWq/EnutndCcU9809KNQJUV88N5HOBj4B1PrsU6QTgoQsbtUBf8SB
X-Received: by 10.180.9.51 with SMTP id w19mr11892015wia.13.1413530923428;
 Fri, 17 Oct 2014 00:28:43 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ws2sm629420wjc.32.2014.10.17.00.28.41
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 17 Oct 2014 00:28:42 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Date: Fri, 17 Oct 2014 09:28:27 +0200
Message-ID: <4665765.pNYqlQvYlS@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2C0119@SHSMSX101.ccr.corp.intel.com>
References: <1413185980-17348-1-git-send-email-changchun.ouyang@intel.com>
 <F52918179C57134FAEC9EA62FA2F962511864157@shsmsx102.ccr.corp.intel.com>
 <C37D651A908B024F974696C65296B57B0F2C0119@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: Fix the vhost broken issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Oct 2014 07:20:46 -0000

2014-10-17 03:19, Xie, Huawei:
> From: Ouyang, Changchun
> > From: Xie, Huawei
> > > I generated the vhost example patch based on vhost library, but find
> > > there is
> > > issue with --mergeable feature.
> > > Only thousands of packets could be sent.
> > > Then I tried the latest vhost example,  which is just before my vhost
> > > lib patch, I found that not only it has the issue Which is fixed by the
> > > following patch but the --mergeable feature also doesn't work.
> > > Haven't got the change to dig into it.
> > > 
> > > Hints here:
> > > 1. mbuf allocation failure after thousands of packets.
> > > 2. disable INC_VEC(vectore scatter receive) in configure could solve
> > > this.
> > > 3. tried sending the packets directly out after receiving from vmdq
> > > queue, it
> > > works.
> > > 
> > > Could you root cause the issue, Changchun? You could work on the most
> > > recent
> > > example.
> > 
> > No problem, I will investigate the root cause.
> > 
> > But before figuring out the root cause, I think we could add check in your new
> > sample to
> > Check the INC_VEC is enable or not, If it is enabled, print error message and hint
> > user
> > Disable it in config file if mergeable feature is triggered in vhost. Then this issue
> > should not
> > block you from sending out your vhost app patch.
> > 
> > Your vhost app patch will block my another patch about multicast feature as
> > your vhost lib patch delete the vhost sample app totally.
> > So expect your vhost app patch send out soon.
> 
> Thomas:
> Thoughts about this? Could I send example patch with this walk around?

Yes, please send the new example with this small workaround.
It's better than nothing.

-- 
Thomas