DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ip_pipeline: fix wrong values in flow.cfg
@ 2016-07-27  9:35 Sankar Chokkalingam
  2016-07-28 14:58 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Sankar Chokkalingam @ 2016-07-27  9:35 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu

This configuration is example configuration for flow classification.
This fix changes the offset and mask value to compute the hash correctly.
This fix does not involve code change and do not impact compilation,
build and performance.

Fixes: 93771a569daa ("examples/ip_pipeline: rework flow classification CLI")

Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/config/flow.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/ip_pipeline/config/flow.cfg b/examples/ip_pipeline/config/flow.cfg
index 6895d39..cec990a 100644
--- a/examples/ip_pipeline/config/flow.cfg
+++ b/examples/ip_pipeline/config/flow.cfg
@@ -64,8 +64,8 @@ pktq_in = RXQ0.0 RXQ1.0 RXQ2.0 RXQ3.0
 pktq_out = TXQ0.0 TXQ1.0 TXQ2.0 TXQ3.0 SINK0
 n_flows = 65536
 ;key_size = 8                ; QinQ key size
-;key_offset = 270            ; QinQ key offset
-;key_mask = 0000FFF00000FFF0 ; QinQ key mask
+;key_offset = 268            ; QinQ key offset
+;key_mask = 00000FFF00000FFF ; QinQ key mask
 key_size = 16                               ; IPv4 5-tuple key size
 key_offset = 278                            ; IPv4 5-tuple key offset
 key_mask = 00FF0000FFFFFFFFFFFFFFFFFFFFFFFF ; IPv4 5-tuple key mask
-- 
2.5.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix wrong values in flow.cfg
  2016-07-27  9:35 [dpdk-dev] [PATCH] examples/ip_pipeline: fix wrong values in flow.cfg Sankar Chokkalingam
@ 2016-07-28 14:58 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-07-28 14:58 UTC (permalink / raw)
  To: Sankar Chokkalingam; +Cc: dev, cristian.dumitrescu

2016-07-27 02:35, Sankar Chokkalingam:
> This configuration is example configuration for flow classification.
> This fix changes the offset and mask value to compute the hash correctly.
> This fix does not involve code change and do not impact compilation,
> build and performance.
> 
> Fixes: 93771a569daa ("examples/ip_pipeline: rework flow classification CLI")
> 
> Signed-off-by: Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-28 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-27  9:35 [dpdk-dev] [PATCH] examples/ip_pipeline: fix wrong values in flow.cfg Sankar Chokkalingam
2016-07-28 14:58 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).