From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 5B9A52946 for ; Wed, 5 Oct 2016 16:19:24 +0200 (CEST) Received: from lfbn-1-5996-232.w90-110.abo.wanadoo.fr ([90.110.195.232] helo=[192.168.1.13]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1brn5e-0001g2-8F; Wed, 05 Oct 2016 16:22:34 +0200 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <1473407734-11253-1-git-send-email-olivier.matz@6wind.com> <1473407734-11253-2-git-send-email-olivier.matz@6wind.com> From: Olivier Matz Message-ID: <466bdaea-91c3-f849-494e-17526e397de5@6wind.com> Date: Wed, 5 Oct 2016 16:19:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/8] mbuf: add function to dump ol flag list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 14:19:24 -0000 Hi Pablo, On 10/05/2016 08:45 AM, De Lara Guarch, Pablo wrote: > Hi Olivier, > >> -----Original Message----- >> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c >> index fb2b962..56f37e6 100644 >> --- a/lib/librte_mbuf/rte_mbuf.c >> +++ b/lib/librte_mbuf/rte_mbuf.c >> @@ -319,6 +319,53 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) >> } >> } >> >> +struct flag_mask { >> + uint64_t flag; >> + uint64_t mask; >> + const char *default_name; >> +}; >> + >> +/* write the list of rx ol flags in buffer buf */ >> +int rte_get_rx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) > > Return type should go in a separate line (same case in the other function). I'll fix that too, thanks for reviewing. Olivier