From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@nvidia.com>,
David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Subject: Re: [PATCH] common/mlx5: fix build on Linux in dlopen link mode
Date: Tue, 08 Apr 2025 10:18:03 +0200 [thread overview]
Message-ID: <4677053.GUh0CODmnK@thomas> (raw)
In-Reply-To: <CAJFAV8z0dMFK0Vh8A=xxvQZnSJoJLz8e75bnsemwNwQoQUh9ZQ@mail.gmail.com>
08/04/2025 09:57, David Marchand:
> On Tue, Apr 8, 2025 at 9:47 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > When using the Meson option "ibverbs_link=dlopen",
> > a glue library is built.
> >
> > After the recent change requiring eal_export.h,
> > the build stopped because the internal EAL include directory
> > was unknown to this glue library:
> >
> > drivers/common/mlx5/linux/mlx5_glue.c:19:10: fatal error:
> > eal_export.h: No such file or directory
> >
> > Fixes: c7020bb20fc7 ("build: mark exported symbols")
> >
> > Reported-by: Ali Alnubani <alialnu@nvidia.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> lgtm.
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied quickly to fix the build.
prev parent reply other threads:[~2025-04-08 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 7:47 Thomas Monjalon
2025-04-08 7:57 ` David Marchand
2025-04-08 8:18 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4677053.GUh0CODmnK@thomas \
--to=thomas@monjalon.net \
--cc=alialnu@nvidia.com \
--cc=bingz@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).