From: Ferruh Yigit <ferruh.yigit@intel.com>
To: ssebasti@amd.com, dev@dpdk.org
Cc: Ravi Kumar <ravi1.kumar@amd.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx
Date: Fri, 28 Feb 2020 13:09:47 +0000 [thread overview]
Message-ID: <467e3d6a-1a5d-46ff-4b34-ad2a746d71b2@intel.com> (raw)
In-Reply-To: <20200227063344.1978-1-ssebasti@amd.com>
On 2/27/2020 6:33 AM, ssebasti@amd.com wrote:
> From: Selwin Sebastian <selwin.sebastian@amd.com>
>
> Enable scattered rx support and add jumbo packet transmit capability
>
> Signed-off-by: Selwin Sebastian <selwin.sebastian@amd.com>
<...>
> @@ -1018,9 +1024,19 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
> struct rte_pci_device *pci_dev;
> uint32_t reg, mac_lo, mac_hi;
> int ret;
> + struct rte_eth_dev_info dev_info = { 0 };
>
> eth_dev->dev_ops = &axgbe_eth_dev_ops;
> - eth_dev->rx_pkt_burst = &axgbe_recv_pkts;
> + eth_dev->dev_ops->dev_infos_get(eth_dev, &dev_info);
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER)
> + eth_dev->data->scattered_rx = 1;
Should check the requested config 'eth_dev->data->dev_conf.rxmode.offloads", not
the capability that driver set itself (dev_info.rx_offload_capa).
next prev parent reply other threads:[~2020-02-28 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 6:33 ssebasti
2020-02-27 14:28 ` Ferruh Yigit
2020-02-27 14:35 ` Sebastian, Selwin
2020-02-27 14:38 ` Ferruh Yigit
2020-02-28 9:00 ` Sebastian, Selwin
2020-02-28 13:08 ` Ferruh Yigit
2020-02-28 13:09 ` Ferruh Yigit [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-25 12:40 ssebasti
2020-02-26 5:47 ` Kumar, Ravi1
2020-03-05 10:20 ` Kumar, Ravi1
2020-03-05 10:27 ` Kumar, Ravi1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467e3d6a-1a5d-46ff-4b34-ad2a746d71b2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ravi1.kumar@amd.com \
--cc=ssebasti@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).