From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 468E4A00C2; Thu, 16 Jun 2022 19:04:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3774C410D1; Thu, 16 Jun 2022 19:04:07 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2071.outbound.protection.outlook.com [40.107.243.71]) by mails.dpdk.org (Postfix) with ESMTP id 56E4C40141 for ; Thu, 16 Jun 2022 19:04:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cujyFOXvw2YkYJewytLac7zGoiDgwWhe/e7tdg6IEMq819VVfg6GwiczbG604LOvll26gN9eJ+qR9/BGqkjIvUWpDszSpJSevPDmgbJrY4BogkOm3ud1GcNGvEAJ9h6M1Z1YIEVknRgh/LOFVdIcvObevlkl3mFWH612LAr/RWrWEvKISz/1U8nRDJFbAnSA9z/J6Rg9iBw90VNtHiVT6eNYMRiuOxwe+kS+TE4g5tik89Ixvvi/v3yjfnY5p4ugczHC5PrzoP6azRk5gn0iliQ7J72pOO+ZsJL0lFId/eJKfm92jk97TNf9W4ZrlSh8muZat0XzSd6NUdoF/hW8vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JIKpvsb5qD9QtRCxr++mBCiv9eVUEdYGgkxfGdrhD7M=; b=j4ssmoP9GbI5liWvekMh+ZgdLupfBP7jjurd1vs/i8XOMtLtYW+2IUrdRN4ypT5QymaJjjEPAO17zizMKpKJCYzv2+oKLM8FWGAmmWXyZHzD8Y9HUpudhg0IbGSHZKeue5NkdaARY306l6vzqRskEn9rKXNDBB12JgIbHT/KIehAT3hKR+IQcBJKNupx5RA/kzaq6bsIAC9jK0kM0Wed23t1eb5CFzwooPlZRDKs1v9n2MWAxB7e93/pO8mMZhij0bcYmgnQ2ZZjfexWOJVLXipcYJplvM2842VsvcJ3jCjLFi3Pg9Up09POjywlIH2ApfmUqw8bV4+WPuKN5jt+Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=broadcom.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JIKpvsb5qD9QtRCxr++mBCiv9eVUEdYGgkxfGdrhD7M=; b=kHtv46teOfB9HOLMIKiITH+N4HDfm4entUhNXV5BIPXZyG0w2q0XNOTAhzui2XBfoZ9M1EuGO6kcjLolPoKGIkqoTucT8wOxV50iLyCdH31ixv3vdKzI3XHG3Alviw/7n9XRkbAuHXjbtecjsqbIHmzb4SASnWU0qyY5R6h9KlE= Received: from DM3PR12CA0080.namprd12.prod.outlook.com (2603:10b6:0:57::24) by DM6PR02MB6732.namprd02.prod.outlook.com (2603:10b6:5:219::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Thu, 16 Jun 2022 17:04:02 +0000 Received: from DM3NAM02FT060.eop-nam02.prod.protection.outlook.com (2603:10b6:0:57:cafe::51) by DM3PR12CA0080.outlook.office365.com (2603:10b6:0:57::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Thu, 16 Jun 2022 17:04:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT060.mail.protection.outlook.com (10.13.4.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Thu, 16 Jun 2022 17:04:01 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 16 Jun 2022 18:04:00 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 16 Jun 2022 18:04:00 +0100 Envelope-to: kalesh-anakkur.purayil@broadcom.com, ajit.khaparde@broadcom.com, dev@dpdk.org Received: from [172.21.34.28] (port=7019) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o1suW-0004i3-AE; Thu, 16 Jun 2022 18:04:00 +0100 Message-ID: <46814c8c-b354-3a7e-24a8-6087a06712b4@xilinx.com> Date: Thu, 16 Jun 2022 18:04:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [dpdk-dev] [PATCH 8/8] net/bnxt: fix the check for autoneg enablement in the PHY FW Content-Language: en-US To: Kalesh A P CC: , References: <20220615145703.6613-1-kalesh-anakkur.purayil@broadcom.com> <20220615145703.6613-9-kalesh-anakkur.purayil@broadcom.com> From: Ferruh Yigit In-Reply-To: <20220615145703.6613-9-kalesh-anakkur.purayil@broadcom.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 325b3485-0d13-4a95-a8bd-08da4fba3664 X-MS-TrafficTypeDiagnostic: DM6PR02MB6732:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9VaHjxBF8yiGTT29CSqzoehlE/xX8JgR41jTvYLLCU7OYGI5rIcCTlwCDnfFfFNnIxo5jdGKJdoMM7ua8QDI7JA8Yzrwu1GZc1tLqqhHj4wRMGjD7U3DUy+lqcpOTBnsSNaIBSh5M6hsKbCDgUZqdwIo1vaOa0PheNhX9/yw5Du2OSuk6AEIKgfD1x3hy7XoTVgbc/buPQQ+fVLralrPG/qi/DlwmeQXRt04U9zjbk83YYikc1u4unc13ATqGNZVNsKlm6cRqU3TqExvOonr0xNCDTBySxFyebUb2gM8gp0eGKXEq7tCwvHAB3kYC0YjpBdB+qvBPz9p6p/oB9fK7MKtD/gGKP0S5pas0ncDmEvPxNDTHrycxWtf+UeBkY5UduNVr2Alh/PmYisw6kIOeG8A+8Sw82/wJDxJw53m+/Sau/048bvF2wOwsY+ibrsGD+v8fpjvg+yPTIlMGBl7phX/PrzXVvyyzf1B9dcrQkfuVKTp4NMI3UimmyJQdxoUNQP/aTHS6qBpMA1jhW/Av7MjddkrCi4ErUKiTCDKYqWZd1dbbh1IBtMlzUzw64S1SmP+nC17SKGcPLdNX/2ErAJhE2mf+ya9lnYcGQ3svRP9U5StmfW4QPRVjCcwqsh3HyDMyiTX0sSihwUcAK3GnaPsY6W5X6BaXnOfzyWC7t2sCyIfCGPRzZh8i/KYcmEwWOKcT0+sWtmlaxr9LGILhXx/KFgZCBsQPXrYlSKXsO6mt48VjfoO3/9AOlw4Qt7K5mzAfvazhiqzEQrfLChRtQ== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:ErrorRetry; CAT:NONE; SFS:(13230016)(4636009)(40470700004)(36840700001)(46966006)(5660300002)(4744005)(44832011)(2906002)(81166007)(31696002)(356005)(36860700001)(40460700003)(53546011)(26005)(54906003)(426003)(2616005)(508600001)(70586007)(70206006)(186003)(8676002)(4326008)(336012)(82310400005)(316002)(9786002)(8936002)(47076005)(36756003)(31686004)(6916009)(50156003)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 17:04:01.8611 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 325b3485-0d13-4a95-a8bd-08da4fba3664 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT060.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6732 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/15/2022 3:57 PM, Kalesh A P wrote: > > From: Somnath Kotur > > The current combination of checks to determine whether autoneg is > enabled in the card is a bit convoluted and may become incorrect > as well in the future as one of the fields being used - auto_link_speed > might become deprecated. > Switch to using the 'auto_mode' field obtained from the response of > HWRM_PHY_QCFG cmd as that is always deterministically set by the PHY > FW. > Fixed a bug in the 40G check to only look for the bit setting and > not the actual value. > Also, check the forced speeds first before trying to enforce the > auto speeds > > Allow the user to set autoneg speed in all cases except for PAM4 200G > as PAM4 200G will come up only in forced mode. > > Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") Is stable tag (stable@dpdk.org) omitted explicitly?