From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7D6EDA0C43;
Fri, 26 Nov 2021 18:08:03 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E2A75426E2;
Fri, 26 Nov 2021 18:08:02 +0100 (CET)
Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com
[66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 3958E41144
for <dev@dpdk.org>; Fri, 26 Nov 2021 18:08:01 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailnew.nyi.internal (Postfix) with ESMTP id 82FE9580371;
Fri, 26 Nov 2021 12:08:00 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute4.internal (MEProxy); Fri, 26 Nov 2021 12:08:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
VgRo+irg5arCxihKAWgn0tpJcU8BJkGhIaorEIENoT4=; b=fR2o+m62tIGyAYlv
sJwE+iCuZht+8uZTQIAs2vuPDq1foei0QAU2WD31eZeD5kdf4AwvQk8FbtaoXuOa
7jce/eHZiTq8Jk1VGpGsfaS1Op4I77JdSGjiF0N4qqLggUdhp7v4b6MWaqzQl7mM
vSSBESv6iKCmEHu4I0CTMdZWwx0OpinjCDjhh3QTCPdJkmRpyUR1q3IimckYcBiz
olqUPHjVFlb8md0/jAHam/75AwvUjoiBlfMOKC6AfdXBtqQ9ad2mgwXoibXF7bH7
oQsQzn9IyHCAMgwexSnaKEE6u0AFSIhCugRoqtEvgxgaZmn2L0qFOCeSrKt//1kK
igv3UA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=VgRo+irg5arCxihKAWgn0tpJcU8BJkGhIaorEIENo
T4=; b=J0lPwm77OCZVgBL97MlDW8d4UWdHgxU9CcGNKlyLjN4r+mpnZkDhNNO13
MahYmW7iBF7pLwtbgZF9ndXwpBZJefmJrSItcusMtUi3jyYpB+8yZmN74SeYLn1w
UB6RrVO6LgxJ0cwRPqG22EKR4UDXL9ad8hojlhEWHsA/8O0jaqx6t5rjov89Bgas
5G9BiACqfH/ooDOZ/z4iFl8skzImN3cz0nfKtjAEEnJbCH0Ph1EFprEF9CQZwiTp
QzzHWzFPBoUbcwZngY+b4QVPe2YuA0HllBemCUf+/n16R/IvBbkxAW0Stev6+giI
dx/i5YKySwNHzIZobSqZKULYs1XHg==
X-ME-Sender: <xms:bRShYVvJ4TTeZaHTQ4iDM0RERWUY9gqjyPOJdJ1ml6baFG15U715VQ>
<xme:bRShYeeZ5DBHRuqeSIQMjLU3zU3IUZ-4GWGUNp2Hr7TxVv4tpLN7lBFfj03jhpC83
j8zik8atEfl9L79FQ>
X-ME-Received: <xmr:bRShYYxp711Ls2JxvJ4tWyyi2SgfmNKYWE4HLmtcqKTi7M36xQ3giA_KrxSPWwfw1FvBW0RyFMJX_G7M_w-a5ZPttQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedvgdelhecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh
hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:bRShYcMktxGn7jAfBbasTw09FBfwImadYP4rXNLqN1Pgc1Iiyiyd0A>
<xmx:bRShYV-dCVCvn-iJI4rayaqPX9tDpK0bcPhq1kMMzaNY5s1IFtfEhA>
<xmx:bRShYcX39a2SpIq1gu2mLFIJfuDckmAPYJHm8sjvocQhfiAD384NJQ>
<xmx:cBShYTdwZq9fE1PUAijBDQGv0qVlzsmXYiYdGtZzJY7kXERmU40ZVw>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
26 Nov 2021 12:07:55 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, hemant.agrawal@nxp.com,
ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com,
andrew.rybchenko@oktetlabs.ru, rahul.lakkireddy@chelsio.com,
jerinj@marvell.com, humin29@huawei.com, haiyue.wang@intel.com,
ndabilpuram@marvell.com, sthemmin@microsoft.com, sachin.saxena@nxp.com,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v4] ethdev: deprecate header fields and metadata flow
actions
Date: Fri, 26 Nov 2021 18:07:54 +0100
Message-ID: <4681850.ngjkj8ognW@thomas>
In-Reply-To: <YaD0rPqqcsUvVTwB@platinum>
References: <20211123075940.5521-1-viacheslavo@nvidia.com>
<2145893.KXFgBx9ejH@thomas> <YaD0rPqqcsUvVTwB@platinum>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
26/11/2021 15:52, Olivier Matz:
> On Fri, Nov 26, 2021 at 02:06:23PM +0100, Thomas Monjalon wrote:
> > 26/11/2021 13:53, Ferruh Yigit:
> > > On 11/26/2021 9:51 AM, Viacheslav Ovsiienko wrote:
> > > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was
> > > > introduced by [1]. This action provides an unified way
> > > > to perform various arithmetic and transfer operations over
> > > > packet network header fields and packet metadata.
> > > >
> > > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action")
It should be [1] 73b68f4c54a0 ("ethdev: introduce generic modify flow action")
> > > > On other side there are a bunch of multiple legacy actions,
> > > > that can be superseded by the generic MODIFY_FIELD action:
> > > >
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc
> > > > RTE_FLOW_ACTION_TYPE_SET_TTL mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic,
> > > > mlx5, octeontx2, sfc
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic,
> > > > mlx5, octeontx2, sfc
> > > > RTE_FLOW_ACTION_TYPE_SET_TAG mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_META mlx5
> > > >
> > > > This note deprecates the following RTE Flow actions,
> > > > as not supported by any of PMDs:
> > > >
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN
> > > >
> > > > The following actions are supposed to be deprecated in 22.07
> > > > and replaced by generic field modify action:
> > > >
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST
> > > > RTE_FLOW_ACTION_TYPE_DEC_TTL
> > > > RTE_FLOW_ACTION_TYPE_SET_TTL
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP
> > > > RTE_FLOW_ACTION_TYPE_SET_TAG
> > > > RTE_FLOW_ACTION_TYPE_SET_META
> > > >
> > > > The VLAN set actions are interrelated to VLAN header insertion/removal
> > > > and supported by multiple PMDs and widely used by applications and
> > > > not supposed to be deprecated due to potential large impact on
> > > > drivers and applications.
> > > >
> > > > Signed-off-by: Viacheslav Ovsiienko<viacheslavo@nvidia.com>
> > >
> > > Thanks for the update,
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > >
> > >
> > > We need to follow with relevant PMD maintainers to switch to new
> > > 'MODIFY_FIELD' action till end of v22.07 release.
> >
> > Yes I would like to see them replying here, but seems some are not watching.
> > I don't want to block this interesting deprecation plan,
> > so I will merge if few more maintainers involved in ethdev give their ack.
> >
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks.