From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 997DEA0C43;
	Thu,  7 Oct 2021 09:44:44 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2250B41137;
	Thu,  7 Oct 2021 09:44:44 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 5FDD440140
 for <dev@dpdk.org>; Thu,  7 Oct 2021 09:44:42 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id EFFEC5C0186;
 Thu,  7 Oct 2021 03:44:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Thu, 07 Oct 2021 03:44:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 N1ZN82gAuYklOFRT+fvHDjNEBtkljT/N/CqXEKBqM+g=; b=FzR+8T0I93uIasfm
 yAzec6+JfGmQfa27yb4kTx8cdVSHPd7D+qgeJI/sUrcKIvvNHf7Ctnn2OELu7NRT
 g3mcH8jL/OFQAm8H3miYmGgk+xQr4Dqo6vZe3I3lBZSzJIEVger+Gy0p7+SKNO6k
 Hxz5J2q5Ngtjv/LxwDZ632nPkecYI3N4sFt41ATlsGe8paWhayyHGLWMS4+yQcvT
 q8WtF1ZBdjNTgpouXmaz0HGC8M9mgotrUmwxfBAViq++YDsiZi47JZzoaY89L5PS
 OJ+M+5BvNNWPfe2dsmUBGpfXIh5dYLD+OaJLgvMbT4kiEmgAFDrxxPut7MGhqRrs
 CY+mDQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=N1ZN82gAuYklOFRT+fvHDjNEBtkljT/N/CqXEKBqM
 +g=; b=XU0JQpfgX2npUE23ZKeK0TUNGxC+a6BeVO07Lwdq0KMHu11xtiHvD4DOB
 tRTdh62wiCPX3ddJaU225YUrqwlrnCLj8zUgokIip9SJxQyoBTUbBwDbih0QlaxA
 prezSAy3z1KZ804rBxCyB6+Dc1JHWSXfiJQBz93wAB1dkj87pMxRPMt0yFzmyWQO
 C4eFXRVhczeDu/WunRiEDgP6vTBM3yKcKhtejDbn5rjZMkhQESm6zgn6XsJldTl7
 O0NiNS6YT1UI16LBJZDHm4pwmjp39adwO5X5UK8Ol/a8aZifPoTa8kINXeW5z/H5
 xxcv+CeP8Y0sY3GJW3yMqBxo4We2Q==
X-ME-Sender: <xms:aaVeYU2Z-vf3xDg-GnxvfBEoMA5zQqY4aa8x3C3s3XQVUYQeOVDDJQ>
 <xme:aaVeYfGPYBxqyMCMSTSAxxYBfhPP_oleNtq1pwp-mBb4D0sZ-9U2T03qtRkoRNKiX
 XyZiNmmMpmfGkkwvg>
X-ME-Received: <xmr:aaVeYc4n_H2Caz5_RQ4d_8bFjWR4sBeDgH9v3_cFUilje1KqWd2bX5yUalPaeOQPWWwiAXPuWYSCxAm1gpv_YlitBQnRgFFQYt4Phb9uJZs>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeljedguddujecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
 ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:aaVeYd1y68r_5Jpcjyk4hfGw7WobX4tq_QIawfIUHJBqAJyea2mc1A>
 <xmx:aaVeYXE6crX8jJjU0P6RtHKiqsonzHaMGeU9ZyWxfyRIu3JzpL5GGw>
 <xmx:aaVeYW8EN0HhES1U2B9KYJFWB_PIOx98Je9tT_rzGNHFikAON_E4GQ>
 <xmx:aaVeYcTEJbQvGChP6ig2483e4MPLM_QDjSFAhtllsv4oqNl_c8RM9w>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 7 Oct 2021 03:44:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: William Tu <u9012063@gmail.com>
Cc: dev@dpdk.org, Tal Shnaiderman <talshn@nvidia.com>,
 Akhil Goyal <gakhil@marvell.com>
Date: Thu, 07 Oct 2021 09:44:38 +0200
Message-ID: <4683013.dgGTLkrohr@thomas>
In-Reply-To: <20211006223544.1882-3-u9012063@gmail.com>
References: <20211005170252.7-1-u9012063@gmail.com>
 <20211006223544.1882-1-u9012063@gmail.com>
 <20211006223544.1882-3-u9012063@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 2/4] security: build on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/10/2021 00:35, William Tu:
> From: Tal Shnaiderman <talshn@nvidia.com>
> 
> Build the security library on Windows.
> 
> Remove unneeded export from version file.

To be more precise, it is unneeded because they are inline functions.

> --- a/lib/security/version.map
> +++ b/lib/security/version.map
> @@ -1,13 +1,11 @@
>  DPDK_22 {
>  	global:
>  
> -	rte_security_attach_session;
>  	rte_security_capabilities_get;
>  	rte_security_capability_get;
>  	rte_security_session_create;
>  	rte_security_session_destroy;
>  	rte_security_session_get_size;
> -	rte_security_set_pkt_metadata;
>  
>  	local: *;
>  };
> @@ -19,7 +17,6 @@ EXPERIMENTAL {
>  	__rte_security_set_pkt_metadata;
>  	rte_security_dynfield_offset;
>  	rte_security_dynfield_register;
> -	rte_security_get_userdata;
>  	rte_security_session_stats_get;
>  	rte_security_session_update;
>  };