Re: [PATCH v3] net/mana: fix uninitialized scalar variable

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 6/12/2024 7:23 PM, Mahmoud Maatuq wrote:
> From: mmaatuq <mahmoudmatook.mm@gmail.com>
> 
> in case we didn't enter or finished the loop without getting ifname we
> ret shouldn't have an arbitrary value.
> 
> Coverity issue: 424690
> Fixes: 84497839d9ca ("net/mana: support MTU update")
> Cc: longli@microsoft.com
> 
> Signed-off-by: mmaatuq <mahmoudmatook.mm@gmail.com>
>

Hi Mahmoud,

According to Developer Certificate of Origin [1] that DPDK adopts [2],
please use full name in the sign off.


[1]
http://developercertificate.org/

[2]
https://old.dpdk.org/dev#send


> ---
> v3:
>  * add Fixes and Cc tags
> v2:
> * Fixed typo in word "arbitrary"
> ---
>  drivers/net/mana/mana.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
> index 68c625258e..c37c4e3444 100644
> --- a/drivers/net/mana/mana.c
> +++ b/drivers/net/mana/mana.c
> @@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)
>  static int
>  mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE])
>  {
> -	int ret;
> +	int ret = -ENODEV;
>  	DIR *dir;
>  	struct dirent *dent;
> 
> --
> 2.43.0
>