From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2BC042C4D; Wed, 7 Jun 2023 14:32:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 831F340A84; Wed, 7 Jun 2023 14:32:28 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 7926F40698 for ; Wed, 7 Jun 2023 14:32:26 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 2316A3200933; Wed, 7 Jun 2023 08:32:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 07 Jun 2023 08:32:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686141142; x=1686227542; bh=AF3CY0FBvh6XXfngSHGPMySL2SrbSRQ16p2 6VZmD6QU=; b=gdonC/T6nmwxhcYueaxGXkYoKjqyr3s9KtywXWrD0rQMfjfzU+n hxHlAIV8g8mjdoYGFCzoZBdnSoylviHm+9cv4TFFTowGP7KzxudZLZSOAjjP6kU1 NaZL/lLuEdRwz4nPR0O77WBbGlyQ1WFXZ6og2CJm+Tr9toBsdOwW52clgj4sa5cR A2TRfOnjK69awhK0AfRpt1JuW9WefxP9KcXiv4BHaaJa9DGzsx33RXdj3HptP9u5 t7TQmJzxuCoZL4YdmWZWiBmbPU49PIxeKU3OmY/LcXA4vMlxOKUXM7H4ZpdGE3yQ 3Cmdtgz4tHDG4XmjD5/v0T1tOQecsjaCLtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686141142; x=1686227542; bh=AF3CY0FBvh6XXfngSHGPMySL2SrbSRQ16p2 6VZmD6QU=; b=muRg8J1vYOOvrVVrspcCoe+Lot4crA2qpPViDNbQQuJ7EjKyC3H /l9N6uFMr/1N9bgMDPIO0Q5E6WqJAEB/UEm5reQF7HFVtbcwRN9v4zmqEewVkErO XylWD3o2KewkT0dFWgKYJqNogHg3gLR8xfgfwkq7O9dvtd2LFtUyrj91DngKMsu2 L2nY+AKGSmyiDrBthxmTba/OhRof5VaHvH27u1J5bmJ+8QMQJGnlL4q232g07Z6j dX2NnQURVgWhwMZjGMVxS2Lad646GdsCy0agGb9SFKP4S3Ba7dA5guLWRxyK/q0N fy7FfyZ8pwUkA0SwwN15nRqD25DEMhuzsKQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegjeeivdelheduhfeugfefvefgheeiteegiefggffgffffieeu gfeukedtfeefveenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jun 2023 08:32:20 -0400 (EDT) From: Thomas Monjalon To: Kamalakshitha Aligeri , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: Yuying.Zhang@intel.com, beilei.xing@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, konstantin.ananyev@huawei.com, Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, feifei.wang2@arm.com, dev@dpdk.org, nd@arm.com Subject: Re: [PATCH v10 1/2] mempool cache: add zero-copy get and put functions Date: Wed, 07 Jun 2023 14:32:18 +0200 Message-ID: <4686310.neEnAmRlxL@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8799C@smartserver.smartshare.dk> References: <20230224181059.338206-1-kamalakshitha.aligeri@arm.com> <1755322.4herOUoSWf@thomas> <98CBD80474FA8B44BF855DF32C47DC35D8799C@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/06/2023 14:04, Morten Br=F8rup: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, 7 June 2023 12.32 > >=20 > > 24/02/2023 19:10, Kamalakshitha Aligeri: > > > From: =3D Morten Br=F8rup > >=20 > > There is an equal sign inserted above. >=20 > Could be removed while applying? Better to fix in next version. > > > Zero-copy access to mempool caches is beneficial for PMD performance,= and > > > must be provided by the mempool library to fix [Bug 1052] without a > > > performance regression. > > > > > > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=3D1052 > > > > > > Bugzilla ID: 1052 > >=20 > > It would be fun if the bug content was a link to an email :) > > More fun: refer to a place which will be deleted in some time. > > Really, please explain the problem in the patch. > > You can refer to the Bugzilla, but the idea must be in the patch. > > Then no need for the full link. > >=20 > >=20 >=20 > OK, how about this: >=20 > Zero-copy access to mempool caches is beneficial for PMD performance. >=20 > Furthermore, having a zero-copy mempool API is considered a precondition = for fixing a certain category of bugs, present in some PMDs: For performanc= e reasons, some PMDs had bypassed the mempool API in order to achieve zero-= copy access to the mempool cache. This can only be fixed in those PMDs with= out a performance regression if the mempool library offers zero-copy access= APIs, so the PMDs can use the proper mempool API instead of copy-pasting c= ode from the mempool library. Furthermore, the copy-pasted code in those PM= Ds has not been kept up to date with the improvements of the mempool librar= y, so when they bypass the mempool API, mempool trace is missing and mempoo= l statistics is not updated. >=20 > Bugzilla ID: 1052 Looks good, thanks.