From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 297E1199B0 for ; Tue, 19 Sep 2017 14:39:15 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2017 05:39:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,418,1500966000"; d="scan'208";a="901817749" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2017 05:39:14 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20170918151755.86605-1-ajit.khaparde@broadcom.com> <20170918151755.86605-12-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <4687161e-7d29-a0d5-1616-f7bdbe675057@intel.com> Date: Tue, 19 Sep 2017 13:39:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170918151755.86605-12-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 11/19] net/bnxt: add support for xstats get by id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 12:39:16 -0000 On 9/18/2017 4:17 PM, Ajit Khaparde wrote: > This patch adds support for xstats_get_by_id/xstats_get_names_by_id. > > Signed-off-by: Ajit Khaparde > > -- > v1->v2: incorporate review comments. > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 ++ > drivers/net/bnxt/bnxt_stats.c | 47 ++++++++++++++++++++++++++++++++++++++++++ > drivers/net/bnxt/bnxt_stats.h | 5 +++++ > 3 files changed, 54 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index cecdfde..6eed19c 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1564,6 +1564,8 @@ static const struct eth_dev_ops bnxt_dev_ops = { > .txq_info_get = bnxt_txq_info_get_op, > .dev_led_on = bnxt_dev_led_on_op, > .dev_led_off = bnxt_dev_led_off_op, > + .xstats_get_by_id = bnxt_dev_xstats_get_by_id_op, > + .xstats_get_names_by_id = bnxt_dev_xstats_get_names_by_id_op, > }; > > static bool bnxt_vf_pciid(uint16_t id) > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c > index d7d0e35..89921fb 100644 > --- a/drivers/net/bnxt/bnxt_stats.c > +++ b/drivers/net/bnxt/bnxt_stats.c > @@ -358,3 +358,50 @@ void bnxt_dev_xstats_reset_op(struct rte_eth_dev *eth_dev) > if (!(bp->flags & BNXT_FLAG_PORT_STATS)) > RTE_LOG(ERR, PMD, "Operation not supported\n"); > } > + > +int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids, > + uint64_t *values, unsigned int limit) > +{ > + /* Account for the Tx drop pkts aka the Anti spoof counter */ Is this comment valid? > + const unsigned int stat_cnt = RTE_DIM(bnxt_rx_stats_strings) + > + RTE_DIM(bnxt_tx_stats_strings) + 1; > + struct rte_eth_xstat xstats[stat_cnt]; > + uint16_t i; > + > + if (!ids) > + return bnxt_dev_xstats_get_op(dev, xstats, stat_cnt); Why not just return "stat_cnt" ? > + > + for (i = 0; i < limit; i++) { > + if (ids[i] >= stat_cnt) { > + RTE_LOG(ERR, PMD, "id value isn't valid"); > + return -1; > + } > + values[i] = xstats[ids[i]].value; Where xstats[] has been filled? Same comments valid for bnxt_dev_xstats_get_names_by_id_op() > + } > + return stat_cnt; > +} > + <...>