From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 276B62C58 for ; Mon, 9 Jan 2017 18:12:09 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id a197so104601331wmd.0 for ; Mon, 09 Jan 2017 09:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=MOu+nSaGFoLvCjJCwqYJRdz1YYjrmDf/LR4zS8VyUDs=; b=btuaT0K2DHMnRHLDgmqrbTTTt1euSpgIDs3Swh15gS51TTOL9y3iYMBAXXB6j25Fir 15SER+giYACTR1HsDop2PnqfuFLOhCRXA0Jjct1nbItOT928GC/73ut1BF9OL+enuQ1g 8Rd/FxB43UMpEKUj157EACdCMHnVFhvDfLdk7zSS5xygCzbFkIlpY92ViFLpV2B+BMIh gUYW4AjKRF4V3bQNjJ6HpAUfiA5si012Q20Cd94x5DMpcyjm1ufeZ9ZhpKC64R4UqF7X zCMAhXU23Rzz6RsT4zj2jSq67xBOxO75ezZub2Pt+LuHCT4Cwu5la1NxQY4NX3kGAkGi 9Eig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=MOu+nSaGFoLvCjJCwqYJRdz1YYjrmDf/LR4zS8VyUDs=; b=JOMh07rBYlMVL1GHKwz/Yb6Pooy7WSOVTAEveZfa4r//fgscLLhwy4Hco48TiY+1z2 +ZtJ3y+YMtO9tgevP0ThU63RyJiF2JpbaxSOmJ0JWbktoBTYqrakjnPQd5UbmoHr17+E whFemG+4PlJ3HZfTfIk1eadTO26X845F0d82puglDkQelfwhuxwmSZgnECfzhaI+OsdS f8e7vhMybemoFfdJUVhBXEWypMP3pxScBe0CfKYuybkI0erSJMESS9v/4rRWQF6Dki5C T43ylQeEYvZjklw7IdcBKkQZ2xkBKd83zwTjibp1NYSjODB1YYzVX9Oc/wD9kuDbe8OU p4Cg== X-Gm-Message-State: AIkVDXImvM07QtIeeBoaK+BaeSVsTsZqyhkQF0TeeSHgP79awgLN5MNZ1sySC5NPOSOZ/Xn9 X-Received: by 10.28.216.9 with SMTP id p9mr4697464wmg.11.1483981928842; Mon, 09 Jan 2017 09:12:08 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 191sm5898668wmo.21.2017.01.09.09.12.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 09:12:08 -0800 (PST) From: Thomas Monjalon To: Ben Walker Cc: Shreyansh Jain , dev@dpdk.org Date: Mon, 09 Jan 2017 18:12:07 +0100 Message-ID: <4689267.aT7BcNq7bb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <64510177.2V8Gqa4j9X@xps13> References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <2631459.aun9V5NdHs@xps13> <64510177.2V8Gqa4j9X@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 17:12:09 -0000 2017-01-04 18:39, Thomas Monjalon: > 2016-12-21 17:19, Thomas Monjalon: > > 2016-11-25 14:51, Shreyansh Jain: > > > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > > > If resources were mapped prior to probe, unmap them > > > > if probe fails. > > > > > > > > This does not handle the case where the kernel driver was > > > > forcibly unbound prior to probe. > > > > > > > > Signed-off-by: Ben Walker > > > > > > Acked-by: Shreyansh Jain > > > > The 3 first patches of this series seems good and easy to agree, > > except some minor nits. > > > > Please Ben or Shreyansh, could you respin only them to help make > > progress before applying a PCI/bus rework from Shreyansh? > > As soon as one of you shoot a partial v3, I'll apply them. > > Thanks > > Please Ben, do you want to make a partial v3? Please, would you mind to re-send the first 3 patches as v3?