From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Tomasz Duszynski <tduszynski@marvell.com>,
dpdk-dev <dev@dpdk.org>, "Jerin Jacob" <jerinj@marvell.com>,
Harman Kalra <hkalra@marvell.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Jakub Palider <jpalider@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry
Date: Tue, 2 Nov 2021 11:21:59 +0000 [thread overview]
Message-ID: <46897f55-b550-fee2-c466-79420c37a9fa@intel.com> (raw)
In-Reply-To: <CALBAE1Mt+3X0RpzDf+w1pqUghe8k707d25Y4yZgwBLOsSGFAYQ@mail.gmail.com>
On 11/2/2021 11:11 AM, Jerin Jacob wrote:
> On Tue, Nov 2, 2021 at 3:58 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 11/2/2021 4:32 AM, Jerin Jacob wrote:
>>> On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>>
>>>> On 10/22/2021 12:56 PM, Tomasz Duszynski wrote:
>>>>> Add initial support for baseband telemetry.
>>>>>
>>>>> Signed-off-by: Tomasz Duszynski<tduszynski@marvell.com>
>>>>> ---
>>>>> v2:
>>>>> - make bphy telemetry available only on platforms supporting baseband
>>>>> - use platform types where possible
>>>>> - remove unused header
>>>>>
>>>>> drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++
>>>>
>>>> Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented
>>>> in common code, instead of driver?
>>>
>>> It can be raw/cnxk_bphy, thought of keeping it in common due to
>>> 1) To reuse it for another common code consumer
>>
>> Is it reusable, since the code is to get telemetry data from raw device?
>
> Yes. I meant, common code is reused on another library that has
> telemetry support too.
>
>>
>>> 2) roc_bphy_sso_pf_func_get() and roc_bphy_npa_pf_func_get() manged by
>>> common code. aka there is no reverse dependency on the raw driver framework
>>> in common code.
>>
>> If telemetry code moved to raw driver, dependency will be from driver to
>> common code, which is correct dependency order I think.
>>
>> It just looks wrong to have rawdev related telemetry function in the common
>> code, but I may be missing details, trying to understand.
>
> Currently, we are doing like this:
> - implementing HW specific telemetry endpoints in driver/common/cnxk
> - ethdev/mempool/eventdev/cryptodev driver-specific telemetry endpoint
> in driver/.../cnxk.
> The criteria for deciding what is the second category is, if it uses
> any ethdev/mempool/eventdev/cryptodev/rawdev
> symbols or if telemetry-related raw dev driver implementation details.
> i.e common code does not have
> any raw driver dependency.
>
Got it, so I am proceeding as it is.
prev parent reply other threads:[~2021-11-02 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 7:46 [dpdk-dev] [PATCH] " Tomasz Duszynski
2021-10-19 12:30 ` [dpdk-dev] [EXT] " Harman Kalra
2021-10-22 11:56 ` [dpdk-dev] [PATCH v2] " Tomasz Duszynski
2021-10-29 16:03 ` Jerin Jacob
2021-11-01 14:38 ` Ferruh Yigit
2021-11-02 4:32 ` Jerin Jacob
2021-11-02 10:28 ` Ferruh Yigit
2021-11-02 11:11 ` Jerin Jacob
2021-11-02 11:21 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46897f55-b550-fee2-c466-79420c37a9fa@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=jpalider@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).