From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 703282A6C for ; Thu, 6 Apr 2017 22:15:01 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id t20so79290054wra.1 for ; Thu, 06 Apr 2017 13:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=by2zXCM/pLLoeAf6pKSvAuM77khlrJAoYADquZ5hgrg=; b=sy5P31Lop0ynLZ4HC1Lye9Pe+wTJPyoCG6GfoeiijihahT461cNz/CWe51AYHQmQs/ UR2cjuHR2vgQemIx9dDgWhLnfMXOinPjs1GCVWevagVwo1Jg6NyCPWa+Sc3oh+lWHjt5 CysKv09zDt/a3zVo0KIrQXz4oIMMeQloM5rkP6UJDzNHGmBXb4NoC+mpiMV1oX4IvkAG cTfwXcdofVP1idGUsUfaZhZxaeNvtNPcsRo4WWFqu9FVAF2tvvak6xGVhBI4+zlo/RHz 4maTvXsSyf36Em6ErZKUhi64Cr6oECZDM8B6NUf8vYmbNampYup2uu7dEc2URmTd+mLJ LzSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=by2zXCM/pLLoeAf6pKSvAuM77khlrJAoYADquZ5hgrg=; b=iXmPa68JwBdfdBvBgwk1KhYPS63mVqlBi0Gjv1ppILNsxLPfZwB9Wo7ZXjH2XOnjFU JOtsOKUApwnFl7Iw4lK49EdrIETeUXW1E34elUivGJNYiwfnaEW0FJQNsdOTIMxiTZv2 5gBgAib4r+GAHlFaxuIEYNLNw9blZ0Epd71iI5sZLr2S6/5CzcJk9xlSEXm0tI05enYu /cwjuyHMuovFOhR57bgnmLXUpbjActGxQqTLjQx5hs3dNqWmPvWKqcCwUHRdPNU/ffxJ Aqe0dQpOMWKB6W2bjhaZstA2cPh33O2cKBi6rxbUtm5We+6bY/ct+uElrGo9cM67sFCV HE8Q== X-Gm-Message-State: AFeK/H05CXgPIZgKW0/fds4japAuSy43fk5wRbePPYybGp6LSPZqJDBq Jpx2nHfjVHgR+tkNncg= X-Received: by 10.28.137.208 with SMTP id l199mr24335765wmd.65.1491509701133; Thu, 06 Apr 2017 13:15:01 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 33sm3006476wrd.40.2017.04.06.13.15.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 13:15:00 -0700 (PDT) From: Thomas Monjalon To: Ami Sabo , yuanhan.liu@linux.intel.com Cc: dev@dpdk.org Date: Thu, 06 Apr 2017 22:14:59 +0200 Message-ID: <4691348.WVCvaACybL@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1655428.Al161abRzh@xps13> References: <1488102926-24158-2-git-send-email-amis@radware.com> <1488445242-8824-1-git-send-email-amis@radware.com> <1655428.Al161abRzh@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 20:15:01 -0000 Ping 2017-03-08 12:40, Thomas Monjalon: > 2017-03-02 11:00, Ami Sabo: > > The patchset fixes secondary process crash issue when it tries > > to access virtio-user pmd (e.g. via rte_eth_rx_burst). > > > > The crash happens because in virtio_user probing, > > eth_dev_attach_secondary is not being called, as it does from > > rte_eth_dev_pci_probe. Therefore, the device is not properly > > initialized. > > > > The patchset contains 2 patches: > > 1. Export rte_eth_dev_attach_secondary, so non-pci drivers will be > > allowed to call it. > > 2. Fix the actual bug by calling the function during virtio_user probe. > > I do not understand why nobody complains for other virtual devices. > We should have the same issue with pcap, tap, ring, af_packet, etc. > Probably that other drivers are broken in secondary processes. > Or should we make a fix to handle every secondary vdev in > rte_eth_dev_allocate() ? Any opinion?