From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E06FBA04BC; Fri, 9 Oct 2020 20:52:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD93C1C227; Fri, 9 Oct 2020 20:52:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 320351C219 for ; Fri, 9 Oct 2020 20:52:56 +0200 (CEST) IronPort-SDR: fMdf29jM/z5Ce9Sa3+TQeS35VyV0mbVbq5aFewiMm0Qf6S8towdrGkHNxtVGqEyeUa0EDztv4U AB4S7MyhlYJA== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="164738571" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="164738571" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 11:52:53 -0700 IronPort-SDR: 2PAVHxydmX7jzock/FWWAH2+Q2BrsDDuT34RYW+IXZ/ss8UBAFtqHL2nC1B0r1sI8BNSjbsjhs iJsUzbX+gW7Q== X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="462288475" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.7]) ([10.252.18.7]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 11:52:51 -0700 To: oulijun , wenzhuo.lu@intel.com, beilei.xing@intel.com, adrien.mazarguil@6wind.com, Phil Yang Cc: dev@dpdk.org, linuxarm@huawei.com References: <1599702678-11142-1-git-send-email-oulijun@huawei.com> <1600955105-53176-1-git-send-email-oulijun@huawei.com> <4d629d1e-1b62-31e1-dc8b-7e4cc69859e1@intel.com> From: Ferruh Yigit Message-ID: <46956bf5-54ff-c8b6-74de-a6338c6d5d3a@intel.com> Date: Fri, 9 Oct 2020 19:52:47 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] RSS key use with testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/2020 1:09 PM, oulijun wrote: > > > 在 2020/9/30 21:17, Ferruh Yigit 写道: >> On 9/24/2020 2:45 PM, Lijun Ou wrote: >>> Consider the follow usage with testpmd: >>> 1. first, startup testpmd: >>> testpmd> show port 0 rss-hash key >>> RSS functions: >>>   all ipv4-frag ipv4-other ipv6-frag ipv6-other ip >>> RSS key: >>> 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F >>> 20C6A42B73BBEAC01FA >>> 2. create a rss rule >>> testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions rss \ >>> types ipv4-udp end queues end / end >>> >>> 3. show rss-hash key >>> testpmd> show port 0 rss-hash key >>> RSS functions: >>>   all ipv4-udp udp >>> RSS key: >>> 74657374706D6427732064656661756C74205253532068617368206B65792C206F >>> 76657272696465 >>> >>> As a result, the step 3 with RSS key and the step 1 RSS key >>> is not the same. The patch[1] to solve the above problems. >>> >> >> This is interesting, can you please provide above information in the commit >> log too? >> > Yes， I submitted detailed operation information in patch v3 as a commit, and > Yang suggested that the operation information be included in the cover letter. > OK, understood. Only, commands helped me to understand the problem, it is easy to grasp the issue with samples, so I thought it may help others later in if it is in the commit log, since cover letter won't be visible in the git repo. @Phil, will you be OK to have them in the commit log if the checkpatch warnings fixed? >> Also can you please provide the details on why this happens, callstack can help? >> > When you start the testpmd, the pmd driver initializes the RSS configuration. > Generally, the recommended RSS hash key is used as the default key in the > driver. In addition, the default key is different from the default RSS flow in > testpmd without specifying RSS hash key. > So， if you do not specify the RSS key when creating an RSS rule, the testpmd > uses the default key as the default RSS key of the RSS rule.As a result, you may > mistakenly consider that the RSS key in use is the valid default key of the NIC, > actually, the key and the valid default key of the NIC are two values. Above description looks good, can you include this to the commit log please? >> Thanks, >> ferruh >> >> >>> Lijun Ou (1): >>>    app/testpmd: fix the default RSS key configuration >>> >>>   app/test-pmd/cmdline_flow.c | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >>> >> >> . >>