From: "Boyer, Andrew" <Andrew.Boyer@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Boyer, Andrew" <Andrew.Boyer@amd.com>
Subject: Re: [PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer
Date: Wed, 19 Mar 2025 15:03:12 +0000 [thread overview]
Message-ID: <46EDC3B9-7DAA-4FB7-946D-9728242E0F11@amd.com> (raw)
In-Reply-To: <20250311155300.13410-3-stephen@networkplumber.org>
> On Mar 11, 2025, at 11:51 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> The expression *dev->intf->setup_bars and dev->intf->setup_bars
> are equivalent.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/crypto/ionic/ionic_crypto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ionic/ionic_crypto.h b/drivers/crypto/ionic/ionic_crypto.h
> index db87ea0490..5a03260486 100644
> --- a/drivers/crypto/ionic/ionic_crypto.h
> +++ b/drivers/crypto/ionic/ionic_crypto.h
> @@ -269,7 +269,7 @@ iocpt_setup_bars(struct iocpt_dev *dev)
> if (dev->intf->setup_bars == NULL)
> return -EINVAL;
>
> - return (*dev->intf->setup_bars)(dev);
> + return dev->intf->setup_bars(dev);
> }
>
> /** iocpt_admin_ctx - Admin command context.
> --
> 2.47.2
>
Thank you!
next prev parent reply other threads:[~2025-03-19 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 15:51 [PATCH 0/4] more unnecessary " Stephen Hemminger
2025-03-11 15:51 ` [PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers Stephen Hemminger
2025-03-11 16:03 ` Bruce Richardson
2025-03-12 14:06 ` Xu, Rosen
2025-03-11 15:51 ` [PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer Stephen Hemminger
2025-03-19 15:03 ` Boyer, Andrew [this message]
2025-03-11 15:51 ` [PATCH 3/4] regexdev: another unnecessary deref of function pointers Stephen Hemminger
2025-03-11 15:51 ` [PATCH 4/4] vhost: remove " Stephen Hemminger
2025-03-11 16:04 ` [PATCH 0/4] more unnecessary function pointer Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EDC3B9-7DAA-4FB7-946D-9728242E0F11@amd.com \
--to=andrew.boyer@amd.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).