From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dan Gora <dg@adax.com>
Cc: dev@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface
Date: Thu, 11 Oct 2018 00:00:35 +0100 [thread overview]
Message-ID: <46a1acbe-53ff-6bdc-e313-c2e720f5ef73@intel.com> (raw)
In-Reply-To: <CAGyogRYkkVKy4rcLJBVkr5bNN3acEde0UqMbT7JK2Kk6JCa89A@mail.gmail.com>
On 10/10/2018 4:01 PM, Dan Gora wrote:
> On Wed, Oct 10, 2018 at 11:16 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 9/27/2018 1:32 AM, Dan Gora wrote:
>>> Hi All,
>>>
>>> Attached is version 3 of a patchset to add a new API function to
>>> set the link status on kernel interfaces created with the KNI kernel
>>> module.
>>>
>>> v3
>>> ====
>>> * Use separate function to test rte_kni_update_link() in 'test' app.
>>>
>>> * Separate changes to 'test' app into separate patch to facilitate
>>> possible merge with https://patches.dpdk.org/patch/44730/
>>>
>>> * Remove changes to set KNI interfaces to 'up' in example/kni
>>>
>>>> v2
>>>> ====
>>>>
>>>> * Fix bug where "Fixed" and "AutoNeg" were transposed in the link
>>>> status log message.
>>>>
>>>> * Add rte_kni_update_link() to rte_kni_version.map
>>>>
>>>> * Add rte_kni_update_link() tests to kni_autotest
>>>>
>>>> * Update examples/kni to continuously monitor link status and
>>>> update the corresponding kernel interface with
>>>> rte_kni_update_link().
>>>>
>>>> * Minor improvements to examples/kni: Add log message showing how
>>>> to show/zero stats. Improve zeroing statistics.
>>>>
>>>> Note that checkpatches.sh compains about patch 1/5, but this appears
>>>> to be a bug with check-symbol-change or something. If I move the
>>>> fragment of the patch modifying rte_kni_version.map to the bottom of
>>>> the patch file, it doesn't complain any more... I just don't really
>>>> have time to investigate this right now.
>>>
>>> thanks
>>> dan
>>>
>>> Dan Gora (6):
>>> kni: add API to set link status on kernel interface
>>> kni: add link status test
>>> kni: set default carrier state to 'off'
>>> examples/kni: monitor and update link status continually
>>> examples/kni: add log msgs to show and clear stats
>>> examples/kni: improve zeroing statistics
>>
>> Hi Dan,
>>
>> We are a little away to integration deadline, it is good to clarify the status
>> of the patchset.
>>
>> There are a few change requests to this patchset:
>> 1- 4/6, there is an open on adding command line option to control monitor/set
>> link status.
>
> No, I don't have any plans to add a command line option to do this.
> Again, there is no reason for a command line option.
>
>> 2- Dropping 6/6, I guess you already agreed on this.
>
> No, I showed you that that patch to fix zeroing the statistics would
> actually increase performance. You just never responded to that
> email.
>
>> 3- 1/6, to have or not the log message.
>
> I included a proposal in my last email. Please take a look at that and respond.
>
>> I would like to see the patchset in the release, what do you think about above
>> actions?
>
> I'm incredibly frustrated with this whole process to be honest...
Please don't be so, you are spending time/effort to improve an open source
project which is great, thank you again.
Why don't we take this as incremental steps, first get agreed part in a
patchset. 4/6 doesn't fit this but I can implement the command line part for you
if you agree, what do you think?
next prev parent reply other threads:[~2018-10-10 23:00 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 23:29 [dpdk-dev] [PATCH 0/2] " Dan Gora
2018-09-11 23:29 ` [dpdk-dev] [PATCH 1/2] " Dan Gora
2018-09-18 16:54 ` Ferruh Yigit
2018-09-18 17:41 ` Dan Gora
2018-09-11 23:29 ` [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off' Dan Gora
2018-09-18 16:15 ` Ferruh Yigit
2018-09-18 16:48 ` Ferruh Yigit
2018-09-18 18:34 ` Dan Gora
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 0/5] kni: add API to set link status on kernel interface Dan Gora
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 1/5] " Dan Gora
2018-09-26 13:59 ` Ferruh Yigit
2018-09-26 14:55 ` Dan Gora
2018-09-26 16:42 ` Ferruh Yigit
2018-09-26 18:56 ` Dan Gora
2018-09-27 11:35 ` Ferruh Yigit
2018-09-27 15:40 ` Dan Gora
2018-09-27 21:49 ` Ferruh Yigit
2018-09-27 23:05 ` Dan Gora
2018-09-27 23:44 ` Ferruh Yigit
2018-09-27 23:51 ` Dan Gora
2018-09-28 8:02 ` Igor Ryzhov
2018-09-28 8:03 ` Ferruh Yigit
2018-10-03 19:07 ` Dan Gora
2018-10-10 14:09 ` Ferruh Yigit
2018-10-10 14:57 ` Dan Gora
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 2/5] kni: set default carrier state to 'off' Dan Gora
2018-09-26 13:59 ` Ferruh Yigit
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-09-26 14:00 ` Ferruh Yigit
2018-09-26 19:16 ` Dan Gora
2018-09-27 11:54 ` Ferruh Yigit
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-09-26 14:00 ` Ferruh Yigit
2018-09-19 19:55 ` [dpdk-dev] [PATCH v2 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-09-26 14:01 ` Ferruh Yigit
2018-09-26 14:48 ` Dan Gora
2018-09-27 11:40 ` Ferruh Yigit
2018-09-27 15:53 ` Dan Gora
2018-09-27 22:04 ` Ferruh Yigit
2018-09-27 22:40 ` Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 1/6] " Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 2/6] kni: add link status test Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 3/6] kni: set default carrier state to 'off' Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 4/6] examples/kni: monitor and update link status continually Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 5/6] examples/kni: add log msgs to show and clear stats Dan Gora
2018-09-27 0:32 ` [dpdk-dev] [PATCH v3 6/6] examples/kni: improve zeroing statistics Dan Gora
2018-10-10 14:16 ` [dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface Ferruh Yigit
2018-10-10 15:01 ` Dan Gora
2018-10-10 23:00 ` Ferruh Yigit [this message]
2018-10-10 23:36 ` Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 " Dan Gora
2018-10-17 15:29 ` Ferruh Yigit
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 1/6] " Dan Gora
2018-10-18 13:44 ` Ferruh Yigit
2018-10-18 19:00 ` Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 2/6] kni: add link status test Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 3/6] kni: set default carrier state of interface Dan Gora
2018-10-17 15:20 ` Ferruh Yigit
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 4/6] examples/kni: monitor and update link status continually Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 5/6] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-17 1:04 ` [dpdk-dev] [PATCH v4 6/6] examples/kni: improve zeroing statistics Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 1/5] " Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 2/5] kni: set default carrier state of interface Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-10-22 12:51 ` Ferruh Yigit
2018-10-22 20:04 ` Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-19 0:23 ` [dpdk-dev] [PATCH v5 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-10-22 13:03 ` [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface Ferruh Yigit
2018-10-22 13:08 ` Thomas Monjalon
2018-10-22 13:14 ` Ferruh Yigit
2018-10-22 13:18 ` Thomas Monjalon
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 " Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 1/5] " Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 2/5] kni: set default carrier state of interface Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-24 20:46 ` Stephen Hemminger
2018-10-24 20:56 ` Dan Gora
2018-10-24 21:17 ` Stephen Hemminger
2018-10-24 21:45 ` Dan Gora
2018-10-24 20:27 ` [dpdk-dev] [PATCH v6 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 0/5] kni: add API to set link status on kernel interface Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 1/5] " Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 2/5] kni: set default carrier state of interface Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 3/5] examples/kni: monitor and update link status continually Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 4/5] examples/kni: add log msgs to show and clear stats Dan Gora
2018-10-24 22:26 ` [dpdk-dev] [PATCH v7 5/5] examples/kni: improve zeroing statistics Dan Gora
2018-10-25 12:30 ` [dpdk-dev] [PATCH v7 0/5] kni: add API to set link status on kernel interface Ferruh Yigit
2018-10-26 17:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a1acbe-53ff-6bdc-e313-c2e720f5ef73@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dg@adax.com \
--cc=iryzhov@nfware.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).