From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9A3431B93E for ; Fri, 11 Jan 2019 11:05:35 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D64E1C0C8CFA; Fri, 11 Jan 2019 10:05:34 +0000 (UTC) Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08B1F60C7F; Fri, 11 Jan 2019 10:05:29 +0000 (UTC) To: Jens Freimann , dev@dpdk.org Cc: tiwei.bie@intel.com References: <20190111093929.10162-1-jfreimann@redhat.com> From: Maxime Coquelin Message-ID: <46ab6b84-96b2-61d4-6df0-f340f3b8abb0@redhat.com> Date: Fri, 11 Jan 2019 11:05:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190111093929.10162-1-jfreimann@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 11 Jan 2019 10:05:34 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 0/2] net/virtio-user: add packed vq support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 10:05:35 -0000 On 1/11/19 10:39 AM, Jens Freimann wrote: > Patch 1 fixes a bug in virtio_pq_send_command(). When we wait for > a descriptor to be marked as used we need to consider that the ring > might have wrapped and use the previous wrap counter. > > Patch 2 reverts the patch to error out when cq is used with packed vq and > add support for packed virtqueues in control virtqueue code. > > v3->v4: > * it's enough to add to add packed vq feature bit to > unsupported_features if packed_vq=0, no need to explicitly add > it to device_features (Tiwei) > > v2->v3: > * squash revert patch into patch 2 > * add new patch 1 to fix a bug in driver code > * fix wrap handling code in virtio_user_handle_cq_packed > * in v2 I was using wrap counters and indexes from shared virtqueue, > fixed this and added wrap counters and used index to virtio_user code > * tested wrap around of ring > > v1->v2: > * split into two patches > * handle ring wrap correctly > * add to unsupported_features when packed_vq is 0 > > Jens Freimann (2): > net/virtio: check head desc with correct wrap counter > net/virtio-user: ctrl vq support for packed > > drivers/net/virtio/virtio_ethdev.c | 11 +- > .../net/virtio/virtio_user/virtio_user_dev.c | 102 ++++++++++++++++-- > .../net/virtio/virtio_user/virtio_user_dev.h | 15 ++- > drivers/net/virtio/virtio_user_ethdev.c | 56 +++++++++- > drivers/net/virtio/virtqueue.h | 10 +- > 5 files changed, 171 insertions(+), 23 deletions(-) > Applied to dpdk-next-virtio/master. Thanks, Maxime