DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
	thomas@monjalon.net, david.marchand@redhat.com
Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, jerinj@marvell.com,
	jerinjacobk@gmail.com, Ruifeng.Wang@arm.com,
	viktorin@rehivetech.com, bruce.richardson@intel.com,
	juraj.linkes@pantheon.tech, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: fix compile error with gcc8.3 and thunderx2
Date: Wed, 19 May 2021 13:30:20 +0100	[thread overview]
Message-ID: <46abc8a3-1e1f-55c4-ca22-d61c7489ef84@intel.com> (raw)
In-Reply-To: <1621425281-2413-1-git-send-email-fengchengwen@huawei.com>

On 5/19/2021 12:54 PM, Chengwen Feng wrote:
> Compile error with gcc8.3 and crossfile arm64_thunderx2_linux_gcc:
> 	../drivers/net/hns3/hns3_rxtx_vec_sve.c
> 	cc1: error: switch ‘-mcpu=armv8.1-a’ conflicts with
> 	‘-march=armv8.2-a’ switch [-Werror]
> 	../drivers/net/hns3/hns3_rxtx_vec_sve.c:5:10: fatal error:
> 	arm_sve.h: No such file or directory
> 	    5 | #include <arm_sve.h>
> 
> The root cause is that gcc8.3 supports SVE, but it doesn't support
> compile ACLE[1] SVE code, and the hns3_rxtx_vec_sve.c was written
> by ACLE SVE code.
> 
> This patch also filters out '-march=' '-mcpu' '-mtune' when compile
> with hns3_rxtx_vec_sve.c.
> 
> [1] ACLE: Arm C Language Extensions, user should include <arm_sve.h>
> when writing ACLE SVE code.
> 
> Fixes: 203fbaf8813d ("net/hns3: refactor SVE code compile method")
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>

Hi Chengwen,

We need CI result to proceed with the patch, since I don't have arm platfrom to
test this properly.

But in the CI applying patch fails, I guess that is because the original patch
has been dropped in the next-net.

Can you please send a new version of the patch rebased on top of latest next-net?

  reply	other threads:[~2021-05-19 12:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 11:47 [dpdk-dev] [PATCH] net/hns3: fix compile error with gcc8.3 and crossfile thunderx2 Chengwen Feng
2021-05-19 11:54 ` [dpdk-dev] [PATCH v2] net/hns3: fix compile error with gcc8.3 and thunderx2 Chengwen Feng
2021-05-19 12:30   ` Ferruh Yigit [this message]
2021-05-19 12:42     ` David Marchand
2021-05-19 13:30     ` fengchengwen
2021-05-19 12:34   ` David Marchand
2021-05-19 13:40     ` fengchengwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46abc8a3-1e1f-55c4-ca22-d61c7489ef84@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).