From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id BB0701B8B1; Fri, 8 Feb 2019 11:32:14 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9697FB00058; Fri, 8 Feb 2019 10:32:13 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 8 Feb 2019 10:32:07 +0000 To: Ferruh Yigit , CC: Ivan Malov , References: <1549541873-17403-1-git-send-email-arybchenko@solarflare.com> <1549541873-17403-2-git-send-email-arybchenko@solarflare.com> <2d03e53f-66a5-413a-66fd-6db2842c4a37@intel.com> From: Andrew Rybchenko Message-ID: <46fa4465-1513-57c3-e273-ba9729929cb5@solarflare.com> Date: Fri, 8 Feb 2019 13:31:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <2d03e53f-66a5-413a-66fd-6db2842c4a37@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24416.003 X-TM-AS-Result: No-11.230000-8.000000-10 X-TMASE-MatchedRID: VfovoVrt/oYOwH4pD14DsPHkpkyUphL9u4HArLzuZbc2/UwdvFG5IlO4 BD7nLMxn5pSjkyGV5DZ+1yzFqj1apV/yzOBJu22CF6z9HGHKwNu4vBuE2X0Hleod133eVWP47yh AkRa12DVXBUaDtOU5+LrYi6k4/OQRAMFp5W5WHQKzI1v7J4hECnzIY7d2+Tz9AnW+Tu2Fi4ZR18 QpzXStTi9BUTTI4YWlioFl5UK3cJ/SduMc6RnI+T5bo3ZLMFMHB+dff70WbjnZhqPLU/1bVdJRp J7c9LEB92grUwQgYZd5OPD8XJFfpE1+zyfzlN7ygxsfzkNRlfKx5amWK2anSLVV9mtf2bFYjvlS YaB6immebiOdho3tKod9ieXTjMSaKnu6zYwS6REecxMHUh1R4ieSXmnmVM2Nrcd9YOlbXAsHaDI ySyKyXCh2c9sMni/I X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.230000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24416.003 X-MDID: 1549621934-QjZXe6Uq3zue Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 01/30] net/sfc: log port ID as 16-bit unsigned integer on panic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Feb 2019 10:32:15 -0000 Hi Ferruh, On 2/8/19 1:13 PM, Ferruh Yigit wrote: > On 2/7/2019 12:17 PM, Andrew Rybchenko wrote: >> From: Ivan Malov >> >> Fixes: f8244c6399d9 ("ethdev: increase port id range") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ivan Malov >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/sfc/sfc_debug.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h >> index 6b600ff4d..62f3937e8 100644 >> --- a/drivers/net/sfc/sfc_debug.h >> +++ b/drivers/net/sfc/sfc_debug.h >> @@ -27,7 +27,8 @@ >> do { \ >> const struct sfc_adapter *_sa = (sa); \ >> \ >> - rte_panic("sfc " PCI_PRI_FMT " #%" PRIu8 ": " fmt "\n", \ >> + rte_panic("sfc " PCI_PRI_FMT \ >> + " #%" PRIu16 ": " fmt "\n", \ >> _sa->pci_addr.domain, _sa->pci_addr.bus, \ >> _sa->pci_addr.devid, _sa->pci_addr.function, \ >> _sa->port_id, ##args); \ >> > Overall it may not be good idea to call rte_panic() from driver. rte_panic() > cause the DPDK application to terminate, if a driver fails application may > prefer to handle that error and continue to run, so terminate decision should be > from application not library. > > Can you please double check if rte_panic() usages in the driver can be converted > to error reporting? Thanks a lot for reminder. We use it in few places, but even those can be improved. We'll do it. Andrew.